From: coverity-bot <keescook@chromium.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: tsens_set_trips(): UNINIT
Date: Mon, 28 Oct 2019 16:04:59 -0700 [thread overview]
Message-ID: <201910281604.B32865F50@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
Coverity reported the following:
*** CID 1487367: (UNINIT)
/drivers/thermal/qcom/tsens-common.c: 427 in tsens_set_trips()
421
422 high_val = tsens_mC_to_hw(s, cl_high);
423 low_val = tsens_mC_to_hw(s, cl_low);
424
425 spin_lock_irqsave(&priv->ul_lock, flags);
426
vvv CID 1487367: (UNINIT)
vvv Using uninitialized value "d.up_viol" when calling "tsens_read_irq_state".
427 tsens_read_irq_state(priv, hw_id, s, &d);
428
429 /* Write the new thresholds and clear the status */
430 regmap_field_write(priv->rf[LOW_THRESH_0 + hw_id], low_val);
431 regmap_field_write(priv->rf[UP_THRESH_0 + hw_id], high_val);
432 tsens_set_interrupt(priv, hw_id, LOWER, true);
/drivers/thermal/qcom/tsens-common.c: 427 in tsens_set_trips()
421
422 high_val = tsens_mC_to_hw(s, cl_high);
423 low_val = tsens_mC_to_hw(s, cl_low);
424
425 spin_lock_irqsave(&priv->ul_lock, flags);
426
vvv CID 1487367: (UNINIT)
vvv Using uninitialized value "d.low_viol" when calling "tsens_read_irq_state".
427 tsens_read_irq_state(priv, hw_id, s, &d);
428
429 /* Write the new thresholds and clear the status */
430 regmap_field_write(priv->rf[LOW_THRESH_0 + hw_id], low_val);
431 regmap_field_write(priv->rf[UP_THRESH_0 + hw_id], high_val);
432 tsens_set_interrupt(priv, hw_id, LOWER, true);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487367 ("UNINIT")
Fixes: fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-10-28 23:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281604.B32865F50@keescook \
--to=keescook@chromium.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).