* Coverity: tsens_set_trips(): UNINIT
@ 2019-10-28 23:04 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2019-10-28 23:04 UTC (permalink / raw)
To: Amit Kucheria
Cc: Stephen Boyd, Daniel Lezcano, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
Coverity reported the following:
*** CID 1487367: (UNINIT)
/drivers/thermal/qcom/tsens-common.c: 427 in tsens_set_trips()
421
422 high_val = tsens_mC_to_hw(s, cl_high);
423 low_val = tsens_mC_to_hw(s, cl_low);
424
425 spin_lock_irqsave(&priv->ul_lock, flags);
426
vvv CID 1487367: (UNINIT)
vvv Using uninitialized value "d.up_viol" when calling "tsens_read_irq_state".
427 tsens_read_irq_state(priv, hw_id, s, &d);
428
429 /* Write the new thresholds and clear the status */
430 regmap_field_write(priv->rf[LOW_THRESH_0 + hw_id], low_val);
431 regmap_field_write(priv->rf[UP_THRESH_0 + hw_id], high_val);
432 tsens_set_interrupt(priv, hw_id, LOWER, true);
/drivers/thermal/qcom/tsens-common.c: 427 in tsens_set_trips()
421
422 high_val = tsens_mC_to_hw(s, cl_high);
423 low_val = tsens_mC_to_hw(s, cl_low);
424
425 spin_lock_irqsave(&priv->ul_lock, flags);
426
vvv CID 1487367: (UNINIT)
vvv Using uninitialized value "d.low_viol" when calling "tsens_read_irq_state".
427 tsens_read_irq_state(priv, hw_id, s, &d);
428
429 /* Write the new thresholds and clear the status */
430 regmap_field_write(priv->rf[LOW_THRESH_0 + hw_id], low_val);
431 regmap_field_write(priv->rf[UP_THRESH_0 + hw_id], high_val);
432 tsens_set_interrupt(priv, hw_id, LOWER, true);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487367 ("UNINIT")
Fixes: fbfe1a042cfd ("drivers: thermal: tsens: Add interrupt support")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-10-28 23:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 23:04 Coverity: tsens_set_trips(): UNINIT coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).