From: coverity-bot <keescook@chromium.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: perf_install_in_context(): Integer handling issues
Date: Mon, 4 Nov 2019 09:43:20 -0800 [thread overview]
Message-ID: <201911040943.49068D0@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
db0503e4f675 ("perf/core: Optimize perf_install_in_event()")
Coverity reported the following:
*** CID 711630: Integer handling issues (NEGATIVE_RETURNS)
/kernel/events/core.c: 2683 in perf_install_in_context()
2677 if (__perf_effective_state(event) == PERF_EVENT_STATE_OFF && ctx->nr_events) {
2678 raw_spin_lock_irq(&ctx->lock);
2679 if (ctx->task == TASK_TOMBSTONE) {
2680 raw_spin_unlock_irq(&ctx->lock);
2681 return;
2682 }
vvv CID 711630: Integer handling issues (NEGATIVE_RETURNS)
vvv "event->cpu" is passed to a parameter that cannot be negative.
2683 add_event_to_ctx(event, ctx);
2684 raw_spin_unlock_irq(&ctx->lock);
2685 return;
2686 }
2687
2688 if (!task) {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 711630 ("Integer handling issues")
Fixes: db0503e4f675 ("perf/core: Optimize perf_install_in_event()")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2019-11-04 17:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911040943.49068D0@keescook \
--to=keescook@chromium.org \
--cc=andi@firstfloor.org \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).