linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steven Rostedt <rostedt@goodmis.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: linux-next: manual merge of the ftrace tree with the arm64 tree
Date: Fri, 15 Nov 2019 13:53:57 +1100	[thread overview]
Message-ID: <20191115135357.10386fac@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 2256 bytes --]

Hi all,

Today's linux-next merge of the ftrace tree got a conflict in:

  include/asm-generic/vmlinux.lds.h

between commit:

  a1326b17ac03 ("module/ftrace: handle patchable-function-entry")

from the arm64 tree and commit:

  b83b43ffc6e4 ("fgraph: Fix function type mismatches of ftrace_graph_return using ftrace_stub")

from the ftrace tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc include/asm-generic/vmlinux.lds.h
index 63cedc3c0c77,0f358be551cd..000000000000
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@@ -136,19 -110,30 +136,29 @@@
  #endif
  
  #ifdef CONFIG_FTRACE_MCOUNT_RECORD
 -#ifdef CC_USING_PATCHABLE_FUNCTION_ENTRY
 +/*
 + * The ftrace call sites are logged to a section whose name depends on the
 + * compiler option used. A given kernel image will only use one, AKA
 + * FTRACE_CALLSITE_SECTION. We capture all of them here to avoid header
 + * dependencies for FTRACE_CALLSITE_SECTION's definition.
 + */
+ /*
+  * Need to also make ftrace_graph_stub point to ftrace_stub
+  * so that the same stub location may have different protocols
+  * and not mess up with C verifiers.
+  */
 -#define MCOUNT_REC()	. = ALIGN(8);				\
 -			__start_mcount_loc = .;			\
 -			KEEP(*(__patchable_function_entries))	\
 -			__stop_mcount_loc = .;			\
 -			ftrace_graph_stub = ftrace_stub;
 -#else
  #define MCOUNT_REC()	. = ALIGN(8);				\
  			__start_mcount_loc = .;			\
  			KEEP(*(__mcount_loc))			\
 +			KEEP(*(__patchable_function_entries))	\
- 			__stop_mcount_loc = .;
+ 			__stop_mcount_loc = .;			\
+ 			ftrace_graph_stub = ftrace_stub;
 -#endif
  #else
- #define MCOUNT_REC()
+ # ifdef CONFIG_FUNCTION_TRACER
+ #  define MCOUNT_REC()	ftrace_graph_stub = ftrace_stub;
+ # else
+ #  define MCOUNT_REC()
+ # endif
  #endif
  
  #ifdef CONFIG_TRACE_BRANCH_PROFILING

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-11-15  2:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15  2:53 Stephen Rothwell [this message]
2019-11-15 12:25 ` linux-next: manual merge of the ftrace tree with the arm64 tree Mark Rutland
2019-11-15 13:48   ` Steven Rostedt
2019-11-15 13:59     ` Catalin Marinas
2019-11-15 14:21       ` Steven Rostedt
2019-11-15 14:24         ` Catalin Marinas
2019-11-25  2:31 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115135357.10386fac@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).