From: Steven Rostedt <rostedt@goodmis.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue
Date: Thu, 27 Feb 2020 09:25:18 -0500 [thread overview]
Message-ID: <20200227092518.2096344e@gandalf.local.home> (raw)
In-Reply-To: <CAMuHMdW+JECxNPX8yDswARq+fLXig7VAo0oosCPAkZhtc_XR0g@mail.gmail.com>
On Thu, 27 Feb 2020 10:18:08 +0100
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Hiramatsu-san,
>
> On Tue, Feb 25, 2020 at 4:47 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > Since commit d8a953ddde5e ("bootconfig: Set CONFIG_BOOT_CONFIG=n by
> > default") also changed the CONFIG_BOOTTIME_TRACING to select
> > CONFIG_BOOT_CONFIG to show the boot-time tracing on the menu,
> > it introduced wrong dependencies with BLK_DEV_INITRD as below.
> >
> > WARNING: unmet direct dependencies detected for BOOT_CONFIG
> > Depends on [n]: BLK_DEV_INITRD [=n]
> > Selected by [y]:
> > - BOOTTIME_TRACING [=y] && TRACING_SUPPORT [=y] && FTRACE [=y] && TRACING [=y]
> >
> > This makes the CONFIG_BOOT_CONFIG selects CONFIG_BLK_DEV_INITRD to
> > fix this error and make CONFIG_BOOTTIME_TRACING=n by default, so
> > that both boot-time tracing and boot configuration off but those
> > appear on the menu list.
> >
> > Fixes: d8a953ddde5e ("bootconfig: Set CONFIG_BOOT_CONFIG=n by default")
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > init/Kconfig | 2 +-
> > kernel/trace/Kconfig | 1 -
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index a84e7aa89a29..8b4c3e8c05ea 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1217,7 +1217,7 @@ endif
> >
> > config BOOT_CONFIG
> > bool "Boot config support"
> > - depends on BLK_DEV_INITRD
> > + select BLK_DEV_INITRD
> > help
> > Extra boot config allows system admin to pass a config file as
> > complemental extension of kernel cmdline when booting.
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index 795c3e02d3f1..402eef84c859 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -145,7 +145,6 @@ config BOOTTIME_TRACING
> > bool "Boot-time Tracing support"
> > depends on TRACING
>
> Why not "depends on BLK_DEV_INITRD?" here?
>
> /me tries to contain the bloat introduced by the bootconfig stuff.
Because people like me will be scratching my head trying to figure out why
I don't see Boot-time Tracing support ;-)
-- Steve
>
> > select BOOT_CONFIG
> > - default y
> > help
> > Enable developer to setup ftrace subsystem via supplemental
> > kernel cmdline at boot time for debugging (tracing) driver
>
> Gr{oetje,eeting}s,
>
> Geert
>
next prev parent reply other threads:[~2020-02-27 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 3:24 linux-next: Tree for Feb 25 Stephen Rothwell
2020-02-25 6:58 ` linux-next: Tree for Feb 25 (BOOT_CONFIG) Randy Dunlap
2020-02-25 10:23 ` Masami Hiramatsu
2020-02-25 13:05 ` Masami Hiramatsu
2020-02-25 14:36 ` [PATCH] bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue Masami Hiramatsu
2020-02-25 17:49 ` Randy Dunlap
2020-02-25 17:53 ` Steven Rostedt
2020-02-25 17:59 ` Randy Dunlap
2020-02-26 1:34 ` Masami Hiramatsu
2020-02-27 9:18 ` Geert Uytterhoeven
2020-02-27 13:22 ` Masami Hiramatsu
2020-02-27 14:25 ` Steven Rostedt [this message]
2020-02-27 14:33 ` Geert Uytterhoeven
2020-02-27 16:38 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227092518.2096344e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).