* [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
@ 2020-06-29 16:43 Randy Dunlap
2020-06-29 19:25 ` Bjorn Andersson
2020-07-10 15:28 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-06-29 16:43 UTC (permalink / raw)
To: LKML, linux-next, Rob Herring, Frank Rowand
Cc: devicetree, Andy Gross, Bjorn Andersson, linux-arm-msm
From: Randy Dunlap <rdunlap@infradead.org>
Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
by adding a stub for of_get_next_parent().
../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: devicetree@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
---
include/linux/of.h | 5 +++++
1 file changed, 5 insertions(+)
--- linux-next-20200629.orig/include/linux/of.h
+++ linux-next-20200629/include/linux/of.h
@@ -630,6 +630,11 @@ static inline struct device_node *of_get
return NULL;
}
+static inline struct device_node *of_get_next_parent(struct device_node *node)
+{
+ return NULL;
+}
+
static inline struct device_node *of_get_next_child(
const struct device_node *node, struct device_node *prev)
{
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
2020-06-29 16:43 [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error Randy Dunlap
@ 2020-06-29 19:25 ` Bjorn Andersson
2020-07-10 15:28 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2020-06-29 19:25 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-next, Rob Herring, Frank Rowand, devicetree,
Andy Gross, linux-arm-msm
On Mon 29 Jun 09:43 PDT 2020, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
> by adding a stub for of_get_next_parent().
>
> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> include/linux/of.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> --- linux-next-20200629.orig/include/linux/of.h
> +++ linux-next-20200629/include/linux/of.h
> @@ -630,6 +630,11 @@ static inline struct device_node *of_get
> return NULL;
> }
>
> +static inline struct device_node *of_get_next_parent(struct device_node *node)
> +{
> + return NULL;
> +}
> +
> static inline struct device_node *of_get_next_child(
> const struct device_node *node, struct device_node *prev)
> {
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
2020-06-29 16:43 [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error Randy Dunlap
2020-06-29 19:25 ` Bjorn Andersson
@ 2020-07-10 15:28 ` Rob Herring
2020-07-10 23:40 ` Randy Dunlap
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2020-07-10 15:28 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, linux-next, Frank Rowand, devicetree, Andy Gross,
Bjorn Andersson, linux-arm-msm
On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
> by adding a stub for of_get_next_parent().
>
> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>
Fixes tag?
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: Andy Gross <agross@kernel.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> ---
> include/linux/of.h | 5 +++++
> 1 file changed, 5 insertions(+)
I'm assuming this will be applied to the tree that introduced the problem.
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
2020-07-10 15:28 ` Rob Herring
@ 2020-07-10 23:40 ` Randy Dunlap
2020-07-11 1:59 ` Stephen Rothwell
2020-07-11 19:41 ` Bjorn Andersson
0 siblings, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2020-07-10 23:40 UTC (permalink / raw)
To: Rob Herring
Cc: LKML, linux-next, Frank Rowand, devicetree, Andy Gross,
Bjorn Andersson, linux-arm-msm, Akash Asthana
On 7/10/20 8:28 AM, Rob Herring wrote:
> On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
>> by adding a stub for of_get_next_parent().
>>
>> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
>> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>
>
> Fixes tag?
Are linux-next hashes/tags stable?
Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Frank Rowand <frowand.list@gmail.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: Andy Gross <agross@kernel.org>
>> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> ---
>> include/linux/of.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> I'm assuming this will be applied to the tree that introduced the problem.
>
> Acked-by: Rob Herring <robh@kernel.org>
>
Hi Akash,
Can you add this patch to your tree, as Rob indicated above?
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
2020-07-10 23:40 ` Randy Dunlap
@ 2020-07-11 1:59 ` Stephen Rothwell
2020-07-11 19:41 ` Bjorn Andersson
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-07-11 1:59 UTC (permalink / raw)
To: Randy Dunlap
Cc: Rob Herring, LKML, linux-next, Frank Rowand, devicetree,
Andy Gross, Bjorn Andersson, linux-arm-msm, Akash Asthana
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
Hi Randy,
On Fri, 10 Jul 2020 16:40:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Are linux-next hashes/tags stable?
That depends on the maintainer of the tree I fetch ... In this case the
qcom tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error
2020-07-10 23:40 ` Randy Dunlap
2020-07-11 1:59 ` Stephen Rothwell
@ 2020-07-11 19:41 ` Bjorn Andersson
1 sibling, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2020-07-11 19:41 UTC (permalink / raw)
To: Randy Dunlap
Cc: Rob Herring, LKML, linux-next, Frank Rowand, devicetree,
Andy Gross, linux-arm-msm, Akash Asthana
On Fri 10 Jul 16:40 PDT 2020, Randy Dunlap wrote:
> On 7/10/20 8:28 AM, Rob Herring wrote:
> > On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> From: Randy Dunlap <rdunlap@infradead.org>
> >>
> >> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
> >> by adding a stub for of_get_next_parent().
> >>
> >> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
> >> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>
> >
> > Fixes tag?
>
> Are linux-next hashes/tags stable?
>
Yes, the hashes of the Qualcomm tree are stable.
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
>
Thank you, added this to the commit and...
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Frank Rowand <frowand.list@gmail.com>
> >> Cc: devicetree@vger.kernel.org
> >> Cc: Andy Gross <agross@kernel.org>
> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> >> Cc: linux-arm-msm@vger.kernel.org
> >> ---
> >> include/linux/of.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >
> > I'm assuming this will be applied to the tree that introduced the problem.
> >
> > Acked-by: Rob Herring <robh@kernel.org>
> >
>
> Hi Akash,
> Can you add this patch to your tree, as Rob indicated above?
>
...applied it to the Qualcomm "drivers" tree for 5.9.
Thanks for the patch Randy and thanks for the Ack, Rob.
Regards,
Bjorn
> thanks.
> --
> ~Randy
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-11 19:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 16:43 [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to fix qcom build error Randy Dunlap
2020-06-29 19:25 ` Bjorn Andersson
2020-07-10 15:28 ` Rob Herring
2020-07-10 23:40 ` Randy Dunlap
2020-07-11 1:59 ` Stephen Rothwell
2020-07-11 19:41 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).