From: Will Deacon <will@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Barry Song <song.bao.hua@hisilicon.com>
Subject: Re: linux-next: manual merge of the akpm-current tree with the arm64 tree
Date: Thu, 16 Jul 2020 09:23:40 +0100 [thread overview]
Message-ID: <20200716082339.GA6745@willie-the-truck> (raw)
In-Reply-To: <20200716180012.032723a9@canb.auug.org.au>
On Thu, Jul 16, 2020 at 06:00:12PM +1000, Stephen Rothwell wrote:
> Today's linux-next merge of the akpm-current tree got a conflict in:
>
> arch/arm64/mm/init.c
>
> between commit:
>
> abb7962adc80 ("arm64/hugetlb: Reserve CMA areas for gigantic pages on 16K and 64K configs")
>
> from the arm64 tree and commit:
>
> 10d44973d8ab ("mm/hugetlb: split hugetlb_cma in nodes with memory")
>
> from the akpm-current tree.
[...]
> diff --cc arch/arm64/mm/init.c
> index f8c19c6c8e71,ee551d71c4dd..000000000000
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@@ -421,22 -421,21 +421,21 @@@ void __init bootmem_init(void
> arm64_numa_init();
>
> /*
> - * must be done after arm64_numa_init() which calls numa_init() to
> - * initialize node_online_map that gets used in hugetlb_cma_reserve()
> - * while allocating required CMA size across online nodes.
> + * sparse_init() tries to allocate memory from memblock, so must be
> + * done after the fixed reservations
> */
> - #if defined(CONFIG_HUGETLB_PAGE) && defined(CONFIG_CMA)
> - arm64_hugetlb_cma_reserve();
> - #endif
> + sparse_init();
> + zone_sizes_init(min, max);
>
> /*
> - * Sparsemem tries to allocate bootmem in memory_present(), so must be
> - * done after the fixed reservations.
> + * must be done after zone_sizes_init() which calls free_area_init()
> + * that calls node_set_state() to initialize node_states[N_MEMORY]
> + * because hugetlb_cma_reserve() will scan over nodes with N_MEMORY
> + * state
> */
> - memblocks_present();
> -
> - sparse_init();
> - zone_sizes_init(min, max);
> -#ifdef CONFIG_ARM64_4K_PAGES
> - hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
> ++#if defined(CONFIG_HUGETLB_PAGE) && defined(CONFIG_CMA)
> ++ arm64_hugetlb_cma_reserve();
> + #endif
Thanks, looks good to me, although we might be in for a hairier conflict
if the discussion at [1] ends up with a patch for merging.
Will
[1] https://lore.kernel.org/r/359ea1d0-b1fd-d09f-d28a-a44655834277@oracle.com
next prev parent reply other threads:[~2020-07-16 8:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:00 linux-next: manual merge of the akpm-current tree with the arm64 tree Stephen Rothwell
2020-07-16 8:23 ` Will Deacon [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-08 6:04 Stephen Rothwell
2021-10-08 7:37 ` Will Deacon
2021-04-13 8:59 Stephen Rothwell
2021-04-13 9:14 ` Catalin Marinas
2020-12-03 8:06 Stephen Rothwell
2020-12-03 11:16 ` Catalin Marinas
2020-09-21 8:03 Stephen Rothwell
2020-09-21 8:12 ` Catalin Marinas
2020-10-13 7:34 ` Stephen Rothwell
2020-04-30 6:26 Stephen Rothwell
2020-04-29 6:53 Stephen Rothwell
2019-08-07 6:39 Stephen Rothwell
2018-12-13 6:01 Stephen Rothwell
2018-12-13 11:12 ` Will Deacon
2018-12-11 6:11 linux-next: manual merge of the akpm-current tree with the FIXME tree Stephen Rothwell
2018-12-11 6:12 ` linux-next: manual merge of the akpm-current tree with the arm64 tree Stephen Rothwell
2018-12-11 10:39 ` Will Deacon
2018-12-11 6:02 Stephen Rothwell
2018-09-24 4:38 Stephen Rothwell
2018-09-24 9:32 ` Catalin Marinas
2018-07-27 10:55 Stephen Rothwell
2018-08-16 0:11 ` Stephen Rothwell
2017-11-06 5:33 Stephen Rothwell
2016-09-27 6:03 Stephen Rothwell
2016-06-22 4:54 Stephen Rothwell
2015-12-16 5:01 Stephen Rothwell
2015-12-16 10:14 ` Will Deacon
2014-09-23 7:23 Stephen Rothwell
2014-09-23 8:36 ` Catalin Marinas
2014-07-24 8:42 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716082339.GA6745@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).