linux-next: Signed-off-by missing for commit in the vhost tree

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

ommit

  ed944d574cc7 ("ack! virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM")

is missing a Signed-off-by from its author and committer.

I have never seen an empty commit like this before - I assume it is just
a way to add an Reviewed-by to a previous commit without rebaseing
the tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the vhost tree

[Michael S. Tsirkin]

On Tue, Jul 28, 2020 at 08:05:56AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> ommit
> 
>   ed944d574cc7 ("ack! virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM")
> 
> is missing a Signed-off-by from its author and committer.
> 
> I have never seen an empty commit like this before - I assume it is just
> a way to add an Reviewed-by to a previous commit without rebaseing
> the tree.

Yes - I'm using these to record acks, then squash before the pull
request. git patches I'm using to support this are here - I've rebased
since but didn't have the energy to advocate for upstreaming:
https://lore.kernel.org/r/1460296343-17304-1-git-send-email-mst%40redhat.com


> -- 
> Cheers,
> Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the vhost tree

[Michael S. Tsirkin]

On Thu, Oct 19, 2023 at 08:43:09AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   34ad6689c509 ("vdpa/mlx5: Expose descriptor group mkey hw capability")
> 
> is missing a Signed-off-by from its committer.

Fixed, thanks for letting me know!

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Hi all,

Commit

  34ad6689c509 ("vdpa/mlx5: Expose descriptor group mkey hw capability")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

Hi all,

Commit

  74de20d838d7 ("virtio_ring: fix avail_wrap_counter in virtqueue_add_packed")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  6ebd1a1d1f9d ("vdpa_sim: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

Hi all,

Commit

  45eaa1bb9e21 ("vdpa_sim: offer VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi all,

Commit

  4f48d30af284 ("vdpa: clean up get_config_size ret value handling")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

Hi all,

Commits

  4db90b5a8281 ("ack! virtio_ring: Fix two use after free bugs")
  400228b7e0c4 ("ack! virtio_net: Fix error code in probe()")
  35fc22b6228d ("ack! virtio_ring: Cut and paste bugs in vring_create_virtqueue_packed()")

are missing a Signed-off-by from their author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi all,

Commit

  6bd262d5eafc ("Revert "vhost/net: add an option to test new code"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well (and should have reasonable commit messages).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the vhost tree

[Michael S. Tsirkin]

On Fri, Feb 15, 2019 at 07:17:02AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   8fcf13f6be52 ("mm/page_poison: update comment after code moved")
> 
> is missing a Signed-off-by from its author and committer.

Thanks!
It's upstream already anyway, I will drop it.

> -- 
> Cheers,
> Stephen Rothwell

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  8fcf13f6be52 ("mm/page_poison: update comment after code moved")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the vhost tree

[Stephen Rothwell]

Hi Michael,

Commit

  4824751c76a6 ("virtio: make VIRTIO a menuconfig to ease disabling it all")

is missing a Signed-off-by from its committer.

It also has 2 sets of Reviewed-by/Tested-by tags from Randy Dunlap.

-- 
Cheers,
Stephen Rothwell