Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Signed-off-by missing for commit in the vhost tree
@ 2020-07-27 22:05 Stephen Rothwell
  2020-07-30 19:53 ` Michael S. Tsirkin
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2020-07-27 22:05 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

Hi all,

ommit

  ed944d574cc7 ("ack! virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM")

is missing a Signed-off-by from its author and committer.

I have never seen an empty commit like this before - I assume it is just
a way to add an Reviewed-by to a previous commit without rebaseing
the tree.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the vhost tree
  2020-07-27 22:05 linux-next: Signed-off-by missing for commit in the vhost tree Stephen Rothwell
@ 2020-07-30 19:53 ` Michael S. Tsirkin
  0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2020-07-30 19:53 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Tue, Jul 28, 2020 at 08:05:56AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> ommit
> 
>   ed944d574cc7 ("ack! virtio: VIRTIO_F_IOMMU_PLATFORM -> VIRTIO_F_ACCESS_PLATFORM")
> 
> is missing a Signed-off-by from its author and committer.
> 
> I have never seen an empty commit like this before - I assume it is just
> a way to add an Reviewed-by to a previous commit without rebaseing
> the tree.

Yes - I'm using these to record acks, then squash before the pull
request. git patches I'm using to support this are here - I've rebased
since but didn't have the energy to advocate for upstreaming:
https://lore.kernel.org/r/1460296343-17304-1-git-send-email-mst%40redhat.com


> -- 
> Cheers,
> Stephen Rothwell



^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Signed-off-by missing for commit in the vhost tree
@ 2019-12-15 20:48 Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2019-12-15 20:48 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Hi all,

Commit

  6bd262d5eafc ("Revert "vhost/net: add an option to test new code"")

is missing a Signed-off-by from its author and committer.

Reverts are commits as well (and should have reasonable commit messages).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: Signed-off-by missing for commit in the vhost tree
  2019-02-14 20:17 Stephen Rothwell
@ 2019-02-14 20:21 ` Michael S. Tsirkin
  0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2019-02-14 20:21 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

On Fri, Feb 15, 2019 at 07:17:02AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   8fcf13f6be52 ("mm/page_poison: update comment after code moved")
> 
> is missing a Signed-off-by from its author and committer.

Thanks!
It's upstream already anyway, I will drop it.

> -- 
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Signed-off-by missing for commit in the vhost tree
@ 2019-02-14 20:17 Stephen Rothwell
  2019-02-14 20:21 ` Michael S. Tsirkin
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-02-14 20:17 UTC (permalink / raw)
  To: Michael S. Tsirkin; +Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  8fcf13f6be52 ("mm/page_poison: update comment after code moved")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: Signed-off-by missing for commit in the vhost tree
@ 2018-01-31  0:14 Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2018-01-31  0:14 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Vincent Legoll, Randy Dunlap

Hi Michael,

Commit

  4824751c76a6 ("virtio: make VIRTIO a menuconfig to ease disabling it all")

is missing a Signed-off-by from its committer.

It also has 2 sets of Reviewed-by/Tested-by tags from Randy Dunlap.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 22:05 linux-next: Signed-off-by missing for commit in the vhost tree Stephen Rothwell
2020-07-30 19:53 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2019-12-15 20:48 Stephen Rothwell
2019-02-14 20:17 Stephen Rothwell
2019-02-14 20:21 ` Michael S. Tsirkin
2018-01-31  0:14 Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git