linux-next: Fixes tags need some work in the kvm-fixes tree

linux-next: Fixes tags need some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 917 bytes --]

Hi all,

In commit

  830f01b089b1 ("KVM: SVM: Fix disable pause loop exit/pause filtering capability on SVM")

Fixes tag

  Fixes: 8566ac8b ("KVM: SVM: Implement pause loop exit logic in SVM")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

In commit

  d2286ba7d574 ("KVM: LAPIC: Prevent setting the tscdeadline timer if the lapic is hw disabled")

Fixes tag

  Fixes: bce87cce88 (KVM: x86: consolidate different ways to test for in-kernel LAPIC)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Something to remember for next time.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tags need some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

Hi all,

In commit

  38d9a4ac65f2 ("RISC-V: KVM: Restrict the extensions that can be disabled")

Fixes tag

  Fixes: 92ad82002c39 ("RISC-V: KVM: Implement

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  3ab75a793e49 ("RISC-V: KVM: Remove 's' & 'u' as valid ISA extension")

Fixes tag

  Fixes: a33c72faf2d7 ("RISC-V: KVM: Implement VCPU create, init and

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the kvm-fixes tree

[Atish Kumar Patra]

On Thu, Apr 21, 2022 at 2:50 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   38d9a4ac65f2 ("RISC-V: KVM: Restrict the extensions that can be disabled")
>
> Fixes tag
>
>   Fixes: 92ad82002c39 ("RISC-V: KVM: Implement
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> In commit
>
>   3ab75a793e49 ("RISC-V: KVM: Remove 's' & 'u' as valid ISA extension")
>
> Fixes tag
>
>   Fixes: a33c72faf2d7 ("RISC-V: KVM: Implement VCPU create, init and
>
> has these problem(s):
>
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line.
>
Sorry for that.
This probably happened while copying the fixes tag from mail to the
actual patch.
Let me know if I should resend the patches with correctly formatted fixes tag.


> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tags need some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Hi all,

In commit

  4054eee92902 ("RISC-V: KVM: include missing hwcap.h into vcpu_fp")

Fixes tag

  Fixes: 0a86512dc113 ("RISC-V: KVM: Factor-out FP virtualization into separate

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  ebdef0de2dbc ("KVM: selftests: riscv: Fix alignment of the guest_hang() function")

Fixes tag

  Fixes: 3e06cdf10520 ("KVM: selftests: Add initial support for RISC-V

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

In commit

  fac372536439 ("KVM: selftests: riscv: Set PTE A and D bits in VS-stage page table")

Fixes tag

  Fixes: 3e06cdf10520 ("KVM: selftests: Add initial support for RISC-V

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the kvm-fixes tree

[Heiko Stübner]

Am Dienstag, 12. April 2022, 00:00:45 CEST schrieb Stephen Rothwell:
> Hi all,
> 
> In commit
> 
>   4054eee92902 ("RISC-V: KVM: include missing hwcap.h into vcpu_fp")
> 
> Fixes tag
> 
>   Fixes: 0a86512dc113 ("RISC-V: KVM: Factor-out FP virtualization into separate

hmm, when I sent it [0], the fixes tag was
Fixes: 0a86512dc113 ("RISC-V: KVM: Factor-out FP virtualization into separate sources")

Did it get somehow mangled when the patch got applied?


[0] https://lore.kernel.org/all/20220408092415.1603661-1-heiko@sntech.de/

> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> In commit
> 
>   ebdef0de2dbc ("KVM: selftests: riscv: Fix alignment of the guest_hang() function")
> 
> Fixes tag
> 
>   Fixes: 3e06cdf10520 ("KVM: selftests: Add initial support for RISC-V
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> In commit
> 
>   fac372536439 ("KVM: selftests: riscv: Set PTE A and D bits in VS-stage page table")
> 
> Fixes tag
> 
>   Fixes: 3e06cdf10520 ("KVM: selftests: Add initial support for RISC-V
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split fixes tags over more than one line.
> 
> 

linux-next: Fixes tags need some work in the kvm-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

Hi all,

In commit

  aaca21007ba1 ("KVM: SVM: Fix the svm vmexit code for WRMSR")

Fixes tag

  Fixes: 1e9e2622a149 ("KVM: VMX: FIXED+PHYSICAL mode single target IPI fastpath", 2019-11-21)

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

In commit

  9a11997e757b ("KVM: X86: Fix dereference null cpufreq policy")

Fixes tag

  Fixes: aaec7c03de (KVM: x86: avoid useless copy of cpufreq policy)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]