From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Brendan Higgins <brendanhiggins@google.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Maguire <alan.maguire@oracle.com>,
Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: linux-next: build failure after merge of the thunderbolt tree
Date: Mon, 10 Aug 2020 13:12:30 +0300 [thread overview]
Message-ID: <20200810101230.GI1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <20200810091053.2757b97f@canb.auug.org.au>
Hi all,
On Mon, Aug 10, 2020 at 09:10:53AM +1000, Stephen Rothwell wrote:
> Hi Linus,
>
> On Sun, 9 Aug 2020 11:04:28 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > On Sun, Aug 9, 2020 at 1:19 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > >
> > > I looks like the above report got lost along the way to you :-(
> >
> > Hmm. Why didn't I see this as a build failure?
> >
> > Oh. Because the USB4_KUNIT_TEST stuff requires everything to be built
> > in. And I have them as modules.
>
> Yeah, I only saw it because I do an allyesconfig build late in my day.
Sorry about this. I was not sure how to deal with this as Thunderbolt
goes through Greg's USB tree, so I just ended up mentioning it in my
pull request without actually including the complete patch.
The reason for the built in dependency is that KUnit adds its own
module_init() in kunit_test_suite() so that causes linker error since
the TBT driver does the same. I guess the better alternative would be to
not use kunit_test_suite() and instead make calls to
__kunit_test_suites_init() and __kunit_test_suites_exit() in the
driver's nhi_init()/nhi_exit().
> > > Here's the patch in case you want to directly apply it:
> >
> > Will do. Thanks,
>
> Thanks.
Thanks!
prev parent reply other threads:[~2020-08-10 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 6:03 linux-next: build failure after merge of the thunderbolt tree Stephen Rothwell
2020-06-30 9:27 ` Alan Maguire
2020-06-30 11:33 ` Mika Westerberg
2020-08-09 0:50 ` Guenter Roeck
2020-08-09 8:18 ` Stephen Rothwell
2020-08-09 18:04 ` Linus Torvalds
2020-08-09 23:10 ` Stephen Rothwell
2020-08-10 10:12 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810101230.GI1375436@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=alan.maguire@oracle.com \
--cc=brendanhiggins@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sfr@canb.auug.org.au \
--cc=skhan@linuxfoundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).