* linux-next: build failure after merge of the pinctrl-intel tree
@ 2020-08-20 1:30 Stephen Rothwell
2020-08-20 9:40 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-08-20 1:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
Hi all,
After merging the pinctrl-intel tree, today's linux-next build (x86_64
allmodconfig) failed like this:
x86_64-linux-gnu-ld: drivers/pinctrl/intel/pinctrl-baytrail.o: in function `byt_pinctrl_probe':
pinctrl-baytrail.c:(.text+0x12bf): undefined reference to `intel_pinctrl_get_soc_data'
Caused by commit
2db97df9f29d ("pinctrl: baytrail: Switch to use intel_pinctrl_get_soc_data()")
CONFIG_PINCTRL_BAYTRAIL=y
CONFIG_PINCTRL_INTEL=m
I have ised the pinctrl-intel tree from next-20200819 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the pinctrl-intel tree
2020-08-20 1:30 linux-next: build failure after merge of the pinctrl-intel tree Stephen Rothwell
@ 2020-08-20 9:40 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-08-20 9:40 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List
On Thu, Aug 20, 2020 at 11:30:39AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pinctrl-intel tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> x86_64-linux-gnu-ld: drivers/pinctrl/intel/pinctrl-baytrail.o: in function `byt_pinctrl_probe':
> pinctrl-baytrail.c:(.text+0x12bf): undefined reference to `intel_pinctrl_get_soc_data'
>
> Caused by commit
>
> 2db97df9f29d ("pinctrl: baytrail: Switch to use intel_pinctrl_get_soc_data()")
Right, I have updated it. Shouldn't be issues now.
> CONFIG_PINCTRL_BAYTRAIL=y
> CONFIG_PINCTRL_INTEL=m
>
> I have ised the pinctrl-intel tree from next-20200819 for today.
Thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the pinctrl-intel tree
2022-10-18 2:13 Stephen Rothwell
2022-10-18 2:20 ` Stephen Rothwell
@ 2022-10-18 12:29 ` Andy Shevchenko
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2022-10-18 12:29 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
On Tue, Oct 18, 2022 at 01:13:30PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the pinctrl-intel tree, today's linux-next build (arm64
> defconfig) failed like this:
>
>
> Presumably caused by commit
>
> e6b665a1c9ae ("pinctrl: Clean up headers")
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Oct 2022 13:06:39 +1100
> Subject: [PATCH] fix up for "pinctrl: Clean up headers"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/pinctrl/pinctrl-zynqmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index 1a94db1ffa4f..f2be341f73e1 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -18,6 +18,7 @@
> #include <linux/firmware/xlnx-zynqmp.h>
>
> #include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> #include <linux/pinctrl/pinmux.h>
Right, thank you for the fix, I'll incorporate it into the original patch.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: build failure after merge of the pinctrl-intel tree
2022-10-18 2:13 Stephen Rothwell
@ 2022-10-18 2:20 ` Stephen Rothwell
2022-10-18 12:29 ` Andy Shevchenko
1 sibling, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2022-10-18 2:20 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 3552 bytes --]
Hi all,
On Tue, 18 Oct 2022 13:13:30 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the pinctrl-intel tree, today's linux-next build (arm64
> defconfig) failed like this:
drivers/pinctrl/pinctrl-zynqmp.c:483:21: error: variable 'zynqmp_pinconf_ops' has initializer but incomplete type
483 | static const struct pinconf_ops zynqmp_pinconf_ops = {
| ^~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:10: error: 'const struct pinconf_ops' has no member named 'is_generic'
484 | .is_generic = true,
| ^~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:23: warning: excess elements in struct initializer
484 | .is_generic = true,
| ^~~~
drivers/pinctrl/pinctrl-zynqmp.c:484:23: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:485:10: error: 'const struct pinconf_ops' has no member named 'pin_config_get'
485 | .pin_config_get = zynqmp_pinconf_cfg_get,
| ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:485:27: warning: excess elements in struct initializer
485 | .pin_config_get = zynqmp_pinconf_cfg_get,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:485:27: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:486:10: error: 'const struct pinconf_ops' has no member named 'pin_config_set'
486 | .pin_config_set = zynqmp_pinconf_cfg_set,
| ^~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:486:27: warning: excess elements in struct initializer
486 | .pin_config_set = zynqmp_pinconf_cfg_set,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:486:27: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:487:10: error: 'const struct pinconf_ops' has no member named 'pin_config_group_set'
487 | .pin_config_group_set = zynqmp_pinconf_group_set,
| ^~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:487:33: warning: excess elements in struct initializer
487 | .pin_config_group_set = zynqmp_pinconf_group_set,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/pinctrl-zynqmp.c:487:33: note: (near initialization for 'zynqmp_pinconf_ops')
drivers/pinctrl/pinctrl-zynqmp.c:483:33: error: storage size of 'zynqmp_pinconf_ops' isn't known
483 | static const struct pinconf_ops zynqmp_pinconf_ops = {
| ^~~~~~~~~~~~~~~~~~
> Presumably caused by commit
>
> e6b665a1c9ae ("pinctrl: Clean up headers")
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Oct 2022 13:06:39 +1100
> Subject: [PATCH] fix up for "pinctrl: Clean up headers"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/pinctrl/pinctrl-zynqmp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
> index 1a94db1ffa4f..f2be341f73e1 100644
> --- a/drivers/pinctrl/pinctrl-zynqmp.c
> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
> @@ -18,6 +18,7 @@
> #include <linux/firmware/xlnx-zynqmp.h>
>
> #include <linux/pinctrl/pinconf-generic.h>
> +#include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinctrl.h>
> #include <linux/pinctrl/pinmux.h>
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* linux-next: build failure after merge of the pinctrl-intel tree
@ 2022-10-18 2:13 Stephen Rothwell
2022-10-18 2:20 ` Stephen Rothwell
2022-10-18 12:29 ` Andy Shevchenko
0 siblings, 2 replies; 5+ messages in thread
From: Stephen Rothwell @ 2022-10-18 2:13 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
Hi all,
After merging the pinctrl-intel tree, today's linux-next build (arm64
defconfig) failed like this:
Presumably caused by commit
e6b665a1c9ae ("pinctrl: Clean up headers")
I have applied the following patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 18 Oct 2022 13:06:39 +1100
Subject: [PATCH] fix up for "pinctrl: Clean up headers"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/pinctrl/pinctrl-zynqmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
index 1a94db1ffa4f..f2be341f73e1 100644
--- a/drivers/pinctrl/pinctrl-zynqmp.c
+++ b/drivers/pinctrl/pinctrl-zynqmp.c
@@ -18,6 +18,7 @@
#include <linux/firmware/xlnx-zynqmp.h>
#include <linux/pinctrl/pinconf-generic.h>
+#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinctrl.h>
#include <linux/pinctrl/pinmux.h>
--
2.35.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-18 12:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-20 1:30 linux-next: build failure after merge of the pinctrl-intel tree Stephen Rothwell
2020-08-20 9:40 ` Andy Shevchenko
2022-10-18 2:13 Stephen Rothwell
2022-10-18 2:20 ` Stephen Rothwell
2022-10-18 12:29 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).