From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage
Date: Mon, 12 Oct 2020 16:13:38 +1100 [thread overview]
Message-ID: <20201012161338.3c94f6e5@canb.auug.org.au> (raw)
In-Reply-To: <20201012085936.241cc62d@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Hi all,
On Mon, 12 Oct 2020 08:59:36 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 9 Oct 2020 14:41:11 +0200 Jiri Olsa <jolsa@redhat.com> wrote:
> >
> > On Fri, Oct 09, 2020 at 02:25:23PM +0200, Vasily Gorbik wrote:
> > > Currently BUILD_BUG() macro is expanded to smth like the following:
> > > do {
> > > extern void __compiletime_assert_0(void)
> > > __attribute__((error("BUILD_BUG failed")));
> > > if (!(!(1)))
> > > __compiletime_assert_0();
> > > } while (0);
> > >
> > > If used in a function body this obviously would produce build errors
> > > with -Wnested-externs and -Werror.
> > >
> > > To enable BUILD_BUG() usage in tools/arch/x86/lib/insn.c which perf
> > > includes in intel-pt-decoder, build perf without -Wnested-externs.
> > >
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> >
> > that one applied nicely ;-) thanks
> >
> > Acked-by: Jiri Olsa <jolsa@redhat.com>
>
> I will apply that patch to the merge of the tip tree today (instead of
> reverting the series I reverted in Friday) (unless I get an update of
> the tip tree containing it, of course).
Tested-by: Stephen Rothwell <sfr@canb.auug.org.au> # build tested
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-12 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 4:28 linux-next: build failure after merge of the tip tree Stephen Rothwell
2020-10-09 6:47 ` Vasily Gorbik
2020-10-09 6:47 ` [PATCH 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage Vasily Gorbik
2020-10-09 11:23 ` Jiri Olsa
2020-10-09 12:25 ` Vasily Gorbik
2020-10-09 12:25 ` [PATCH RESEND " Vasily Gorbik
2020-10-09 12:41 ` Jiri Olsa
2020-10-11 21:59 ` Stephen Rothwell
2020-10-12 5:13 ` Stephen Rothwell [this message]
2020-10-13 19:09 ` Arnaldo Carvalho de Melo
2020-10-13 19:07 ` Arnaldo Carvalho de Melo
2020-10-12 7:06 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012161338.3c94f6e5@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=gor@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).