From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jan Kara <jack@suse.cz>
Cc: Ira Weiny <ira.weiny@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the ext3 tree
Date: Fri, 13 Nov 2020 10:47:36 +1100 [thread overview]
Message-ID: <20201113104736.0d6ea84e@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 4309 bytes --]
Hi all,
After merging the ext3 tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from fs/ext2/file.c:28:
fs/ext2/ext2.h: In function 'ext2_get_page':
fs/ext2/ext2.h:764:28: error: implicit declaration of function 'ext2_check_page'; did you mean 'ext2_get_page'? [-Werror=implicit-function-declaration]
764 | if (PageError(page) || !ext2_check_page(page, quiet))
| ^~~~~~~~~~~~~~~
| ext2_get_page
In file included from fs/ext2/balloc.c:15:
fs/ext2/ext2.h: In function 'ext2_get_page':
fs/ext2/ext2.h:760:22: error: implicit declaration of function 'read_mapping_page'; did you mean 'unmap_mapping_pages'? [-Werror=implicit-function-declaration]
760 | struct page *page = read_mapping_page(mapping, n, NULL);
| ^~~~~~~~~~~~~~~~~
| unmap_mapping_pages
fs/ext2/ext2.h:760:22: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
fs/ext2/ext2.h:764:28: error: implicit declaration of function 'ext2_check_page'; did you mean 'ext2_get_page'? [-Werror=implicit-function-declaration]
764 | if (PageError(page) || !ext2_check_page(page, quiet))
| ^~~~~~~~~~~~~~~
| ext2_get_page
In file included from include/linux/buffer_head.h:14,
from fs/ext2/balloc.c:20:
include/linux/pagemap.h: At top level:
include/linux/pagemap.h:497:28: error: conflicting types for 'read_mapping_page'
497 | static inline struct page *read_mapping_page(struct address_space *mapping,
| ^~~~~~~~~~~~~~~~~
In file included from fs/ext2/balloc.c:15:
fs/ext2/ext2.h:760:22: note: previous implicit declaration of 'read_mapping_page' was here
760 | struct page *page = read_mapping_page(mapping, n, NULL);
| ^~~~~~~~~~~~~~~~~
In file included from fs/ext2/dir.c:25:
fs/ext2/ext2.h: In function 'ext2_get_page':
fs/ext2/ext2.h:760:22: error: implicit declaration of function 'read_mapping_page'; did you mean 'unmap_mapping_pages'? [-Werror=implicit-function-declaration]
760 | struct page *page = read_mapping_page(mapping, n, NULL);
| ^~~~~~~~~~~~~~~~~
| unmap_mapping_pages
fs/ext2/ext2.h:760:22: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
fs/ext2/ext2.h:764:28: error: implicit declaration of function 'ext2_check_page'; did you mean 'ext2_get_page'? [-Werror=implicit-function-declaration]
764 | if (PageError(page) || !ext2_check_page(page, quiet))
| ^~~~~~~~~~~~~~~
| ext2_get_page
In file included from include/linux/buffer_head.h:14,
from fs/ext2/dir.c:26:
include/linux/pagemap.h: At top level:
include/linux/pagemap.h:497:28: error: conflicting types for 'read_mapping_page'
497 | static inline struct page *read_mapping_page(struct address_space *mapping,
| ^~~~~~~~~~~~~~~~~
In file included from fs/ext2/dir.c:25:
fs/ext2/ext2.h:760:22: note: previous implicit declaration of 'read_mapping_page' was here
760 | struct page *page = read_mapping_page(mapping, n, NULL);
| ^~~~~~~~~~~~~~~~~
fs/ext2/dir.c:109:13: error: conflicting types for 'ext2_check_page'
109 | static bool ext2_check_page(struct page *page, int quiet)
| ^~~~~~~~~~~~~~~
In file included from fs/ext2/dir.c:25:
fs/ext2/ext2.h:764:28: note: previous implicit declaration of 'ext2_check_page' was here
764 | if (PageError(page) || !ext2_check_page(page, quiet))
| ^~~~~~~~~~~~~~~
fs/ext2/dir.c:109:13: warning: 'ext2_check_page' defined but not used [-Wunused-function]
109 | static bool ext2_check_page(struct page *page, int quiet)
| ^~~~~~~~~~~~~~~
Caused by commit
32559cea1f55 ("fs/ext2: Use ext2_put_page")
Presumably some missing includes :-(
I have used the ext3 tree from next-20201112 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-11-12 23:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 23:47 Stephen Rothwell [this message]
2020-11-13 10:33 ` linux-next: build failure after merge of the ext3 tree Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2024-03-07 0:07 Stephen Rothwell
2024-03-07 6:18 ` Winston Wen
2024-03-07 12:03 ` Jan Kara
2023-08-16 0:37 Stephen Rothwell
2019-01-31 4:14 Stephen Rothwell
2019-01-31 10:11 ` Jan Kara
2019-01-31 22:09 ` Stephen Rothwell
2014-08-08 1:52 Stephen Rothwell
2014-08-08 9:22 ` Jan Kara
2011-12-28 0:22 Stephen Rothwell
2012-01-02 22:40 ` Jan Kara
2010-03-02 0:36 Stephen Rothwell
2010-03-02 9:07 ` Christoph Hellwig
2010-03-02 17:27 ` Jan Kara
2010-03-03 0:42 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113104736.0d6ea84e@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).