From: Jan Kara <jack@suse.cz>
To: Winston Wen <wentao@uniontech.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Jan Kara <jack@suse.cz>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the ext3 tree
Date: Thu, 7 Mar 2024 13:03:25 +0100 [thread overview]
Message-ID: <20240307120325.44qut2tmlirbav6j@quack3> (raw)
In-Reply-To: <BB8327439DE51911+20240307141837.3c067e2b@winn-pc>
On Thu 07-03-24 14:18:37, Winston Wen wrote:
> On Thu, 7 Mar 2024 11:07:17 +1100
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > Hi all,
> >
> > After merging the ext3 tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from include/linux/sysctl.h:27,
> > from include/linux/fanotify.h:5,
> > from fs/notify/fanotify/fanotify.c:2:
> > fs/notify/fanotify/fanotify.c: In function 'fanotify_get_response':
> > fs/notify/fanotify/fanotify.c:233:48: error: suggest parentheses
> > around arithmetic in operand of '|' [-Werror=parentheses] 233 |
> > TASK_KILLABLE|TASK_FREEZABLE); |
> > ^ include/linux/wait.h:283:11:
> > note: in definition of macro '___wait_is_interruptible' 283 |
> > (state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL))) | ^~~~~
> > include/linux/wait.h:935:9: note: in expansion of macro
> > '___wait_event' 935 | ___wait_event(wq, condition, state, 0,
> > 0, schedule()) | ^~~~~~~~~~~~~
> > include/linux/wait.h:958:25: note: in expansion of macro
> > '__wait_event_state' 958 | __ret =
> > __wait_event_state(wq_head, condition, state); \ |
> > ^~~~~~~~~~~~~~~~~~
> > fs/notify/fanotify/fanotify.c:231:15: note: in expansion of macro
> > 'wait_event_state' 231 | ret =
> > wait_event_state(group->fanotify_data.access_waitq, |
> > ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > 3440e7e55ced ("fanotify: allow freeze when waiting response for
> > permission events")
> >
> > Though, I guess, you could argue that the ___wait_is_interruptible
> > macro should parenthesise the use of its "state" argument.
> >
> > I have used the ext3 tree from next-20240306 for today.
> >
>
> Sorry I missed this warning. And agreed! I can add parentheses on the
> call side, but it may be more reasonable to add them in the macro.
Thanks for fixing this and I agree. For now, I've also pushed out a new
version of your patch with additional parentheses into my tree to unblock
it for linux-next.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-03-07 12:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 0:07 linux-next: build failure after merge of the ext3 tree Stephen Rothwell
2024-03-07 6:18 ` Winston Wen
2024-03-07 12:03 ` Jan Kara [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 0:37 Stephen Rothwell
2020-11-12 23:47 Stephen Rothwell
2020-11-13 10:33 ` Jan Kara
2019-01-31 4:14 Stephen Rothwell
2019-01-31 10:11 ` Jan Kara
2019-01-31 22:09 ` Stephen Rothwell
2014-08-08 1:52 Stephen Rothwell
2014-08-08 9:22 ` Jan Kara
2011-12-28 0:22 Stephen Rothwell
2012-01-02 22:40 ` Jan Kara
2010-03-02 0:36 Stephen Rothwell
2010-03-02 9:07 ` Christoph Hellwig
2010-03-02 17:27 ` Jan Kara
2010-03-03 0:42 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307120325.44qut2tmlirbav6j@quack3 \
--to=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).