* Coverity: qcom_swrm_transport_params(): UNUSED_VALUE
@ 2021-03-31 21:57 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-03-31 21:57 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Pierre-Louis Bossart, Vinod Koul, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
128eaf937adb ("soundwire: qcom: add support to missing transport params")
Coverity reported the following:
*** CID 1503591: (UNUSED_VALUE)
/drivers/soundwire/qcom.c: 672 in qcom_swrm_transport_params()
666
667 ret = ctrl->reg_write(ctrl, reg, value);
668
669 if (pcfg->lane_control != SWR_INVALID_PARAM) {
670 reg = SWRM_DP_PORT_CTRL_2_BANK(params->port_num, bank);
671 value = pcfg->lane_control;
vvv CID 1503591: (UNUSED_VALUE)
vvv Assigning value from "(*ctrl->reg_write)(ctrl, reg, value)" to "ret" here, but that stored value is overwritten before it can be used.
672 ret = ctrl->reg_write(ctrl, reg, value);
673 }
674
675 if (pcfg->blk_group_count != SWR_INVALID_PARAM) {
676 reg = SWRM_DP_BLOCK_CTRL2_BANK(params->port_num, bank);
677 value = pcfg->blk_group_count;
/drivers/soundwire/qcom.c: 678 in qcom_swrm_transport_params()
672 ret = ctrl->reg_write(ctrl, reg, value);
673 }
674
675 if (pcfg->blk_group_count != SWR_INVALID_PARAM) {
676 reg = SWRM_DP_BLOCK_CTRL2_BANK(params->port_num, bank);
677 value = pcfg->blk_group_count;
vvv CID 1503591: (UNUSED_VALUE)
vvv Assigning value from "(*ctrl->reg_write)(ctrl, reg, value)" to "ret" here, but that stored value is overwritten before it can be used.
678 ret = ctrl->reg_write(ctrl, reg, value);
679 }
680
681 if (pcfg->hstart != SWR_INVALID_PARAM
682 && pcfg->hstop != SWR_INVALID_PARAM) {
683 reg = SWRM_DP_PORT_HCTRL_BANK(params->port_num, bank);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503591 ("UNUSED_VALUE")
Fixes: 128eaf937adb ("soundwire: qcom: add support to missing transport params")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-31 21:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 21:57 Coverity: qcom_swrm_transport_params(): UNUSED_VALUE coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).