* Coverity: nf_log_syslog_init(): Control flow issues
@ 2021-03-31 21:59 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-03-31 21:59 UTC (permalink / raw)
To: Florian Westphal; +Cc: Pablo Neira Ayuso, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
8d02e7da87a0 ("netfilter: nf_log_bridge: merge with nf_log_syslog")
Coverity reported the following:
*** CID 1503586: Control flow issues (DEADCODE)
/net/netfilter/nf_log_syslog.c: 1047 in nf_log_syslog_init()
1041 ret = nf_log_register(NFPROTO_NETDEV, &nf_netdev_logger);
1042 if (ret < 0)
1043 goto err4;
1044
1045 nf_log_register(NFPROTO_BRIDGE, &nf_bridge_logger);
1046 if (ret < 0)
vvv CID 1503586: Control flow issues (DEADCODE)
vvv Execution cannot reach this statement: "goto err5;".
1047 goto err5;
1048
1049 return 0;
1050 err5:
1051 nf_log_unregister(&nf_netdev_logger);
1052 err4:
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503586 ("Control flow issues")
Fixes: 8d02e7da87a0 ("netfilter: nf_log_bridge: merge with nf_log_syslog")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-31 22:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 21:59 Coverity: nf_log_syslog_init(): Control flow issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).