Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues
@ 2021-03-31 21:58 coverity-bot
  2021-04-01 20:54 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: coverity-bot @ 2021-03-31 21:58 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Swapnil Jakhade, Vinod Koul, Gustavo A. R. Silva, linux-next

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")

Coverity reported the following:

*** CID 1503589:  Error handling issues  (CHECKED_RETURN)
/drivers/phy/cadence/phy-cadence-torrent.c: 1678 in cdns_torrent_derived_refclk_is_enabled()
1672
1673     static int cdns_torrent_derived_refclk_is_enabled(struct clk_hw *hw)
1674     {
1675     	struct cdns_torrent_derived_refclk *derived_refclk = to_cdns_torrent_derived_refclk(hw);
1676     	int val;
1677
vvv     CID 1503589:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "regmap_field_read" without checking return value (as is done elsewhere 101 out of 117 times).
1678     	regmap_field_read(derived_refclk->phy_pipe_cmn_ctrl1_0, &val);
1679
1680     	return !!val;
1681     }
1682
1683     static const struct clk_ops cdns_torrent_derived_refclk_ops = {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503589 ("Error handling issues")
Fixes: 2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")

Thanks for your attention!

-- 
Coverity-bot

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues
  2021-03-31 21:58 Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues coverity-bot
@ 2021-04-01 20:54 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2021-04-01 20:54 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Swapnil Jakhade, Vinod Koul, Gustavo A. R. Silva, linux-next

On Wed, Mar 31, 2021 at 02:58:33PM -0700, coverity-bot wrote:
> Hello!
> 
> This is an experimental semi-automated report about issues detected by
> Coverity from a scan of next-20210331 as part of the linux-next scan project:
> https://scan.coverity.com/projects/linux-next-weekly-scan
> 
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by commits:
> 
>   None
>     2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")
> 
> Coverity reported the following:
> 
> *** CID 1503589:  Error handling issues  (CHECKED_RETURN)
> /drivers/phy/cadence/phy-cadence-torrent.c: 1678 in cdns_torrent_derived_refclk_is_enabled()
> 1672
> 1673     static int cdns_torrent_derived_refclk_is_enabled(struct clk_hw *hw)
> 1674     {
> 1675     	struct cdns_torrent_derived_refclk *derived_refclk = to_cdns_torrent_derived_refclk(hw);
> 1676     	int val;
> 1677
> vvv     CID 1503589:  Error handling issues  (CHECKED_RETURN)
> vvv     Calling "regmap_field_read" without checking return value (as is done elsewhere 101 out of 117 times).
> 1678     	regmap_field_read(derived_refclk->phy_pipe_cmn_ctrl1_0, &val);
> 1679
> 1680     	return !!val;
> 1681     }
> 1682
> 1683     static const struct clk_ops cdns_torrent_derived_refclk_ops = {

This happens in /drivers/phy/cadence/phy-cadence-sierra.c: 442 in cdns_sierra_pll_mux_get_parent()
too.

-Kees

> 
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
> 
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1503589 ("Error handling issues")
> Fixes: 2cca0228f364 ("phy: cadence-torrent: Add support to drive refclk out")
> 
> Thanks for your attention!
> 
> -- 
> Coverity-bot

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 21:58 Coverity: cdns_torrent_derived_refclk_is_enabled(): Error handling issues coverity-bot
2021-04-01 20:54 ` Kees Cook

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git