* Coverity: ax88772_init_phy(): Control flow issues
@ 2021-06-08 17:48 coverity-bot
0 siblings, 0 replies; only message in thread
From: coverity-bot @ 2021-06-08 17:48 UTC (permalink / raw)
To: Oleksij Rempel
Cc: David S. Miller, Oleksij Rempel, Gustavo A. R. Silva, linux-next
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210608 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Mon Jun 7 13:23:02 2021 -0700
e532a096be0e ("net: usb: asix: ax88772: add phylib support")
Coverity reported the following:
*** CID 1505172: Control flow issues (NO_EFFECT)
/drivers/net/usb/asix_devices.c: 708 in ax88772_init_phy()
702 static int ax88772_init_phy(struct usbnet *dev)
703 {
704 struct asix_common_private *priv = dev->driver_priv;
705 int ret;
706
707 priv->phy_addr = asix_read_phy_addr(dev, true);
vvv CID 1505172: Control flow issues (NO_EFFECT)
vvv This less-than-zero comparison of an unsigned value is never true. "priv->phy_addr < 0".
708 if (priv->phy_addr < 0)
709 return priv->phy_addr;
710
711 snprintf(priv->phy_name, sizeof(priv->phy_name), PHY_ID_FMT,
712 priv->mdio->id, priv->phy_addr);
713
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1505172 ("Control flow issues")
Fixes: e532a096be0e ("net: usb: asix: ax88772: add phylib support")
Thanks for your attention!
--
Coverity-bot
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-08 17:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 17:48 Coverity: ax88772_init_phy(): Control flow issues coverity-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).