linux-next: build warning after merge of the ext4 tree

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

Hi all,

After merging the ext4 tree, today's linux-next build (KCONFIG_NAME)
produced this warning:

fs/ext4/mmp.c: In function 'kmmpd':
fs/ext4/mmp.c:247:1: warning: label 'exit_thread' defined but not used [-Wunused-label]
  247 | exit_thread:
      | ^~~~~~~~~~~

Introduced by commit

  abc8250d1f1e ("ext4: possible use-after-free when remounting r/o a mmp-protected file system")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]

Hi all,

On Fri, 20 May 2022 11:03:13 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> 
> After merging the ext4 tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/ext4/super.c: In function 'ext4_check_test_dummy_encryption':
> fs/ext4/super.c:2677:36: warning: unused variable 'sbi' [-Wunused-variable]
>  2677 |         const struct ext4_sb_info *sbi = EXT4_SB(sb);
>       |                                    ^~~
> 
> Introduced by commit
> 
>   0df27ddf69f3 ("ext4: only allow test_dummy_encryption when supported")

This becomes an error in an i386 defconfig build, so I have applied the
following hack for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 20 May 2022 22:48:55 +1000
Subject: [PATCH] hack fixup for "ext4: only allow test_dummy_encryption when supported"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/ext4/super.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 5168d894c41e..f9a3ad683b4a 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2674,7 +2674,6 @@ static int ext4_check_test_dummy_encryption(const struct fs_context *fc,
 					    struct super_block *sb)
 {
 	const struct ext4_fs_context *ctx = fc->fs_private;
-	const struct ext4_sb_info *sbi = EXT4_SB(sb);
 
 	if (!IS_ENABLED(CONFIG_FS_ENCRYPTION) ||
 	    !(ctx->spec & EXT4_SPEC_DUMMY_ENCRYPTION))
@@ -2692,7 +2691,7 @@ static int ext4_check_test_dummy_encryption(const struct fs_context *fc,
 	 * it to be specified during remount, but only if there is no change.
 	 */
 	if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE &&
-	    !DUMMY_ENCRYPTION_ENABLED(sbi)) {
+	    !DUMMY_ENCRYPTION_ENABLED(EXT4_SB(sb))) {
 		ext4_msg(NULL, KERN_WARNING,
 			 "Can't set test_dummy_encryption on remount");
 		return -EINVAL;
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the ext4 tree

[Eric Biggers]

On Fri, May 20, 2022 at 11:03:13AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ext4 tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/ext4/super.c: In function 'ext4_check_test_dummy_encryption':
> fs/ext4/super.c:2677:36: warning: unused variable 'sbi' [-Wunused-variable]
>  2677 |         const struct ext4_sb_info *sbi = EXT4_SB(sb);
>       |                                    ^~~
> 
> Introduced by commit
> 
>   0df27ddf69f3 ("ext4: only allow test_dummy_encryption when supported")
> 

The kernel test robot beat you to it!  This warning happens when
!CONFIG_FS_ENCRYPTION.  v4 of the patch fixes this
(https://lore.kernel.org/r/20220519204437.61645-1-ebiggers@kernel.org).

- Eric

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi all,

After merging the ext4 tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/ext4/super.c: In function 'ext4_check_test_dummy_encryption':
fs/ext4/super.c:2677:36: warning: unused variable 'sbi' [-Wunused-variable]
 2677 |         const struct ext4_sb_info *sbi = EXT4_SB(sb);
      |                                    ^~~

Introduced by commit

  0df27ddf69f3 ("ext4: only allow test_dummy_encryption when supported")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

Hi Theodore,

After merging the ext4 tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

fs/ext4/super.c: In function 'parse_options':
fs/ext4/super.c:1976:26: warning: unused variable 'grp_qf_name' [-Wunused-variable]
  char *p, *usr_qf_name, *grp_qf_name;
                          ^~~~~~~~~~~
fs/ext4/super.c:1976:12: warning: unused variable 'usr_qf_name' [-Wunused-variable]
  char *p, *usr_qf_name, *grp_qf_name;
            ^~~~~~~~~~~

Introduced by commit

  20cefcdc2040 ("ext4: fix use-after-free race in ext4_remount()'s error path")

# CONFIG_QUOTA is not set

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

Hi Ted,

After merging the ext4 tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/ext4/ioctl.c: In function 'ext4_ioctl_setproject':
fs/ext4/ioctl.c:426:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^

Introduced by commit

  e14c6dbc6429 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support")

CONFIG_QUOTA is not set for this build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi Ted,

After merging the ext4 tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/ext4/resize.c: In function 'add_new_gdb':
fs/ext4/resize.c:506: warning: label 'exit_primary' defined but not used

Introduced by commit d7faaebaaad6fb5e1fd0b133102817ded5cdec61 ("ext4: add
error checking to calls to ext4_handle_dirty_metadata()").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the ext4 tree

[Ted Ts'o]

On Sat, Aug 07, 2010 at 12:45:15PM +1000, Stephen Rothwell wrote:
> Hi Ted,
> 
> After merging the ext4 tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/jbd2/transaction.c: In function 'start_this_handle':
> fs/jbd2/transaction.c:98: warning: unused variable 'ts'
> 
> Introduced by commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 ("jbd2:
> Remove t_handle_lock from start_this_handle()") which modev the only uses
> of this variable inside a section of code protected by CONFIG_JBD2_DEBUG.

Thanks for pointing this out.  I'll fix this up in the future (at the
moment I'm waiting for Linus to take a pull).

       	   	       	     	       - Ted

linux-next: build warning after merge of the ext4 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Ted,

After merging the ext4 tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/jbd2/transaction.c: In function 'start_this_handle':
fs/jbd2/transaction.c:98: warning: unused variable 'ts'

Introduced by commit 8dd420466c7bfc459fa04680bd5690bfc41a4553 ("jbd2:
Remove t_handle_lock from start_this_handle()") which modev the only uses
of this variable inside a section of code protected by CONFIG_JBD2_DEBUG.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]