linux-next: Signed-off-by missing for commits in the v4l-dvb tree

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

Hi all,

Commits

  a466530b3a1e ("watchdog/sb_watchdog: fix compilation problem due to COMPILE_TEST")
  135291f36d22 ("vboxfs: fix broken legacy mount signature checking")
  601e6baaa21c ("HID: amd_sfh: Fix potential NULL pointer dereference")
  38245d0340ea ("HID: u2fzero: ignore incomplete packets without data")
  ef1135704651 ("HID: amd_sfh: Fix potential NULL pointer dereference")
  94f9c3567eba ("HID: wacom: Add new Intuos BT (CTL-4100WL/CTL-6100WL) device IDs")
  125aaf6ec2fa ("HID: apple: Fix logical maximum and usage maximum of Magic Keyboard JIS")
  689e453a9b9c ("HID: betop: fix slab-out-of-bounds Write in betop_probe")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Mauro Carvalho Chehab]

Em Tue, 1 Sep 2020 12:52:16 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:

> Hi Julia,
> 
> Em Tue, 1 Sep 2020 12:05:51 +0200 (CEST)
> Julia Lawall <julia.lawall@inria.fr> escreveu:
> 
> > On Tue, 1 Sep 2020, Stephen Rothwell wrote:
> > 
> > > Hi all,
> > >
> > > Commits
> > >
> > >   063a27cb9820 ("media: tm6000: drop unnecessary list_empty")
> > >   1c047c859965 ("media: saa7134: drop unnecessary list_empty")
> > >   3fdcea7c763a ("media: cx231xx: drop unnecessary list_empty")
> > >
> > > are missing a Signed-off-by from their author.  
> > 
> > My record of these patches all have their Signed-off-bys.  Mauro, do you
> > want me to send them again?
> 
> No need. Yeah, I received them with your SoB, at least on my e-mail.
> 
> The one I applied came from this pull request:
> 
> 	https://patchwork.linuxtv.org/project/linux-media/patch/87327e52-44cc-a2b8-c3fe-619bd6022264@xs4all.nl/
> 
> Unfortunately, it sounds that Hans already dropped the original tag:
> 
> 	https://git.linuxtv.org/hverkuil/media_tree.git/refs/tags
> 
> So, hard to know where the SoB got dropped. It could be due to some
> bug on my scripts - or it can be due to some issue when Hans picked
> them.
> 
> In any case, I'll rewrite the git history with your SoB properly
> added.


Ok, I was able to find a backup of the patch I applied, as my scripts
safe a copy before applying.

One of the scripts I use has a logic to get just the header of a message,
excluding the diff:

	$ githead.pl 0019-0040-cx231xx-drop-unnecessary-list_empty.patch
	[media] cx231xx: drop unnecessary list_empty
	# Original subject: [PATCH 3/7] [media] cx231xx: drop unnecessary list_empty
	
	# Meta data:
	GIT_AUTHOR_DATE=1595761108
	GIT_AUTHOR_NAME=Julia Lawall
	GIT_AUTHOR_EMAIL=Julia.Lawall@inria.fr
	# X-Patchwork-Submitter: Julia Lawall <Julia.Lawall@inria.fr>
	# X-Patchwork-Id: 65835
	# X-IronPort-AV: E=Sophos;i="5.75,398,1589234400";    d="scan'208";a="355309545"
	# Cc: kernel-janitors@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org # Date: Sun, 26 Jul 2020 12:58:28 +0200
	# X-LSpam-Score: -2.4 (--)
	# X-LSpam-Report: No,  score=-2.4 required=5.0  tests=BAYES_00=-1.9,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1  autolearn=ham autolearn_force=no
	#
	list_for_each_entry is able to handle an empty list.
	The only effect of avoiding the loop is not initializing the
	index variable.
	Drop list_empty tests in cases where these variables are not
	used.
	
	Note that list_for_each_entry is defined in terms of list_first_entry,
	which indicates that it should not be used on an empty list.  But in
	list_for_each_entry, the element obtained by list_first_entry is not
	really accessed, only the address of its list_head field is compared
	to the address of the list head, so the list_first_entry is safe.
	
	The semantic patch that makes this change is as follows:
	(http://coccinelle.lip6.fr/)
	
	<smpl>
	@@
	expression x,e;
	iterator name list_for_each_entry;
	statement S;
	identifier i;
	@@
	
	-if (!(list_empty(x))) {
	   list_for_each_entry(i,x,...) S

Among other things, such script ignores everything after /^---\n/
regex.

Yet, the smpl patch hit some bug on it, making it lose this part:

	- }
	 ... when != i
	? i = e
	</smpl>
	
	Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
	Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Because it contains this regex: /^-\s/

Making it think that this would have some mangled patch on it.

That part came from the old days where we used CVS (and later
mercurial) and some diffs were not strictly following the
pattern generated by git those days.

I changed my script to avoid this issue to happen again.

Thanks,
Mauro

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Mauro Carvalho Chehab]

Hi Julia,

Em Tue, 1 Sep 2020 12:05:51 +0200 (CEST)
Julia Lawall <julia.lawall@inria.fr> escreveu:

> On Tue, 1 Sep 2020, Stephen Rothwell wrote:
> 
> > Hi all,
> >
> > Commits
> >
> >   063a27cb9820 ("media: tm6000: drop unnecessary list_empty")
> >   1c047c859965 ("media: saa7134: drop unnecessary list_empty")
> >   3fdcea7c763a ("media: cx231xx: drop unnecessary list_empty")
> >
> > are missing a Signed-off-by from their author.  
> 
> My record of these patches all have their Signed-off-bys.  Mauro, do you
> want me to send them again?

No need. Yeah, I received them with your SoB, at least on my e-mail.

The one I applied came from this pull request:

	https://patchwork.linuxtv.org/project/linux-media/patch/87327e52-44cc-a2b8-c3fe-619bd6022264@xs4all.nl/

Unfortunately, it sounds that Hans already dropped the original tag:

	https://git.linuxtv.org/hverkuil/media_tree.git/refs/tags

So, hard to know where the SoB got dropped. It could be due to some
bug on my scripts - or it can be due to some issue when Hans picked
them.

In any case, I'll rewrite the git history with your SoB properly
added.

Thanks,
Mauro

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Julia Lawall]

On Tue, 1 Sep 2020, Stephen Rothwell wrote:

> Hi all,
>
> Commits
>
>   063a27cb9820 ("media: tm6000: drop unnecessary list_empty")
>   1c047c859965 ("media: saa7134: drop unnecessary list_empty")
>   3fdcea7c763a ("media: cx231xx: drop unnecessary list_empty")
>
> are missing a Signed-off-by from their author.

My record of these patches all have their Signed-off-bys.  Mauro, do you
want me to send them again?

thanks,
julia

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

Hi all,

Commits

  063a27cb9820 ("media: tm6000: drop unnecessary list_empty")
  1c047c859965 ("media: saa7134: drop unnecessary list_empty")
  3fdcea7c763a ("media: cx231xx: drop unnecessary list_empty")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Mauro Carvalho Chehab]

Em Thu, 23 May 2019 17:10:05 +0300
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:

> Hi Stephen, Mauro,
> 
> On Fri, May 24, 2019 at 12:05:00AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Commits
> > 
> >   eeabf6320e2f ("media: Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability"")
> >   bbf83ed40252c ("media: ov8856: modify register to fix test pattern")
> > 
> > are missing a Signed-off-by from their authors.  
> 
> Ouch.
> 
> Mauro, what do you prefer, reset the tree or what?

I'll drop bbf83ed40252c and the marvel-ccic patches after eeabf6320e2f,
rebasing my tree.

> 
> Shawn, Lubomir: please read "Developer's Certificate of Origin 1.1" in
> Documentation/process/submitting-patches.rst and then resend with
> appropriate SoB lines.
> 



Thanks,
Mauro

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Sakari Ailus]

Hi Stephen, Mauro,

On Fri, May 24, 2019 at 12:05:00AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Commits
> 
>   eeabf6320e2f ("media: Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability"")
>   bbf83ed40252c ("media: ov8856: modify register to fix test pattern")
> 
> are missing a Signed-off-by from their authors.

Ouch.

Mauro, what do you prefer, reset the tree or what?

Shawn, Lubomir: please read "Developer's Certificate of Origin 1.1" in
Documentation/process/submitting-patches.rst and then resend with
appropriate SoB lines.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi all,

Commits

  eeabf6320e2f ("media: Revert "[media] marvell-ccic: reset ccic phy when stop streaming for stability"")
  bbf83ed40252c ("media: ov8856: modify register to fix test pattern")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Mauro Carvalho Chehab]

Em Thu, 17 May 2018 10:17:20 +0300
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:

> On Thu, May 17, 2018 at 07:37:02AM +1000, Stephen Rothwell wrote:
> > Hi Mauro,
> > 
> > Commit
> > 
> >   af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")
> > 
> > is missing a Signed-off-by from its committer.  
> 
> Mauro's SoB line is indeed missing. I wonder what happened.
> 
> > 
> > Commits
> > 
> >   c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
> >   3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
> >   2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")
> > 
> > are missing a Signed-off-by from their author.  
> 
> Thanks for pointing this out. We'll be more careful going forward.

In this specific case, we're adding two drivers without their
author's SOBs. I'll roll-back my tree to a sane state (and, while
there, add my SOB at the missing commit).

Sakari,

You'll need to resubmit those patches (and the dependent ones) once
you get the author's SOBs.

Thanks,
Mauro

Re: linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Sakari Ailus]

On Thu, May 17, 2018 at 07:37:02AM +1000, Stephen Rothwell wrote:
> Hi Mauro,
> 
> Commit
> 
>   af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")
> 
> is missing a Signed-off-by from its committer.

Mauro's SoB line is indeed missing. I wonder what happened.

> 
> Commits
> 
>   c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
>   3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
>   2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")
> 
> are missing a Signed-off-by from their author.

Thanks for pointing this out. We'll be more careful going forward.

-- 
Regards,

Sakari Ailus
sakari.ailus@linux.intel.com

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

Hi Mauro,

Commit

  af76c93aa36d ("media: cadence: csi2rx: Fix csi2rx_start error handling")

is missing a Signed-off-by from its committer.

Commits

  c578c7710712 ("media: imx258: Add imx258 camera sensor driver")
  3a8fdc1426c3 ("media: dw9807: Add dw9807 vcm driver")
  2f9c1c88369f ("media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil")

are missing a Signed-off-by from their author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

Hi Mauro,

Commits

  eab638a8ae6e ("media: Staging: media: atomisp: pci: Eliminate use of typedefs for struct")
  309167b966b6 ("media: staging: atomisp: cleanup out of memory messages")

are missing a Signed-off-by from their authors.

-- 
Cheers,
Stephen Rothwell

linux-next: Signed-off-by missing for commits in the v4l-dvb tree

[Stephen Rothwell]

Hi Mauro,

Commits

  9722e5696ca7 ("media: dvb-frontends: delete jump targets")
  af28c99628eb ("media: drivers: Adjust checks for null pointers")
  2d3da59ff163 ("media: drivers: improve a size determination")
  d303b7c5b266 ("media: drivers: delete unnecessary variable initialisations")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell