linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the akpm tree with the random tree
@ 2022-01-17  1:07 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2022-01-17  1:07 UTC (permalink / raw)
  To: Andrew Morton, Theodore Ts'o, Jason A. Donenfeld
  Cc: Linux Kernel Mailing List, Linux Next Mailing List,
	Luis Chamberlain, Xiaoming Ni

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

Hi all,

Today's linux-next merge of the akpm tree got a conflict in:

  drivers/char/random.c

between commit:

  f90d704ab3cd ("random: de-duplicate INPUT_POOL constants")

from the random tree and patch:

  "random: move the random sysctl declarations to its own file"

from the akpm-current tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/char/random.c
index 7e9caf092cd8,d7c034ea59bf..000000000000
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@@ -2013,9 -2087,8 +2013,8 @@@ static int proc_do_entropy(struct ctl_t
  	return proc_dointvec(&fake_table, write, buffer, lenp, ppos);
  }
  
 -static int sysctl_poolsize = INPUT_POOL_WORDS * 32;
 +static int sysctl_poolsize = POOL_BITS;
- extern struct ctl_table random_table[];
- struct ctl_table random_table[] = {
+ static struct ctl_table random_table[] = {
  	{
  		.procname	= "poolsize",
  		.data		= &sysctl_poolsize,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* linux-next: manual merge of the akpm tree with the random tree
@ 2022-01-18  1:52 Stephen Rothwell
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Rothwell @ 2022-01-18  1:52 UTC (permalink / raw)
  To: Andrew Morton, Theodore Ts'o, Jason A. Donenfeld
  Cc: Linux Kernel Mailing List, Linux Next Mailing List,
	Luis Chamberlain, Xiaoming Ni

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

Hi all,

Today's linux-next merge of the akpm tree got a conflict in:

  drivers/char/random.c

between commit:

  b48e412a0b73 ("random: selectively clang-format where it makes sense")

from the random tree and patch:

  "random: move the random sysctl declarations to its own file"

from the akpm tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/char/random.c
index b04664fa61a2,2ce43609dbc8..000000000000
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@@ -2055,7 -2076,18 +2054,18 @@@ static struct ctl_table random_table[] 
  #endif
  	{ }
  };
+ 
+ /*
+  * rand_initialize() is called before sysctl_init(),
+  * so we cannot call register_sysctl_init() in rand_initialize()
+  */
+ static int __init random_sysctls_init(void)
+ {
+ 	register_sysctl_init("kernel/random", random_table);
+ 	return 0;
+ }
+ device_initcall(random_sysctls_init);
 -#endif 	/* CONFIG_SYSCTL */
 +#endif	/* CONFIG_SYSCTL */
  
  struct batched_entropy {
  	union {

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-01-18  1:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-17  1:07 linux-next: manual merge of the akpm tree with the random tree Stephen Rothwell
2022-01-18  1:52 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).