linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Bo Liu <liubo03@inspur.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the vhost tree
Date: Wed, 1 Jun 2022 17:57:12 -0400	[thread overview]
Message-ID: <20220601060641-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220601114240.1dafefc6@canb.auug.org.au>

On Wed, Jun 01, 2022 at 11:42:40AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the vhost tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/virtio/virtio_ring.c: In function 'virtqueue_add':
> drivers/virtio/virtio_ring.c:1783:16: error: 'vq' undeclared (first use in this function); did you mean '_vq'?
>  1783 |         return vq->packed_ring ? virtqueue_add_packed(_vq, sgs, total_sg,
>       |                ^~
>       |                _vq
> drivers/virtio/virtio_ring.c:1783:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/virtio/virtio_ring.c:1787:1: error: control reaches end of non-void function [-Werror=return-type]
>  1787 | }
>       | ^
> 
> Caused by commit
> 
>   a50f09346a34 ("virtio_ring: remove unused variable in virtqueue_add()")
> 
> I am sorry, but I expect better review and build testing than this :-(
> 
> I have used the vhost tree from next-20220531 for today.

Indeed, pushed a wrong tree :( 
I hope I pushed the correct one now, pls let me know whether this is now fixed.
Thanks!

-- 
MST


  reply	other threads:[~2022-06-01 21:57 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  1:42 linux-next: build failure after merge of the vhost tree Stephen Rothwell
2022-06-01 21:57 ` Michael S. Tsirkin [this message]
2022-06-02  3:19   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2024-02-29  3:55 Stephen Rothwell
2024-02-29  4:01 ` Xuan Zhuo
2024-02-29  7:21   ` Xuan Zhuo
2022-08-16  1:13 Stephen Rothwell
2021-11-25  1:23 Stephen Rothwell
2021-09-06  2:49 Stephen Rothwell
2021-09-06  2:57 ` Yongji Xie
2021-07-08  1:08 Stephen Rothwell
2021-07-08  5:37 ` Michael S. Tsirkin
2020-08-04  5:11 Stephen Rothwell
2020-08-04  5:47 ` Guennadi Liakhovetski
2020-08-04  7:04   ` Guennadi Liakhovetski
2020-08-04  9:15     ` Michael S. Tsirkin
2020-07-30  7:52 Stephen Rothwell
2020-07-28  8:11 Stephen Rothwell
2020-07-29 14:08 ` Michael S. Tsirkin
2020-05-07  5:36 Stephen Rothwell
2020-04-07  3:05 Stephen Rothwell
2020-04-07 10:01 ` Michael S. Tsirkin
2020-04-07 18:58 ` Nathan Chancellor
2020-04-09 21:15   ` Michael S. Tsirkin
2019-12-04  3:24 Stephen Rothwell
2019-12-07 23:45 ` Stephen Rothwell
2019-12-09 15:24 ` Michael S. Tsirkin
2018-02-07  2:04 Stephen Rothwell
2018-02-07  2:52 ` Michael S. Tsirkin
2018-02-07  2:54 ` Stephen Rothwell
2018-02-07  2:57   ` Michael S. Tsirkin
2018-02-07  4:30     ` Stephen Rothwell
2017-03-30  4:25 Stephen Rothwell
2017-04-03  6:21 ` Stephen Rothwell
2014-06-10  4:12 Stephen Rothwell
2014-06-10  9:38 ` Michael S. Tsirkin
2014-06-03  8:38 Stephen Rothwell
2014-06-09 13:19 ` Michael S. Tsirkin
2013-05-22  4:37 Stephen Rothwell
2013-05-22  5:07 ` Michael S. Tsirkin
2013-05-22  9:03 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601060641-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=liubo03@inspur.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).