linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yongji Xie <xieyongji@bytedance.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the vhost tree
Date: Mon, 6 Sep 2021 10:57:14 +0800	[thread overview]
Message-ID: <CACycT3u6aOwgPhcKUhnDOL5JxkBt3=k69hHPUASZSr3iU8GXVw@mail.gmail.com> (raw)
In-Reply-To: <20210906124954.55ece6e8@canb.auug.org.au>

On Mon, Sep 6, 2021 at 10:50 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the vhost tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/vdpa/vdpa_user/vduse_dev.c: In function 'vduse_vdpa_kick_vq':
> drivers/vdpa/vdpa_user/vduse_dev.c:489:6: error: implicit declaration of function 'eventfd_signal_count'; did you mean 'eventfd_signal_allowed'? [-Werror=implicit-function-declaration]
>   489 |  if (eventfd_signal_count()) {
>       |      ^~~~~~~~~~~~~~~~~~~~
>       |      eventfd_signal_allowed
>
> Caused by commit
>
>   b66219796563 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
>
> interacting with commit
>
>   b542e383d8c0 ("eventfd: Make signal recursion protection a task bit")
>
> from Linus' tree.
>
> I have applied the following merge fix patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 6 Sep 2021 12:43:32 +1000
> Subject: [PATCH] fix up for "eventfd: Make signal recursion protection a task bit"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/vdpa/vdpa_user/vduse_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
> index 59a93e5b967a..5c25ff6483ad 100644
> --- a/drivers/vdpa/vdpa_user/vduse_dev.c
> +++ b/drivers/vdpa/vdpa_user/vduse_dev.c
> @@ -486,7 +486,7 @@ static void vduse_vdpa_kick_vq(struct vdpa_device *vdpa, u16 idx)
>         struct vduse_dev *dev = vdpa_to_vduse(vdpa);
>         struct vduse_virtqueue *vq = &dev->vqs[idx];
>
> -       if (eventfd_signal_count()) {
> +       if (eventfd_signal_allowed()) {
>                 schedule_work(&vq->kick);
>                 return;
>         }
> --

LGTM! Thank you for the fix!

Thanks,
Yongji

  reply	other threads:[~2021-09-06  2:57 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  2:49 linux-next: build failure after merge of the vhost tree Stephen Rothwell
2021-09-06  2:57 ` Yongji Xie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-29  3:55 Stephen Rothwell
2024-02-29  4:01 ` Xuan Zhuo
2024-02-29  7:21   ` Xuan Zhuo
2022-08-16  1:13 Stephen Rothwell
2022-06-01  1:42 Stephen Rothwell
2022-06-01 21:57 ` Michael S. Tsirkin
2022-06-02  3:19   ` Stephen Rothwell
2021-11-25  1:23 Stephen Rothwell
2021-07-08  1:08 Stephen Rothwell
2021-07-08  5:37 ` Michael S. Tsirkin
2020-08-04  5:11 Stephen Rothwell
2020-08-04  5:47 ` Guennadi Liakhovetski
2020-08-04  7:04   ` Guennadi Liakhovetski
2020-08-04  9:15     ` Michael S. Tsirkin
2020-07-30  7:52 Stephen Rothwell
2020-07-28  8:11 Stephen Rothwell
2020-07-29 14:08 ` Michael S. Tsirkin
2020-05-07  5:36 Stephen Rothwell
2020-04-07  3:05 Stephen Rothwell
2020-04-07 10:01 ` Michael S. Tsirkin
2020-04-07 18:58 ` Nathan Chancellor
2020-04-09 21:15   ` Michael S. Tsirkin
2019-12-04  3:24 Stephen Rothwell
2019-12-07 23:45 ` Stephen Rothwell
2019-12-09 15:24 ` Michael S. Tsirkin
2018-02-07  2:04 Stephen Rothwell
2018-02-07  2:52 ` Michael S. Tsirkin
2018-02-07  2:54 ` Stephen Rothwell
2018-02-07  2:57   ` Michael S. Tsirkin
2018-02-07  4:30     ` Stephen Rothwell
2017-03-30  4:25 Stephen Rothwell
2017-04-03  6:21 ` Stephen Rothwell
2014-06-10  4:12 Stephen Rothwell
2014-06-10  9:38 ` Michael S. Tsirkin
2014-06-03  8:38 Stephen Rothwell
2014-06-09 13:19 ` Michael S. Tsirkin
2013-05-22  4:37 Stephen Rothwell
2013-05-22  5:07 ` Michael S. Tsirkin
2013-05-22  9:03 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACycT3u6aOwgPhcKUhnDOL5JxkBt3=k69hHPUASZSr3iU8GXVw@mail.gmail.com' \
    --to=xieyongji@bytedance.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).