linux-next: build warning after merge of the pidfd tree

linux-next: build warning after merge of the pidfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi all,

After merging the pidfd tree, today's linux-next build (htmldocs)
produced this warning:

fs/attr.c:35: warning: Excess function parameter 'uid' description in 'chown_ok'
fs/attr.c:62: warning: Excess function parameter 'gid' description in 'chgrp_ok'

Introduced by commit

  fc643cb39fc6 ("attr: port attribute changes to new types")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the pidfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

Hi all,

After merging the pidfd tree, today's linux-next build (htmldocs)
produced this warning:

include/linux/fs.h:1714: warning: expecting prototype for i_gid_into_mnt(). Prototype was for i_gid_into_vfsgid() instead`

Introduced by commit

  526b0b1c14c4 ("fs: add two type safe mapping helpers")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the pidfd tree

[Christoph Hellwig]

On Wed, Jan 27, 2021 at 09:41:01AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pidfd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/xfs/xfs_ioctl32.c: In function 'xfs_file_compat_ioctl':
> fs/xfs/xfs_ioctl32.c:441:20: warning: unused variable 'mp' [-Wunused-variable]
>   441 |  struct xfs_mount *mp = ip->i_mount;
>       |                    ^~

So this is only used in an x86-specific section of the function.
Let me think what we can do about this.

linux-next: build warning after merge of the pidfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi all,

After merging the pidfd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/xfs/xfs_ioctl32.c: In function 'xfs_file_compat_ioctl':
fs/xfs/xfs_ioctl32.c:441:20: warning: unused variable 'mp' [-Wunused-variable]
  441 |  struct xfs_mount *mp = ip->i_mount;
      |                    ^~

Introduced by commit

  f736d93d76d3 ("xfs: support idmapped mounts")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the pidfd tree

[Christian Brauner]

On Fri, Jul 10, 2020 at 04:32:04PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pidfd tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> fs/nsfs.c: In function 'ns_ioctl':
> fs/nsfs.c:195:14: warning: unused variable 'pid_struct' [-Wunused-variable]
>   195 |  struct pid *pid_struct;
>       |              ^~~~~~~~~~
> fs/nsfs.c:194:22: warning: unused variable 'child_reaper' [-Wunused-variable]
>   194 |  struct task_struct *child_reaper;
>       |                      ^~~~~~~~~~~~
> 
> Introduced by commit
> 
>   a57927d2dce2 ("nsfs: add NS_GET_INIT_PID ioctl")

Hm, I wonder how that didn't get caught during a git rebase -x "make" v5.8-rc4 build...
Sorry about that!

Thanks!
Christian

linux-next: build warning after merge of the pidfd tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Hi all,

After merging the pidfd tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

fs/nsfs.c: In function 'ns_ioctl':
fs/nsfs.c:195:14: warning: unused variable 'pid_struct' [-Wunused-variable]
  195 |  struct pid *pid_struct;
      |              ^~~~~~~~~~
fs/nsfs.c:194:22: warning: unused variable 'child_reaper' [-Wunused-variable]
  194 |  struct task_struct *child_reaper;
      |                      ^~~~~~~~~~~~

Introduced by commit

  a57927d2dce2 ("nsfs: add NS_GET_INIT_PID ioctl")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]