linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the mfd tree with the i2c tree
@ 2022-08-17  1:08 Stephen Rothwell
  2022-08-17  4:48 ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2022-08-17  1:08 UTC (permalink / raw)
  To: Lee Jones, Wolfram Sang
  Cc: Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List, Uwe Kleine-König

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

Hi all,

Today's linux-next merge of the mfd tree got a conflict in:

  drivers/mfd/intel_soc_pmic_core.c

between commit:

  ed5c2f5fd10d ("i2c: Make remove callback return void")

from the i2c tree and commit:

  8a8cf3dc6419 ("mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc")

from the mfd tree.

I fixed it up (I removed the file and added the following merge fix patch)
and can carry the fix as necessary. This is now fixed as far as linux-next
is concerned, but any non trivial conflicts should be mentioned to your
upstream maintainer when your tree is submitted for merging.  You may
also want to consider cooperating with the maintainer of the conflicting
tree to minimise any particularly complex conflicts.

From 9c5f9919c71c84b77d607e6a27b65c1c37462a3f Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 17 Aug 2022 10:12:19 +1000
Subject: [PATCH] mfd: fix up for "i2c: Make remove callback return void"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/mfd/intel_soc_pmic_crc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
index 40f14a0c0790..b1548a933dc3 100644
--- a/drivers/mfd/intel_soc_pmic_crc.c
+++ b/drivers/mfd/intel_soc_pmic_crc.c
@@ -214,14 +214,12 @@ static int crystal_cove_i2c_probe(struct i2c_client *i2c)
 	return ret;
 }
 
-static int crystal_cove_i2c_remove(struct i2c_client *i2c)
+static void crystal_cove_i2c_remove(struct i2c_client *i2c)
 {
 	/* remove crc-pwm lookup table */
 	pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup));
 
 	mfd_remove_devices(&i2c->dev);
-
-	return 0;
 }
 
 static void crystal_cove_shutdown(struct i2c_client *i2c)
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the mfd tree with the i2c tree
  2022-08-17  1:08 linux-next: manual merge of the mfd tree with the i2c tree Stephen Rothwell
@ 2022-08-17  4:48 ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2022-08-17  4:48 UTC (permalink / raw)
  To: Lee Jones, Stephen Rothwell
  Cc: Wolfram Sang, Andy Shevchenko, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]

On Wed, Aug 17, 2022 at 11:08:45AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the mfd tree got a conflict in:
> 
>   drivers/mfd/intel_soc_pmic_core.c
> 
> between commit:
> 
>   ed5c2f5fd10d ("i2c: Make remove callback return void")
> 
> from the i2c tree and commit:
> 
>   8a8cf3dc6419 ("mfd: intel_soc_pmic_crc: Merge Intel PMIC core to crc")
> 
> from the mfd tree.
> 
> I fixed it up (I removed the file and added the following merge fix patch)
> and can carry the fix as necessary. This is now fixed as far as linux-next
> is concerned, but any non trivial conflicts should be mentioned to your
> upstream maintainer when your tree is submitted for merging.  You may
> also want to consider cooperating with the maintainer of the conflicting
> tree to minimise any particularly complex conflicts.

The fixup looks right.

@Lee: There is an immutable tag that can be merged into your tree to
resolve the conflict before you send your changes to Linux at

	https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable

@Stephen: Thanks for your fixes, here and in the input tree.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the mfd tree with the i2c tree
  2010-03-03  3:47 Stephen Rothwell
@ 2010-03-03  9:16 ` Jean Delvare
  0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2010-03-03  9:16 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Samuel Ortiz, linux-next, linux-kernel, Márton Németh

Hi Stephen, Samuel,

On Wed, 3 Mar 2010 14:47:15 +1100, Stephen Rothwell wrote:
> Today's linux-next merge of the mfd tree got a conflict in
> drivers/i2c/busses/i2c-isch.c between commit
> 482b522a6ced62506aba1c139cb9d4b73e7312f5 ("i2c: Make PCI device ids
> constant") from the i2c tree and commit
> 1fc8fe094a8ebcc09817246277250898a8d2fc5a ("i2c: convert i2c-isch to
> platform_device") from the mfd tree.
> 
> The latter removes the code modified by the former, so I used the latter.

I have sent a pull request to Linus yesterday for my i2c tree, which
includes the first patch mentioned above. As soon as Linus pulls from
it, Samuel will have to adjust the second patch to make it apply again.

-- 
Jean Delvare

^ permalink raw reply	[flat|nested] 4+ messages in thread

* linux-next: manual merge of the mfd tree with the i2c tree
@ 2010-03-03  3:47 Stephen Rothwell
  2010-03-03  9:16 ` Jean Delvare
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2010-03-03  3:47 UTC (permalink / raw)
  To: Samuel Ortiz
  Cc: linux-next, linux-kernel, "Márton Németh",
	Jean Delvare

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

Hi Samuel,

Today's linux-next merge of the mfd tree got a conflict in
drivers/i2c/busses/i2c-isch.c between commit
482b522a6ced62506aba1c139cb9d4b73e7312f5 ("i2c: Make PCI device ids
constant") from the i2c tree and commit
1fc8fe094a8ebcc09817246277250898a8d2fc5a ("i2c: convert i2c-isch to
platform_device") from the mfd tree.

The latter removes the code modified by the former, so I used the latter.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-17  4:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17  1:08 linux-next: manual merge of the mfd tree with the i2c tree Stephen Rothwell
2022-08-17  4:48 ` Uwe Kleine-König
  -- strict thread matches above, loose matches on Subject: below --
2010-03-03  3:47 Stephen Rothwell
2010-03-03  9:16 ` Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).