linux-next: Fixes tag needs some work in the mm-stable tree

linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Hi all,

In commit

  831568214883 ("mm: migration: fix the FOLL_GET failure on following huge page")

Fixes tag

  Fixes: 4cd614841c06 ("mm: migration: fix possible do_pages_stat_array racing with memory offline")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the mm-stable tree

[Wang, Haiyue]

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Monday, September 12, 2022 13:46
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>;
> Linux Next Mailing List <linux-next@vger.kernel.org>
> Subject: linux-next: Fixes tag needs some work in the mm-stable tree
> 
> Hi all,
> 
> In commit
> 
>   831568214883 ("mm: migration: fix the FOLL_GET failure on following huge page")
> 
> Fixes tag
> 
>   Fixes: 4cd614841c06 ("mm: migration: fix possible do_pages_stat_array racing with memory offline")
> 

My fault.

It should be "mm/migration", NOT "mm: migration "

Fixes: 4cd614841c06 ("mm/migration: fix possible do_pages_stat_array racing with memory offline")

Should I send new patch ?

> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: Fixes tag needs some work in the mm-stable tree

[Andrew Morton]

On Mon, 12 Sep 2022 13:05:37 +0000 "Wang, Haiyue" <haiyue.wang@intel.com> wrote:

> Should I send new patch ?

Nope.  I fix things like that.

But in this case I don't think I'll bother.  The world won't end.

Thanks, Stephen.

Re: linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hi Mike,

On Sun, 9 Oct 2022 18:40:15 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> For all of these, I was under the impression that the SHA1 of commits in
> Andrew's trees were not stable and could change.  That is why I purposely
> did not try to add SHA1s to the tags.  Perhaps that is no longer the case
> since Andrew is using git to manage patches?

I assume that once a commit is in the mm-stable branch of Andrew's tree
that the SHA1 will be fixed (except in exceptional circumstances).
Andrew?

> I see that a pull request including these commits was already sent to
> Linus.  Not sure where these are in the process, or if it may be too
> late to update.  Let me know if there is anything I can do.

Yeah, I saw that, and as you say, we must just have to live with these.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the mm-stable tree

[Mike Kravetz]

On 10/09/22 19:35, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
> 
> Fixes tag
> 
>   Fixes: "hugetlb: clean up code checking for fault/truncation races"
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Maybe you meant
> 
> Fixes: fa27759af4a6 ("hugetlb: clean up code checking for fault/truncation races")

For all of these, I was under the impression that the SHA1 of commits in
Andrew's trees were not stable and could change.  That is why I purposely
did not try to add SHA1s to the tags.  Perhaps that is no longer the case
since Andrew is using git to manage patches?

I see that a pull request including these commits was already sent to
Linus.  Not sure where these are in the process, or if it may be too
late to update.  Let me know if there is anything I can do.
-- 
Mike Kravetz

Re: linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi all,

On Sun, 9 Oct 2022 19:35:44 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> In commit
> 
>   bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")
> 
> Fixes tag
> 
>   Fixes: "hugetlb: clean up code checking for fault/truncation races"
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Maybe you meant
> 
> Fixes: fa27759af4a6 ("hugetlb: clean up code checking for fault/truncation races")

Sorry, I accidentally sent this twice.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

Hi all,

In commit

  131a79b474e9 ("hugetlb: fix vma lock handling during split vma and range unmapping")

Fixes tag

  Fixes: "hugetlb: add vma based lock for pmd sharing"

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 8d9bfb260814 ("hugetlb: add vma based lock for pmd sharing")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  ecfbd733878d ("hugetlb: take hugetlb vma_lock when clearing vma_lock->vma pointer")

Fixes tag

  Fixes: "hugetlb: use new vma_lock for pmd sharing synchronization"

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 40549ba8f8e0 ("hugetlb: use new vma_lock for pmd sharing synchronization")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

In commit

  bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")

Fixes tag

  Fixes: "hugetlb: clean up code checking for fault/truncation races"

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: fa27759af4a6 ("hugetlb: clean up code checking for fault/truncation races")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the mm-stable tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Hi all,

In commit

  bbff39cc6cbc ("hugetlb: allocate vma lock for all sharable vmas")

Fixes tag

  Fixes: "hugetlb: clean up code checking for fault/truncation races"

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: fa27759af4a6 ("hugetlb: clean up code checking for fault/truncation races")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]