linux-next: Fixes tag needs some work in the f2fs tree

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi all,

In commit

  6953bf65286d ("f2fs: allow to read node block after shutdown")

Fixes tag

  Fixes: 83a3bfdb5a8 ("f2fs: indicate shutdown f2fs to allow unmount successfully")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi all,

In commit

  4662849550f1 ("f2fs: fix the assign logic of iocb")

Fixes tag

  Fixes: 18ae8d12991b ("f2fs: show more DIO information in tracepoint")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: bd984c03097b ("f2fs: show more DIO information in tracepoint")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[Jaegeuk Kim]

On 10/04, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5b4e447a70d1 ("f2fs: fix to account FS_CP_DATA_IO correctly")
> 
> Fixes tag
> 
>   Fixes: commit 040d2bb318d1 ("f2fs: fix to avoid deadloop if data_flush is on")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected
> Fixes tag
> 
>   Fixes: commit 186857c5a14a ("f2fs: fix potential recursive call when enabling data_flush")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Fixed. Thanks.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi all,

In commit

  5b4e447a70d1 ("f2fs: fix to account FS_CP_DATA_IO correctly")

Fixes tag

  Fixes: commit 040d2bb318d1 ("f2fs: fix to avoid deadloop if data_flush is on")

has these problem(s):

  - leading word 'commit' unexpected
Fixes tag

  Fixes: commit 186857c5a14a ("f2fs: fix potential recursive call when enabling data_flush")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[Jaegeuk Kim]

On 04/14, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   4b6857882c90 ("f2fs: remove obsolete whint_mode")
> 
> Fixes tag
> 
>   Fixes: commit 41d36a9f3e53 ("fs: remove kiocb.ki_hint")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Thanks, fixed.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Hi all,

In commit

  4b6857882c90 ("f2fs: remove obsolete whint_mode")

Fixes tag

  Fixes: commit 41d36a9f3e53 ("fs: remove kiocb.ki_hint")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: Fixes tag needs some work in the f2fs tree

[常凤楠]

Hi Jaegeuk:
	[PATCH v5] f2fs: fix compressed file start atomic write may cause data corruption
	The new version had fix this ,please help to merge this.

Thanks.

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Friday, March 18, 2022 5:10 AM
> To: Jaegeuk Kim <jaegeuk@kernel.org>
> Cc: 常凤楠 <changfengnan@vivo.com>; Linux Kernel Mailing List
> <linux-kernel@vger.kernel.org>; Linux Next Mailing List
> <linux-next@vger.kernel.org>
> Subject: linux-next: Fixes tag needs some work in the f2fs tree
> 
> Hi all,
> 
> In commit
> 
>   3459538a3654 ("f2fs: fix compressed file start atomic write may cause data
> corruption")
> 
> Fixes tag
> 
>   Fixes: 7eab7a696827 ("f2fs: compress: remove unneeded read when
> rewrite whole
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

Hi all,

In commit

  3459538a3654 ("f2fs: fix compressed file start atomic write may cause data corruption")

Fixes tag

  Fixes: 7eab7a696827 ("f2fs: compress: remove unneeded read when rewrite whole

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[Jaegeuk Kim]

On 10/22, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   701179c15976 ("f2fs: include non-compressed blocks in compr_written_block")
> 
> Fixes tag
> 
>   Fixes: commit 5ac443e26a09 ("f2fs: add sysfs nodes to get runtime compression stat")
> 
> has these problem(s):
> 
>   - leading word 'commit' unexpected

Fixed. Thanks.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi all,

In commit

  701179c15976 ("f2fs: include non-compressed blocks in compr_written_block")

Fixes tag

  Fixes: commit 5ac443e26a09 ("f2fs: add sysfs nodes to get runtime compression stat")

has these problem(s):

  - leading word 'commit' unexpected

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[Jaegeuk Kim]

On 12/02, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   32c202c563c7 ("f2fs: init dirty_secmap incorrectly")
> 
> Fixes tag
> 
>   Fixes: da52f8ade40b ("f2fs: get the right gc victim section when section
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing parentheses
>   - Subject has leading but no trailing quotes
> 
> Please do not split Fixes tags over more than one line.

Oh, fixed the wrong commit message. :(

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  32c202c563c7 ("f2fs: init dirty_secmap incorrectly")

Fixes tag

  Fixes: da52f8ade40b ("f2fs: get the right gc victim section when section

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[jaegeuk]

Thanks,

I fixed it in f2fs-next branch.

Thanks,

On 10/15, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   e965857201e0 ("f2fs: wait for sysfs kobject removal before freeing f2fs_sb_info")
> 
> Fixes tag
> 
>   Fixes: bf9e697ecd4 ("f2fs: expose features to sysfs entry")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

Hi all,

In commit

  e965857201e0 ("f2fs: wait for sysfs kobject removal before freeing f2fs_sb_info")

Fixes tag

  Fixes: bf9e697ecd4 ("f2fs: expose features to sysfs entry")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the f2fs tree

[Jaegeuk Kim]

On 06/05, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   35942e2134fa ("f2fs: attach IO flags to the missing cases")
> 
> Fixes tag
> 
>   Fixes: d58f2f658159 ("f2fs: add node_io_flag for bio flags likewise data_io_flag")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 4a6183fb7db6 ("f2fs: add node_io_flag for bio flags likewise data_io_flag")

Ah, both are in dev branch. Let me drop the Fixes tag.

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the f2fs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  35942e2134fa ("f2fs: attach IO flags to the missing cases")

Fixes tag

  Fixes: d58f2f658159 ("f2fs: add node_io_flag for bio flags likewise data_io_flag")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 4a6183fb7db6 ("f2fs: add node_io_flag for bio flags likewise data_io_flag")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]