* linux-next: build warnings after merge of the nvmem tree
@ 2023-03-15 1:46 Stephen Rothwell
2023-03-15 9:30 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2023-03-15 1:46 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Miquel Raynal, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
Hi all,
After merging the nvmem tree, today's linux-next build (htmldocs)
produced these warnings:
drivers/of/base.c:1228: warning: Function parameter or member 'alias' not described in 'of_alias_from_compatible'
drivers/of/base.c:1228: warning: Excess function parameter 'modalias' description in 'of_alias_from_compatible'
Introduced by commit
c077ed868e50 ("of: Rename of_modalias_node()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: build warnings after merge of the nvmem tree
2023-03-15 1:46 linux-next: build warnings after merge of the nvmem tree Stephen Rothwell
@ 2023-03-15 9:30 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2023-03-15 9:30 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Srinivas Kandagatla, Linux Kernel Mailing List, Linux Next Mailing List
Hi Srinivas,
sfr@canb.auug.org.au wrote on Wed, 15 Mar 2023 12:46:12 +1100:
> Hi all,
>
> After merging the nvmem tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> drivers/of/base.c:1228: warning: Function parameter or member 'alias' not described in 'of_alias_from_compatible'
> drivers/of/base.c:1228: warning: Excess function parameter 'modalias' description in 'of_alias_from_compatible'
>
> Introduced by commit
>
> c077ed868e50 ("of: Rename of_modalias_node()")
I failed to update all occurrences of "modalias" in this function. Here
is a diff that you can squash directly with the above mentioned commit.
I can submit it through the mailing list as well, but I believe it's
best to squash that based on the previous conversations (and it does
not matter since you re-send the patches to Greg in the end).
Thanks,
Miquèl
---
From f1378f89b9964fea759eabf5a54beee2782890c7 Mon Sep 17 00:00:00 2001
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed, 15 Mar 2023 10:25:28 +0100
Subject: [PATCH] fixup! of: Rename of_modalias_node()
---
drivers/of/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 3c1badab287f..161fe3192c46 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1211,7 +1211,7 @@ EXPORT_SYMBOL(of_find_matching_node_and_match);
* of_alias_from_compatible - Lookup appropriate alias for a device node
* depending on compatible
* @node: pointer to a device tree node
- * @modalias: Pointer to buffer that alias value will be copied into
+ * @alias: Pointer to buffer that alias value will be copied into
* @len: Length of alias value
*
* Based on the value of the compatible property, this routine will attempt
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-15 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 1:46 linux-next: build warnings after merge of the nvmem tree Stephen Rothwell
2023-03-15 9:30 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).