linux-next: manual merge of the char-misc tree with the devicetree tree

linux-next: manual merge of the char-misc tree with the devicetree tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

Hi all,

Today's linux-next merge of the char-misc tree got a conflict in:

  drivers/of/Makefile

between commit:

  bac06718990c ("of: Move CPU node related functions to their own file")

from the devicetree tree and commit:

  bd7a7ed774af ("of: Move of_modalias() to module.c")

from the char-misc tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/of/Makefile
index 10f704592561,ae9923fd2940..000000000000
--- a/drivers/of/Makefile
+++ b/drivers/of/Makefile
@@@ -1,5 -1,5 +1,5 @@@
  # SPDX-License-Identifier: GPL-2.0
- obj-y = base.o cpu.o device.o platform.o property.o
 -obj-y = base.o device.o module.o platform.o property.o
++obj-y = base.o cpu.o device.o module.o platform.o property.o
  obj-$(CONFIG_OF_KOBJ) += kobj.o
  obj-$(CONFIG_OF_DYNAMIC) += dynamic.o
  obj-$(CONFIG_OF_FLATTREE) += fdt.o

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: manual merge of the char-misc tree with the devicetree tree

[Greg KH]

On Tue, Apr 11, 2023 at 01:57:28PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the char-misc tree got a conflict in:
> 
>   drivers/of/Makefile
> 
> between commit:
> 
>   bac06718990c ("of: Move CPU node related functions to their own file")
> 
> from the devicetree tree and commit:
> 
>   bd7a7ed774af ("of: Move of_modalias() to module.c")
> 
> from the char-misc tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 
> diff --cc drivers/of/Makefile
> index 10f704592561,ae9923fd2940..000000000000
> --- a/drivers/of/Makefile
> +++ b/drivers/of/Makefile
> @@@ -1,5 -1,5 +1,5 @@@
>   # SPDX-License-Identifier: GPL-2.0
> - obj-y = base.o cpu.o device.o platform.o property.o
>  -obj-y = base.o device.o module.o platform.o property.o
> ++obj-y = base.o cpu.o device.o module.o platform.o property.o
>   obj-$(CONFIG_OF_KOBJ) += kobj.o
>   obj-$(CONFIG_OF_DYNAMIC) += dynamic.o
>   obj-$(CONFIG_OF_FLATTREE) += fdt.o


Merge looks good to me, thanks!

greg k-h

Re: linux-next: manual merge of the char-misc tree with the devicetree tree

[Miquel Raynal]

Hi Stephen,

greg@kroah.com wrote on Tue, 11 Apr 2023 09:33:30 +0200:

> On Tue, Apr 11, 2023 at 01:57:28PM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Today's linux-next merge of the char-misc tree got a conflict in:
> > 
> >   drivers/of/Makefile
> > 
> > between commit:
> > 
> >   bac06718990c ("of: Move CPU node related functions to their own file")
> > 
> > from the devicetree tree and commit:
> > 
> >   bd7a7ed774af ("of: Move of_modalias() to module.c")
> > 
> > from the char-misc tree.
> > 
> > I fixed it up (see below) and can carry the fix as necessary. This
> > is now fixed as far as linux-next is concerned, but any non trivial
> > conflicts should be mentioned to your upstream maintainer when your tree
> > is submitted for merging.  You may also want to consider cooperating
> > with the maintainer of the conflicting tree to minimise any particularly
> > complex conflicts.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> > 
> > diff --cc drivers/of/Makefile
> > index 10f704592561,ae9923fd2940..000000000000
> > --- a/drivers/of/Makefile
> > +++ b/drivers/of/Makefile
> > @@@ -1,5 -1,5 +1,5 @@@
> >   # SPDX-License-Identifier: GPL-2.0
> > - obj-y = base.o cpu.o device.o platform.o property.o
> >  -obj-y = base.o device.o module.o platform.o property.o
> > ++obj-y = base.o cpu.o device.o module.o platform.o property.o
> >   obj-$(CONFIG_OF_KOBJ) += kobj.o
> >   obj-$(CONFIG_OF_DYNAMIC) += dynamic.o
> >   obj-$(CONFIG_OF_FLATTREE) += fdt.o  
> 
> 
> Merge looks good to me, thanks!

Agreed :)

Thanks,
Miquèl

Re: linux-next: manual merge of the char-misc tree with the devicetree tree

[Greg KH]

On Fri, Apr 14, 2023 at 04:13:26PM +0100, broonie@kernel.org wrote:
> Hi all,
> 
> Today's linux-next merge of the char-misc tree got a conflict in:
> 
>   include/linux/of.h
> 
> between commit:
> 
>   82174a0a9c5cf ("of: Move of_device_get_match_data() declaration")
> 
> from the devicetree tree and commit:
> 
>   673aa1ed1c9b6 ("of: Rename of_modalias_node()")
> 
> from the char-misc tree.
> 
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging.  You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
> 
> diff --cc include/linux/of.h
> index bc2eb39dcf753,9b7a99499ef35..0000000000000
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@@ -370,8 -373,8 +370,9 @@@ extern int of_n_addr_cells(struct devic
>   extern int of_n_size_cells(struct device_node *np);
>   extern const struct of_device_id *of_match_node(
>   	const struct of_device_id *matches, const struct device_node *node);
>  +extern const void *of_device_get_match_data(const struct device *dev);
> - extern int of_modalias_node(struct device_node *node, char *modalias, int len);
> + extern int of_alias_from_compatible(const struct device_node *node, char *alias,
> + 				    int len);
>   extern void of_print_phandle_args(const char *msg, const struct of_phandle_args *args);
>   extern int __of_parse_phandle_with_args(const struct device_node *np,
>   	const char *list_name, const char *cells_name, int cell_count,

Looks good to me, thanks!

greg k-h

linux-next: manual merge of the char-misc tree with the devicetree tree

[broonie]

Hi all,

Today's linux-next merge of the char-misc tree got a conflict in:

  include/linux/of.h

between commit:

  82174a0a9c5cf ("of: Move of_device_get_match_data() declaration")

from the devicetree tree and commit:

  673aa1ed1c9b6 ("of: Rename of_modalias_node()")

from the char-misc tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

diff --cc include/linux/of.h
index bc2eb39dcf753,9b7a99499ef35..0000000000000
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@@ -370,8 -373,8 +370,9 @@@ extern int of_n_addr_cells(struct devic
  extern int of_n_size_cells(struct device_node *np);
  extern const struct of_device_id *of_match_node(
  	const struct of_device_id *matches, const struct device_node *node);
 +extern const void *of_device_get_match_data(const struct device *dev);
- extern int of_modalias_node(struct device_node *node, char *modalias, int len);
+ extern int of_alias_from_compatible(const struct device_node *node, char *alias,
+ 				    int len);
  extern void of_print_phandle_args(const char *msg, const struct of_phandle_args *args);
  extern int __of_parse_phandle_with_args(const struct device_node *np,
  	const char *list_name, const char *cells_name, int cell_count,