From: coverity-bot <keescook@chromium.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: linux-rdma@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
syzbot+d4faee732755bba9838e@syzkaller.appspotmail.com,
"David S. Miller" <davem@davemloft.net>,
Allison Henderson <allison.henderson@oracle.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rds-devel@oss.oracle.com,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Coverity: __rds_rdma_map(): Null pointer dereferences
Date: Thu, 7 Mar 2024 11:32:24 -0800 [thread overview]
Message-ID: <202403071132.37BBF46E@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20240307 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Wed Mar 6 11:58:42 2024 +0000
c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down")
Coverity reported the following:
*** CID 1584247: Null pointer dereferences (FORWARD_NULL)
net/rds/rdma.c:306 in __rds_rdma_map()
300 unpin_user_pages(pages, nr_pages);
301 kfree(sg);
302 }
303 ret = PTR_ERR(trans_private);
304 /* Trigger connection so that its ready for the next retry */
305 if (ret == -ENODEV)
vvv CID 1584247: Null pointer dereferences (FORWARD_NULL)
vvv Dereferencing null pointer "cp".
306 rds_conn_connect_if_down(cp->cp_conn);
307 goto out;
308 }
309
310 mr->r_trans_private = trans_private;
311
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1584247 ("Null pointer dereferences")
Fixes: c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2024-03-07 19:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202403071132.37BBF46E@keescook \
--to=keescook@chromium.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=eadavis@qq.com \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=syzbot+d4faee732755bba9838e@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).