* linux-next: build warning after merge of the mm-hotfixes tree
@ 2024-04-16 7:35 Stephen Rothwell
2024-04-16 18:51 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2024-04-16 7:35 UTC (permalink / raw)
To: Andrew Morton
Cc: Qiang Zhang, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Hi all,
After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
produced this warning:
lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
Introduced by commit
aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the mm-hotfixes tree
2024-04-16 7:35 linux-next: build warning after merge of the mm-hotfixes tree Stephen Rothwell
@ 2024-04-16 18:51 ` Andrew Morton
2024-04-17 5:29 ` Stephen Rothwell
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Morton @ 2024-04-16 18:51 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Qiang Zhang, Linux Kernel Mailing List, Linux Next Mailing List
On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> produced this warning:
>
> lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
>
> Introduced by commit
>
> aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
>
> from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
Thanks. How's this?
--- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
+++ a/lib/bootconfig.c
@@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
}
/**
- * xbc_exit() - Clean up all parsed bootconfig
+ * _xbc_exit() - Clean up all parsed bootconfig
+ * @early: in early xbc init error
*
* This clears all data structures of parsed bootconfig on memory.
* If you need to reuse xbc_init() with new boot config, you can
_
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the mm-hotfixes tree
2024-04-16 18:51 ` Andrew Morton
@ 2024-04-17 5:29 ` Stephen Rothwell
2024-04-17 20:53 ` Andrew Morton
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2024-04-17 5:29 UTC (permalink / raw)
To: Andrew Morton
Cc: Qiang Zhang, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
Hi Andrew,
On Tue, 16 Apr 2024 11:51:14 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Tue, 16 Apr 2024 17:35:25 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> > After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > lib/bootconfig.c:911: warning: Function parameter or struct member 'early' not described in '_xbc_exit'
> > lib/bootconfig.c:911: warning: expecting prototype for xbc_exit(). Prototype was for _xbc_exit() instead
> >
> > Introduced by commit
> >
> > aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
> >
> > from the mm-hotfixes-unstable branch of the mm-hotfixes tree.
>
> Thanks. How's this?
>
> --- a/lib/bootconfig.c~bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy-fix
> +++ a/lib/bootconfig.c
> @@ -901,7 +901,8 @@ static int __init xbc_parse_tree(void)
> }
>
> /**
> - * xbc_exit() - Clean up all parsed bootconfig
> + * _xbc_exit() - Clean up all parsed bootconfig
> + * @early: in early xbc init error
> *
> * This clears all data structures of parsed bootconfig on memory.
> * If you need to reuse xbc_init() with new boot config, you can
> _
>
OK, so the above two warnings went away, but now I get
lib/bootconfig.c:909: warning: expecting prototype for _xbc_exit(). Prototype was for xbc_exit() instead
Commit
aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
that was in the mm tree yesterday is not there now.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the mm-hotfixes tree
2024-04-17 5:29 ` Stephen Rothwell
@ 2024-04-17 20:53 ` Andrew Morton
0 siblings, 0 replies; 7+ messages in thread
From: Andrew Morton @ 2024-04-17 20:53 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Qiang Zhang, Linux Kernel Mailing List, Linux Next Mailing List
On Wed, 17 Apr 2024 15:29:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > * This clears all data structures of parsed bootconfig on memory.
> > * If you need to reuse xbc_init() with new boot config, you can
> > _
> >
>
> OK, so the above two warnings went away, but now I get
>
> lib/bootconfig.c:909: warning: expecting prototype for _xbc_exit(). Prototype was for xbc_exit() instead
>
> Commit
>
> aaeda6237dec ("bootconfig: use memblock_free_late to free xbc memory to buddy")
>
> that was in the mm tree yesterday is not there now.
oop, sorry, fat-fingered that one. Thanks, I brought back
bootconfig-use-memblock_free_late-to-free-xbc-memory-to-buddy.patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* linux-next: build warning after merge of the mm-hotfixes tree
@ 2023-07-25 3:55 Stephen Rothwell
2023-07-25 4:10 ` Hugh Dickins
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Rothwell @ 2023-07-25 3:55 UTC (permalink / raw)
To: Andrew Morton
Cc: Hugh Dickins, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
Hi all,
After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
produced this warning:
Documentation/filesystems/tmpfs.rst:116: ERROR: Malformed table.
Text in column margin in table line 4.
=========== ==============================================================
huge=never Do not allocate huge pages. This is the default.
huge=always Attempt to allocate huge page every time a new page is needed.
huge=within_size Only allocate huge page if it will be fully within i_size.
Also respect madvise(2) hints.
huge=advise Only allocate huge page if requested with madvise(2).
=========== ==============================================================
Introduced by commit
a0ebb5aa2de3 ("tmpfs: fix Documentation of noswap and huge mount options")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the mm-hotfixes tree
2023-07-25 3:55 Stephen Rothwell
@ 2023-07-25 4:10 ` Hugh Dickins
2023-07-25 5:16 ` Randy Dunlap
0 siblings, 1 reply; 7+ messages in thread
From: Hugh Dickins @ 2023-07-25 4:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Andrew Morton, Hugh Dickins,
Linux Kernel Mailing List, Linux Next Mailing List
On Tue, 25 Jul 2023, Stephen Rothwell wrote:
> Hi all,
>
> After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
> produced this warning:
>
> Documentation/filesystems/tmpfs.rst:116: ERROR: Malformed table.
> Text in column margin in table line 4.
>
> =========== ==============================================================
> huge=never Do not allocate huge pages. This is the default.
> huge=always Attempt to allocate huge page every time a new page is needed.
> huge=within_size Only allocate huge page if it will be fully within i_size.
> Also respect madvise(2) hints.
> huge=advise Only allocate huge page if requested with madvise(2).
> =========== ==============================================================
>
> Introduced by commit
>
> a0ebb5aa2de3 ("tmpfs: fix Documentation of noswap and huge mount options")
Sorry about that, Stephen: thanks for the report.
Randy, you're always my goto guy for how to get these Doc things right,
I hope you don't mind. I just write the text as I want it to appear,
then get caught out by unfamiliar rules.
Please suggest a fixup to the fix patch if you can - thanks!
Hugh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: build warning after merge of the mm-hotfixes tree
2023-07-25 4:10 ` Hugh Dickins
@ 2023-07-25 5:16 ` Randy Dunlap
0 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2023-07-25 5:16 UTC (permalink / raw)
To: Hugh Dickins
Cc: Stephen Rothwell, Andrew Morton, Linux Kernel Mailing List,
Linux Next Mailing List
On 7/24/23 21:10, Hugh Dickins wrote:
> On Tue, 25 Jul 2023, Stephen Rothwell wrote:
>
>> Hi all,
>>
>> After merging the mm-hotfixes tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> Documentation/filesystems/tmpfs.rst:116: ERROR: Malformed table.
>> Text in column margin in table line 4.
>>
>> =========== ==============================================================
>> huge=never Do not allocate huge pages. This is the default.
>> huge=always Attempt to allocate huge page every time a new page is needed.
>> huge=within_size Only allocate huge page if it will be fully within i_size.
>> Also respect madvise(2) hints.
>> huge=advise Only allocate huge page if requested with madvise(2).
>> =========== ==============================================================
>>
>> Introduced by commit
>>
>> a0ebb5aa2de3 ("tmpfs: fix Documentation of noswap and huge mount options")
>
> Sorry about that, Stephen: thanks for the report.
>
> Randy, you're always my goto guy for how to get these Doc things right,
> I hope you don't mind. I just write the text as I want it to appear,
> then get caught out by unfamiliar rules.
>
> Please suggest a fixup to the fix patch if you can - thanks!
Hi Hugh,
I have a patch ready. I'll send it in a few minutes.
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-04-17 20:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-16 7:35 linux-next: build warning after merge of the mm-hotfixes tree Stephen Rothwell
2024-04-16 18:51 ` Andrew Morton
2024-04-17 5:29 ` Stephen Rothwell
2024-04-17 20:53 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2023-07-25 3:55 Stephen Rothwell
2023-07-25 4:10 ` Hugh Dickins
2023-07-25 5:16 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).