* [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status
@ 2021-02-01 9:11 Christian König
2021-02-01 9:53 ` Daniel Vetter
2021-02-01 17:09 ` Luben Tuikov
0 siblings, 2 replies; 3+ messages in thread
From: Christian König @ 2021-02-01 9:11 UTC (permalink / raw)
To: sfr, luben.tuikov, linux-next, dri-devel
Looks like this was not correctly adjusted.
Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: a6a1f036c74e ("drm/scheduler: Job timeout handler returns status (v3)")
---
drivers/gpu/drm/v3d/v3d_sched.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c
index ef2338a294ca..ceb33f8e4379 100644
--- a/drivers/gpu/drm/v3d/v3d_sched.c
+++ b/drivers/gpu/drm/v3d/v3d_sched.c
@@ -259,7 +259,7 @@ v3d_cache_clean_job_run(struct drm_sched_job *sched_job)
return NULL;
}
-static enum drm_gpu_sched_status
+static enum drm_gpu_sched_stat
v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
{
enum v3d_queue q;
@@ -294,7 +294,7 @@ v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
* could fail if the GPU got in an infinite loop in the CL, but that
* is pretty unlikely outside of an i-g-t testcase.
*/
-static enum drm_task_status
+static enum drm_gpu_sched_stat
v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
u32 *timedout_ctca, u32 *timedout_ctra)
{
@@ -312,7 +312,7 @@ v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
return v3d_gpu_reset_for_timeout(v3d, sched_job);
}
-static enum drm_task_status
+static enum drm_gpu_sched_stat
v3d_bin_job_timedout(struct drm_sched_job *sched_job)
{
struct v3d_bin_job *job = to_bin_job(sched_job);
@@ -321,7 +321,7 @@ v3d_bin_job_timedout(struct drm_sched_job *sched_job)
&job->timedout_ctca, &job->timedout_ctra);
}
-static enum drm_task_status
+static enum drm_gpu_sched_stat
v3d_render_job_timedout(struct drm_sched_job *sched_job)
{
struct v3d_render_job *job = to_render_job(sched_job);
@@ -330,7 +330,7 @@ v3d_render_job_timedout(struct drm_sched_job *sched_job)
&job->timedout_ctca, &job->timedout_ctra);
}
-static enum drm_task_status
+static enum drm_gpu_sched_stat
v3d_generic_job_timedout(struct drm_sched_job *sched_job)
{
struct v3d_job *job = to_v3d_job(sched_job);
@@ -338,7 +338,7 @@ v3d_generic_job_timedout(struct drm_sched_job *sched_job)
return v3d_gpu_reset_for_timeout(job->v3d, sched_job);
}
-static enum drm_task_status
+static enum drm_gpu_sched_stat
v3d_csd_job_timedout(struct drm_sched_job *sched_job)
{
struct v3d_csd_job *job = to_csd_job(sched_job);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status
2021-02-01 9:11 [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status Christian König
@ 2021-02-01 9:53 ` Daniel Vetter
2021-02-01 17:09 ` Luben Tuikov
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2021-02-01 9:53 UTC (permalink / raw)
To: Christian König
Cc: Stephen Rothwell, Luben Tuikov, linux-next, dri-devel
On Mon, Feb 1, 2021 at 10:12 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Looks like this was not correctly adjusted.
shoulda compile test before pushing :-)
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Fixes: a6a1f036c74e ("drm/scheduler: Job timeout handler returns status (v3)")
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/v3d/v3d_sched.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c
> index ef2338a294ca..ceb33f8e4379 100644
> --- a/drivers/gpu/drm/v3d/v3d_sched.c
> +++ b/drivers/gpu/drm/v3d/v3d_sched.c
> @@ -259,7 +259,7 @@ v3d_cache_clean_job_run(struct drm_sched_job *sched_job)
> return NULL;
> }
>
> -static enum drm_gpu_sched_status
> +static enum drm_gpu_sched_stat
> v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
> {
> enum v3d_queue q;
> @@ -294,7 +294,7 @@ v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
> * could fail if the GPU got in an infinite loop in the CL, but that
> * is pretty unlikely outside of an i-g-t testcase.
> */
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
> u32 *timedout_ctca, u32 *timedout_ctra)
> {
> @@ -312,7 +312,7 @@ v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
> return v3d_gpu_reset_for_timeout(v3d, sched_job);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_bin_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_bin_job *job = to_bin_job(sched_job);
> @@ -321,7 +321,7 @@ v3d_bin_job_timedout(struct drm_sched_job *sched_job)
> &job->timedout_ctca, &job->timedout_ctra);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_render_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_render_job *job = to_render_job(sched_job);
> @@ -330,7 +330,7 @@ v3d_render_job_timedout(struct drm_sched_job *sched_job)
> &job->timedout_ctca, &job->timedout_ctra);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_generic_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_job *job = to_v3d_job(sched_job);
> @@ -338,7 +338,7 @@ v3d_generic_job_timedout(struct drm_sched_job *sched_job)
> return v3d_gpu_reset_for_timeout(job->v3d, sched_job);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_csd_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_csd_job *job = to_csd_job(sched_job);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status
2021-02-01 9:11 [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status Christian König
2021-02-01 9:53 ` Daniel Vetter
@ 2021-02-01 17:09 ` Luben Tuikov
1 sibling, 0 replies; 3+ messages in thread
From: Luben Tuikov @ 2021-02-01 17:09 UTC (permalink / raw)
To: Christian König, sfr, linux-next, dri-devel
Ah, thank you Christian. :-)
This did change a few times--sorry I missed it, not sure how it happened. :-)
Regards,
Luben
On 2021-02-01 4:11 a.m., Christian König wrote:
> Looks like this was not correctly adjusted.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Fixes: a6a1f036c74e ("drm/scheduler: Job timeout handler returns status (v3)")
> ---
> drivers/gpu/drm/v3d/v3d_sched.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c
> index ef2338a294ca..ceb33f8e4379 100644
> --- a/drivers/gpu/drm/v3d/v3d_sched.c
> +++ b/drivers/gpu/drm/v3d/v3d_sched.c
> @@ -259,7 +259,7 @@ v3d_cache_clean_job_run(struct drm_sched_job *sched_job)
> return NULL;
> }
>
> -static enum drm_gpu_sched_status
> +static enum drm_gpu_sched_stat
> v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
> {
> enum v3d_queue q;
> @@ -294,7 +294,7 @@ v3d_gpu_reset_for_timeout(struct v3d_dev *v3d, struct drm_sched_job *sched_job)
> * could fail if the GPU got in an infinite loop in the CL, but that
> * is pretty unlikely outside of an i-g-t testcase.
> */
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
> u32 *timedout_ctca, u32 *timedout_ctra)
> {
> @@ -312,7 +312,7 @@ v3d_cl_job_timedout(struct drm_sched_job *sched_job, enum v3d_queue q,
> return v3d_gpu_reset_for_timeout(v3d, sched_job);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_bin_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_bin_job *job = to_bin_job(sched_job);
> @@ -321,7 +321,7 @@ v3d_bin_job_timedout(struct drm_sched_job *sched_job)
> &job->timedout_ctca, &job->timedout_ctra);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_render_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_render_job *job = to_render_job(sched_job);
> @@ -330,7 +330,7 @@ v3d_render_job_timedout(struct drm_sched_job *sched_job)
> &job->timedout_ctca, &job->timedout_ctra);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_generic_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_job *job = to_v3d_job(sched_job);
> @@ -338,7 +338,7 @@ v3d_generic_job_timedout(struct drm_sched_job *sched_job)
> return v3d_gpu_reset_for_timeout(job->v3d, sched_job);
> }
>
> -static enum drm_task_status
> +static enum drm_gpu_sched_stat
> v3d_csd_job_timedout(struct drm_sched_job *sched_job)
> {
> struct v3d_csd_job *job = to_csd_job(sched_job);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-01 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 9:11 [PATCH] drm/v3d/v3d_sched: fix scheduler callbacks return status Christian König
2021-02-01 9:53 ` Daniel Vetter
2021-02-01 17:09 ` Luben Tuikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).