* swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
@ 2021-10-01 10:49 Naresh Kamboju
2021-10-01 19:57 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Naresh Kamboju @ 2021-10-01 10:49 UTC (permalink / raw)
To: open list, linux-block, Linux-Next Mailing List, lkft-triage
Cc: Jens Axboe, Stephen Rothwell
Following build errors noticed while building Linux next 20211001
with gcc-11 for powerpc architecture.
kernel/sched/debug.c: In function 'print_cfs_group_stats':
kernel/sched/debug.c:460:41: warning: unused variable 'stats'
[-Wunused-variable]
460 | struct sched_statistics *stats =
__schedstats_from_se(se);
| ^~~~~
In file included from include/linux/blkdev.h:6,
from include/linux/blk-mq.h:5,
from drivers/block/swim3.c:24:
drivers/block/swim3.c: In function 'swim3_attach':
drivers/block/swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first
use in this function)
1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
drivers/block/swim3.c:1200:38: note: each undeclared identifier is
reported only once for each function it appears in
1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
| ^~~~~~~~~~~~
include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
276 | __register_blkdev(major, name, NULL)
| ^~~~~
make[3]: *** [scripts/Makefile.build:288: drivers/block/swim3.o] Error 1
make[3]: Target '__build' not remade because of errors.
make[2]: *** [scripts/Makefile.build:571: drivers/block] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:2034: drivers] Error 2
Build config:
https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/config
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
meta data:
-----------
git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
git_sha: a25006a77348ba06c7bc96520d331cd9dd370715
git_short_log: a25006a77348 (\"Add linux-next specific files for 20211001\")
kconfig: ppc6xx_defconfig
kernel_version: 5.15.0-rc3
target_arch: powerpc
toolchain: gcc-11
steps to reproduce:
https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/tuxmake_reproducer.sh
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
2021-10-01 10:49 swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function) Naresh Kamboju
@ 2021-10-01 19:57 ` Jens Axboe
2021-10-02 1:12 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-10-01 19:57 UTC (permalink / raw)
To: Naresh Kamboju, open list, linux-block, Linux-Next Mailing List,
lkft-triage
Cc: Stephen Rothwell
On 10/1/21 4:49 AM, Naresh Kamboju wrote:
> Following build errors noticed while building Linux next 20211001
> with gcc-11 for powerpc architecture.
>
> kernel/sched/debug.c: In function 'print_cfs_group_stats':
> kernel/sched/debug.c:460:41: warning: unused variable 'stats'
> [-Wunused-variable]
> 460 | struct sched_statistics *stats =
> __schedstats_from_se(se);
> | ^~~~~
> In file included from include/linux/blkdev.h:6,
> from include/linux/blk-mq.h:5,
> from drivers/block/swim3.c:24:
> drivers/block/swim3.c: In function 'swim3_attach':
> drivers/block/swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first
> use in this function)
> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
> | ^~~~~~~~~~~~
> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
> 276 | __register_blkdev(major, name, NULL)
> | ^~~~~
> drivers/block/swim3.c:1200:38: note: each undeclared identifier is
> reported only once for each function it appears in
> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
> | ^~~~~~~~~~~~
> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
> 276 | __register_blkdev(major, name, NULL)
> | ^~~~~
> make[3]: *** [scripts/Makefile.build:288: drivers/block/swim3.o] Error 1
> make[3]: Target '__build' not remade because of errors.
> make[2]: *** [scripts/Makefile.build:571: drivers/block] Error 2
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [Makefile:2034: drivers] Error 2
>
> Build config:
> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/config
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> meta data:
> -----------
> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
> git_sha: a25006a77348ba06c7bc96520d331cd9dd370715
> git_short_log: a25006a77348 (\"Add linux-next specific files for 20211001\")
> kconfig: ppc6xx_defconfig
> kernel_version: 5.15.0-rc3
> target_arch: powerpc
> toolchain: gcc-11
>
> steps to reproduce:
> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/tuxmake_reproducer.sh
Does this fix it?
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
index f7e3482e846b..4b91c9aa5892 100644
--- a/drivers/block/swim3.c
+++ b/drivers/block/swim3.c
@@ -27,6 +27,7 @@
#include <linux/module.h>
#include <linux/spinlock.h>
#include <linux/wait.h>
+#include <linux/major.h>
#include <asm/io.h>
#include <asm/dbdma.h>
#include <asm/prom.h>
--
Jens Axboe
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
2021-10-01 19:57 ` Jens Axboe
@ 2021-10-02 1:12 ` Randy Dunlap
2021-10-02 1:25 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-10-02 1:12 UTC (permalink / raw)
To: Jens Axboe, Naresh Kamboju, open list, linux-block,
Linux-Next Mailing List, lkft-triage
Cc: Stephen Rothwell
On 10/1/21 12:57 PM, Jens Axboe wrote:
> On 10/1/21 4:49 AM, Naresh Kamboju wrote:
>> Following build errors noticed while building Linux next 20211001
>> with gcc-11 for powerpc architecture.
>>
>> kernel/sched/debug.c: In function 'print_cfs_group_stats':
>> kernel/sched/debug.c:460:41: warning: unused variable 'stats'
>> [-Wunused-variable]
>> 460 | struct sched_statistics *stats =
>> __schedstats_from_se(se);
>> | ^~~~~
>> In file included from include/linux/blkdev.h:6,
>> from include/linux/blk-mq.h:5,
>> from drivers/block/swim3.c:24:
>> drivers/block/swim3.c: In function 'swim3_attach':
>> drivers/block/swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first
>> use in this function)
>> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
>> | ^~~~~~~~~~~~
>> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
>> 276 | __register_blkdev(major, name, NULL)
>> | ^~~~~
>> drivers/block/swim3.c:1200:38: note: each undeclared identifier is
>> reported only once for each function it appears in
>> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
>> | ^~~~~~~~~~~~
>> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
>> 276 | __register_blkdev(major, name, NULL)
>> | ^~~~~
>> make[3]: *** [scripts/Makefile.build:288: drivers/block/swim3.o] Error 1
>> make[3]: Target '__build' not remade because of errors.
>> make[2]: *** [scripts/Makefile.build:571: drivers/block] Error 2
>> make[2]: Target '__build' not remade because of errors.
>> make[1]: *** [Makefile:2034: drivers] Error 2
>>
>> Build config:
>> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/config
>>
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>
>> meta data:
>> -----------
>> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>> git_sha: a25006a77348ba06c7bc96520d331cd9dd370715
>> git_short_log: a25006a77348 (\"Add linux-next specific files for 20211001\")
>> kconfig: ppc6xx_defconfig
>> kernel_version: 5.15.0-rc3
>> target_arch: powerpc
>> toolchain: gcc-11
>>
>> steps to reproduce:
>> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/tuxmake_reproducer.sh
>
> Does this fix it?
Yes, WorksForMe.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
>
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index f7e3482e846b..4b91c9aa5892 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -27,6 +27,7 @@
> #include <linux/module.h>
> #include <linux/spinlock.h>
> #include <linux/wait.h>
> +#include <linux/major.h>
> #include <asm/io.h>
> #include <asm/dbdma.h>
> #include <asm/prom.h>
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function)
2021-10-02 1:12 ` Randy Dunlap
@ 2021-10-02 1:25 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-10-02 1:25 UTC (permalink / raw)
To: Randy Dunlap, Naresh Kamboju, open list, linux-block,
Linux-Next Mailing List, lkft-triage
Cc: Stephen Rothwell
On 10/1/21 7:12 PM, Randy Dunlap wrote:
> On 10/1/21 12:57 PM, Jens Axboe wrote:
>> On 10/1/21 4:49 AM, Naresh Kamboju wrote:
>>> Following build errors noticed while building Linux next 20211001
>>> with gcc-11 for powerpc architecture.
>>>
>>> kernel/sched/debug.c: In function 'print_cfs_group_stats':
>>> kernel/sched/debug.c:460:41: warning: unused variable 'stats'
>>> [-Wunused-variable]
>>> 460 | struct sched_statistics *stats =
>>> __schedstats_from_se(se);
>>> | ^~~~~
>>> In file included from include/linux/blkdev.h:6,
>>> from include/linux/blk-mq.h:5,
>>> from drivers/block/swim3.c:24:
>>> drivers/block/swim3.c: In function 'swim3_attach':
>>> drivers/block/swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first
>>> use in this function)
>>> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
>>> | ^~~~~~~~~~~~
>>> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
>>> 276 | __register_blkdev(major, name, NULL)
>>> | ^~~~~
>>> drivers/block/swim3.c:1200:38: note: each undeclared identifier is
>>> reported only once for each function it appears in
>>> 1200 | rc = register_blkdev(FLOPPY_MAJOR, "fd");
>>> | ^~~~~~~~~~~~
>>> include/linux/genhd.h:276:27: note: in definition of macro 'register_blkdev'
>>> 276 | __register_blkdev(major, name, NULL)
>>> | ^~~~~
>>> make[3]: *** [scripts/Makefile.build:288: drivers/block/swim3.o] Error 1
>>> make[3]: Target '__build' not remade because of errors.
>>> make[2]: *** [scripts/Makefile.build:571: drivers/block] Error 2
>>> make[2]: Target '__build' not remade because of errors.
>>> make[1]: *** [Makefile:2034: drivers] Error 2
>>>
>>> Build config:
>>> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/config
>>>
>>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>>
>>> meta data:
>>> -----------
>>> git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>>> git_sha: a25006a77348ba06c7bc96520d331cd9dd370715
>>> git_short_log: a25006a77348 (\"Add linux-next specific files for 20211001\")
>>> kconfig: ppc6xx_defconfig
>>> kernel_version: 5.15.0-rc3
>>> target_arch: powerpc
>>> toolchain: gcc-11
>>>
>>> steps to reproduce:
>>> https://builds.tuxbuild.com/1ytcB62L9I617oV0cveJtUhcpUu/tuxmake_reproducer.sh
>>
>> Does this fix it?
>
> Yes, WorksForMe.
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks, now added to my for-next branch.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-02 1:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 10:49 swim3.c:1200:38: error: 'FLOPPY_MAJOR' undeclared (first use in this function) Naresh Kamboju
2021-10-01 19:57 ` Jens Axboe
2021-10-02 1:12 ` Randy Dunlap
2021-10-02 1:25 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).