linux-next: build warning after merge of the ia64 tree

linux-next: build warning after merge of the ia64 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi all,

After merging the ia64 tree, today's linux-next build (powerpc64
allnoconfig) produced this warning:

In file included from kernel/printk/printk.c:41:0:
include/linux/syslog.h:55:12: warning: 'check_syslog_permissions' defined but not used [-Wunused-function]
 static int check_syslog_permissions(int type, bool from_file)
            ^

Introduced by commit c36487706565 ("syslog: Provide stub
check_syslog_permissions").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

RE: linux-next: build warning after merge of the ia64 tree

[Luck, Tony]

> In file included from kernel/printk/printk.c:41:0:
> include/linux/syslog.h:55:12: warning: 'check_syslog_permissions' defined but not used [-Wunused-function]
>  static int check_syslog_permissions(int type, bool from_file)

Bah - missed the "inline".  Fixed now.

Thanks

-Tony

RE: linux-next: build warning after merge of the ia64 tree

[Luck, Tony]

> Caused by commit ca01d6dd2d7a2652000307520777538740efc286 ("pstore:
> new filesystem interface to platform persistent storage").

Thanks for the bug report.  I just pushed a patch ... so this
should be fixed when you rebuild tomorrow:

commit 168f2e14319aba3125946649604e858cbae85be6
Author: Tony Luck <tony.luck@intel.com>
Date:   Thu Jan 6 16:58:58 2011 -0800

    pstore: fix build warning for unused return value from sysfs_create_file
    
    fs/pstore/inode.c: In function 'init_pstore_fs':
    fs/pstore/inode.c:266: warning: ignoring return value of 'sysfs_create_file', declared with attribute wa
    
    Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    Signed-off-by: Tony Luck <tony.luck@intel.com>

-Tony

linux-next: build warning after merge of the ia64 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 638 bytes --]

Hi Tony,

After merging the ia64 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/pstore/inode.c: In function 'init_pstore_fs':
fs/pstore/inode.c:266: warning: ignoring return value of 'sysfs_create_file', declared with attribute warn_unused_result

This warning has been there for some time, I just didn't notice it among
all the other earnings we get :-(

Caused by commit ca01d6dd2d7a2652000307520777538740efc286 ("pstore: new
filesystem interface to platform persistent storage").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]