From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Sachin Sant <sachinp@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9
Date: Tue, 18 Feb 2020 14:53:09 +0300 [thread overview]
Message-ID: <3b37d94d-2ac4-6b5d-ee8a-eb98cc7f6e5d@virtuozzo.com> (raw)
In-Reply-To: <D32F8819-6D7B-4B0E-95B4-E5A1D2E5CF7B@linux.vnet.ibm.com>
On 18.02.2020 14:38, Sachin Sant wrote:
>
>
>> On 18-Feb-2020, at 4:20 PM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>>
>> Hi, Sachin,
>>
>> On 18.02.2020 13:45, Sachin Sant wrote:
>>>
>>> commit a75056fc1e7c
>>> mm/memcontrol.c: allocate shrinker_map on appropriate NUMA node
>>>
>>> I can boot the kernel successfully if the patch is reverted.
>>
>>
>> could you please test your boot with original patch from here:
>>
>> https://patchwork.kernel.org/patch/11360007/
>>
>> ?
> With this original patch I can boot the machine successfully.
Ok, thanks.
I think, there is no a problem in the commited patch, since mem_cgroup_css_alloc()
is called from the place, where any memory allocations have to be allowed. This
is one of the reason, memory_cgrp_subsys.early_init is 0, and all nodes allocations
should be availeble there.
The problem is not in vmalloc() itself, since the second patch with kmalloc_node()
also fails on your setup. Maybe, the reproduction depends on amount of allocated
memory. For me this looks like a problem in powerpc, but it would be interesting
to hear some comments from powerpc guys.
For now we may replace the commited patch with v2 (https://patchwork.kernel.org/patch/11360007/)
containing workaround, which we have in another alloc_mem_cgroup_per_node_info() allocations.
Kirill
prev parent reply other threads:[~2020-02-18 11:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 10:45 [5.6.0-rc2-next-20200218/powerpc] Boot failure on POWER9 Sachin Sant
2020-02-18 10:50 ` Kirill Tkhai
2020-02-18 11:01 ` Kirill Tkhai
2020-02-18 11:35 ` Kirill Tkhai
2020-02-18 11:40 ` Sachin Sant
2020-02-18 11:55 ` Michal Hocko
2020-02-18 14:00 ` Sachin Sant
2020-02-18 14:26 ` Michal Hocko
2020-02-18 15:11 ` Sachin Sant
2020-02-18 15:24 ` Michal Hocko
2020-02-22 3:38 ` Christopher Lameter
2020-02-24 8:58 ` Michal Hocko
2020-02-26 18:25 ` Christopher Lameter
2020-02-26 18:41 ` Michal Hocko
2020-02-26 18:44 ` Christopher Lameter
2020-02-26 19:01 ` Michal Hocko
2020-02-26 20:31 ` David Rientjes
2020-02-26 20:52 ` Michal Hocko
2020-02-26 21:45 ` Vlastimil Babka
2020-02-26 22:29 ` Vlastimil Babka
2020-02-27 12:12 ` Michal Hocko
2020-02-27 16:00 ` Sachin Sant
2020-02-27 16:16 ` Vlastimil Babka
2020-02-27 18:26 ` Michal Hocko
2020-03-10 15:01 ` Michal Hocko
2020-03-12 12:18 ` Michael Ellerman
2020-03-12 16:51 ` Sachin Sant
2020-03-13 10:48 ` Michael Ellerman
2020-03-13 11:12 ` Srikar Dronamraju
2020-03-13 11:35 ` Vlastimil Babka
2020-03-14 8:10 ` Sachin Sant
2020-02-27 12:02 ` Michal Hocko
2020-02-18 11:38 ` Sachin Sant
2020-02-18 11:53 ` Kirill Tkhai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b37d94d-2ac4-6b5d-ee8a-eb98cc7f6e5d@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=sachinp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).