linux-next: Signed-off-by missing for commit in the mm tree

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

Commit

  b2419063123e ("mm/util: use kmap_local_page() in memcmp_pages()")

is missing a Signed-off-by from its author.

Well, not actually, but it helps if the Author of the commit and the
Signed-off-by use the same email address (or slightly more similar
than this:

Author: Fabio De Francesco <fabio.maria.de.francesco@intel.com>
Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mm tree

[Fabio M. De Francesco]

On Monday, 20 November 2023 22:39:51 CET Stephen Rothwell wrote:
> Hi all,
>
> Commit
> 
>   b2419063123e ("mm/util: use kmap_local_page() in memcmp_pages()")
> 
> is missing a Signed-off-by from its author.
> 
> Well, not actually, but it helps if the Author of the commit and the
> Signed-off-by use the same email address (or slightly more similar
> than this:
> 
> Author: Fabio De Francesco <fabio.maria.de.francesco@intel.com>
> Signed-off-by: Fabio M. De Francesco
> <fabio.maria.de.francesco@linux.intel.com>

I'm sorry for this mistake. This was the first patch I sent using the 
[*].intel.com domains, so I was expecting that something could have been badly 
configured.

I think that the other four MM patches I sent the same day have no problems.
I'll be more careful next time.

Thanks,

Fabio

Re: linux-next: Signed-off-by missing for commit in the mm tree

[Roman Gushchin]

On Tue, Oct 03, 2023 at 07:55:22AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Commit
> 
>   e47f255f6365 ("mm-kmem-add-direct-objcg-pointer-to-task_struct-fix")
> 
> is missing a Signed-off-by from its author.

Hi Stephen,

this commit is a fixup which will be merged into the main commit before
the final merge.

Thank you!

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

Hi all,

Commit

  e47f255f6365 ("mm-kmem-add-direct-objcg-pointer-to-task_struct-fix")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi all,

Commit

  f8bc956f6ea6 ("mm: memcontrol: deprecate charge moving")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mm tree

[Andrew Morton]

On Thu, 24 Nov 2022 09:13:15 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Commit
> 
>   55847dd3e622 ("ocfs2: fix memory leak in ocfs2_mount_volume()")
> 
> is missing a Signed-off-by from its author.
> 
> Another one routed via a mailing list :-(
> 
> Maybe we need something like "if the From: address includes ' via '
> and there is a Reply-To: header, then use that address as the author"?

The ocfs2-devel list is a nightmanre.

I added a check for "^From:.* via " to my script - that should prevent.

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

Hi all,

Commit

  55847dd3e622 ("ocfs2: fix memory leak in ocfs2_mount_volume()")

is missing a Signed-off-by from its author.

Another one routed via a mailing list :-(

Maybe we need something like "if the From: address includes ' via '
and there is a Reply-To: header, then use that address as the author"?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

Hi all,

Commit

  95f35bb5cf4c ("mm: add folio_add_lru_vma()")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the mm tree

[Andrew Morton]

On Thu, 9 Jun 2022 10:44:56 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> Commit
> 
>   a4bf92bd6e08 ("ocfs2: kill EBUSY from dlmfs_evict_inode")
> 
> is missing a Signed-off-by from its author.
> 
> This is just a patch that went through a mailing list that rewrote its
> From address ... I wonder if we can make git use the Reply-To address
> for the author in these cases?

Thanks.

I fixed my copy.

Best to use an explicit From: line at top-of-changelog when using ocfs2-devel.

The ocfs2-devel list software is the worst thing since windows 95. 
Does all sorts of weird stuff.  Often patches which are cc:me simply
aren't on the list and weren't delivered to me.  I have to hope like hell
that someone cc'ed a vger list.

linux-next: Signed-off-by missing for commit in the mm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

Commit

  a4bf92bd6e08 ("ocfs2: kill EBUSY from dlmfs_evict_inode")

is missing a Signed-off-by from its author.

This is just a patch that went through a mailing list that rewrote its
From address ... I wonder if we can make git use the Reply-To address
for the author in these cases?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]