From: Corey Minyard <minyard@acm.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Corey Minyard <cminyard@mvista.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the ipmi tree
Date: Thu, 28 Sep 2017 12:34:06 -0500 [thread overview]
Message-ID: <489f35d2-6b65-b96e-76e6-7398b066064d@acm.org> (raw)
In-Reply-To: <20170928144537.1465e782@canb.auug.org.au>
On 09/27/2017 11:45 PM, Stephen Rothwell wrote:
> Hi Corey,
>
> After merging the ipmi tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: data definition has no type or storage class
> MODULE_DEVICE_TABLE(of, of_ipmi_match);
> ^
> drivers/char/ipmi/ipmi_si_platform.c:360:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> drivers/char/ipmi/ipmi_si_platform.c:360:1: warning: parameter names (without types) in function declaration
> drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: data definition has no type or storage class
> MODULE_DEVICE_TABLE(pci, ipmi_pci_devices);
> ^
> drivers/char/ipmi/ipmi_si_pci.c:142:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> drivers/char/ipmi/ipmi_si_pci.c:142:1: warning: parameter names (without types) in function declaration
>
> Caused by commits
>
> a3f3086dd508 ("ipmi_si: Move platform device handling to another file")
> fb5d20a966cf ("ipmi_si: Move PCI setup to another file
>
> Probably missing include files.
>
> I have added this patch for today:
Hmm, I'm wondering how this got missed. I compile tested it, of course,
and lots of things compile my master rebase branch that this came from,
but nothing found this. Oh well.
Thanks for handling this. I have the fixes in and ready for next time.
-corey
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 28 Sep 2017 14:40:49 +1000
> Subject: [PATCH] ipmi_si: MODULE_DEVICE_TABLE needs module.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> drivers/char/ipmi/ipmi_si_pci.c | 2 +-
> drivers/char/ipmi/ipmi_si_platform.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index ad0b7b6ad250..99771f5cad07 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -3,7 +3,7 @@
> *
> * Handling for IPMI devices on the PCI bus.
> */
> -#include <linux/moduleparam.h>
> +#include <linux/module.h>
> #include <linux/pci.h>
> #include "ipmi_si.h"
>
> diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
> index 0e7ff0a4a151..9573f1116450 100644
> --- a/drivers/char/ipmi/ipmi_si_platform.c
> +++ b/drivers/char/ipmi/ipmi_si_platform.c
> @@ -5,7 +5,7 @@
> * coming from the platform.
> */
> #include <linux/types.h>
> -#include <linux/moduleparam.h>
> +#include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/of_platform.h>
> #include <linux/of_address.h>
next prev parent reply other threads:[~2017-09-28 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 4:45 linux-next: build failure after merge of the ipmi tree Stephen Rothwell
2017-09-28 17:34 ` Corey Minyard [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-04 1:48 Stephen Rothwell
2022-11-04 2:14 ` Corey Minyard
2021-10-01 2:52 Stephen Rothwell
2021-10-01 12:15 ` Corey Minyard
2020-04-20 3:09 Stephen Rothwell
2020-04-20 3:51 ` Feng Tang
2019-04-03 3:33 Stephen Rothwell
2019-04-03 20:27 ` Corey Minyard
2019-04-03 21:12 ` Corey Minyard
2019-04-04 0:14 ` Paul E. McKenney
2014-12-17 3:03 Stephen Rothwell
2014-12-17 4:22 ` Corey Minyard
2014-11-17 8:20 Stephen Rothwell
2014-11-17 8:14 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489f35d2-6b65-b96e-76e6-7398b066064d@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).