linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: wireless tree build warnings
@ 2009-08-10  9:41 Stephen Rothwell
  2009-08-10 17:29 ` Luciano Coelho
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2009-08-10  9:41 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-next, linux-kernel, Luciano Coelho

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Hi John,

Today's linux-next build (x86_64 allmodconfig) produced these warnings:

drivers/net/wireless/wl12xx/wl1271_main.c: In function 'wl1271_irq_work':
drivers/net/wireless/wl12xx/wl1271_main.c:184: warning: large integer implicitly truncated to unsigned type
drivers/net/wireless/wl12xx/wl1271_boot.c: In function 'wl1271_boot_upload_firmware_chunk':
drivers/net/wireless/wl12xx/wl1271_boot.c:103: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/net/wireless/wl12xx/wl1271_boot.c:150: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
drivers/net/wireless/wl12xx/wl1271_boot.c: In function 'wl1271_boot_enable_interrupts':
drivers/net/wireless/wl12xx/wl1271_boot.c:278: warning: large integer implicitly truncated to unsigned type

Introduced by commit 4749c814b34dfe02cf08da34a2a2a32f55fbd9bc ("wl1271:
add wl1271 driver files").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: linux-next: wireless tree build warnings
  2009-08-10  9:41 linux-next: wireless tree build warnings Stephen Rothwell
@ 2009-08-10 17:29 ` Luciano Coelho
  0 siblings, 0 replies; 6+ messages in thread
From: Luciano Coelho @ 2009-08-10 17:29 UTC (permalink / raw)
  To: ext Stephen Rothwell; +Cc: John W. Linville, linux-next, linux-kernel

Hi Stephen,

ext Stephen Rothwell wrote:
> Hi John,
>
> Today's linux-next build (x86_64 allmodconfig) produced these warnings:
>
> drivers/net/wireless/wl12xx/wl1271_main.c: In function 'wl1271_irq_work':
> drivers/net/wireless/wl12xx/wl1271_main.c:184: warning: large integer implicitly truncated to unsigned type
> drivers/net/wireless/wl12xx/wl1271_boot.c: In function 'wl1271_boot_upload_firmware_chunk':
> drivers/net/wireless/wl12xx/wl1271_boot.c:103: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> drivers/net/wireless/wl12xx/wl1271_boot.c:150: warning: format '%d' expects type 'int', but argument 2 has type 'size_t'
> drivers/net/wireless/wl12xx/wl1271_boot.c: In function 'wl1271_boot_enable_interrupts':
> drivers/net/wireless/wl12xx/wl1271_boot.c:278: warning: large integer implicitly truncated to unsigned type
>
> Introduced by commit 4749c814b34dfe02cf08da34a2a2a32f55fbd9bc ("wl1271:
> add wl1271 driver files").
>   

I'm very sorry for this.  I haven't built the kernel on 64 bit machines 
and didn't notice these warnings.  I'll fix them as soon as possible and 
send a patch.  Thanks for reporting.

-- 
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: linux-next: wireless tree build warnings
  2009-12-30 23:57 Stephen Rothwell
  2009-12-31  0:56 ` René Bolldorf
@ 2009-12-31 13:19 ` Johannes Berg
  1 sibling, 0 replies; 6+ messages in thread
From: Johannes Berg @ 2009-12-31 13:19 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: John W. Linville, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On Thu, 2009-12-31 at 10:57 +1100, Stephen Rothwell wrote:
> Hi John,
> 
> Today's linux-next build (i386 defconfig) produced thes warnings:

Yeah I didn't notice because it was 64-bit here, Kalle already send a
fix.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: linux-next: wireless tree build warnings
  2009-12-31  0:56 ` René Bolldorf
@ 2009-12-31  2:00   ` Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2009-12-31  2:00 UTC (permalink / raw)
  To: "René Bolldorf"; +Cc: John W. Linville, linux-next, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1971 bytes --]

Hi René, On Thu, 31 Dec 2009 01:56:49 +0100 René Bolldorf <xsecute@googlemail.com> wrote:
>
> On 12/31/09 00:57, Stephen Rothwell wrote:
> > Hi John,
> >
> > Today's linux-next build (i386 defconfig) produced thes warnings:
> >
> > net/mac80211/work.c: In function 'ieee80211_remain_on_channel_timeout':
> > net/mac80211/work.c:534: warning: cast from pointer to integer of different size
> > net/mac80211/work.c: In function 'ieee80211_remain_done':
> > net/mac80211/work.c:1030: warning: cast from pointer to integer of different size
> > net/mac80211/work.c: In function 'ieee80211_wk_remain_on_channel':
> > net/mac80211/work.c:1056: warning: cast from pointer to integer of different size
> > net/mac80211/work.c: In function 'ieee80211_wk_cancel_remain_on_channel':
> > net/mac80211/work.c:1072: warning: cast from pointer to integer of different size
> >
> > Introduced by commits e4da8c37af626001ff704fb29ea14eb58f5f7208
> > ("mac80211: make off-channel work generic") and
> > b8bc4b0aa9bfba755c64b11b8f60e6cfab25dc9d ("mac80211: support
> > remain-on-channel command").
> >
> 
> shouldn't it be u32 instead of u64? Please correct me if I'am wrong.
> 
> Example:
> cfg80211_ready_on_channel(wk->sdata->dev, (u32)wk, wk->chan,
> 		wk->chan_type, wk->remain.duration, GFP_KERNEL);
> instead of:
> cfg80211_ready_on_channel(wk->sdata->dev, (u64)wk, wk->chan,
> 		wk->chan_type, wk->remain.duration, GFP_KERNEL);

the prototype is:

void cfg80211_ready_on_channel(struct net_device *dev, u64 cookie,
                               struct ieee80211_channel *chan,
                               enum nl80211_channel_type channel_type,
                               unsigned int duration, gfp_t gfp);

And in the case in point, "wk" is a pointer, so casting that to a u32
would be even worse on a 64bit architecture.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: linux-next: wireless tree build warnings
  2009-12-30 23:57 Stephen Rothwell
@ 2009-12-31  0:56 ` René Bolldorf
  2009-12-31  2:00   ` Stephen Rothwell
  2009-12-31 13:19 ` Johannes Berg
  1 sibling, 1 reply; 6+ messages in thread
From: René Bolldorf @ 2009-12-31  0:56 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-next, linux-kernel

On 12/31/09 00:57, Stephen Rothwell wrote:
> Hi John,
>
> Today's linux-next build (i386 defconfig) produced thes warnings:
>
> net/mac80211/work.c: In function 'ieee80211_remain_on_channel_timeout':
> net/mac80211/work.c:534: warning: cast from pointer to integer of different size
> net/mac80211/work.c: In function 'ieee80211_remain_done':
> net/mac80211/work.c:1030: warning: cast from pointer to integer of different size
> net/mac80211/work.c: In function 'ieee80211_wk_remain_on_channel':
> net/mac80211/work.c:1056: warning: cast from pointer to integer of different size
> net/mac80211/work.c: In function 'ieee80211_wk_cancel_remain_on_channel':
> net/mac80211/work.c:1072: warning: cast from pointer to integer of different size
>
> Introduced by commits e4da8c37af626001ff704fb29ea14eb58f5f7208
> ("mac80211: make off-channel work generic") and
> b8bc4b0aa9bfba755c64b11b8f60e6cfab25dc9d ("mac80211: support
> remain-on-channel command").
>

Hi,
shouldn't it be u32 instead of u64? Please correct me if I'am wrong.

Example:
cfg80211_ready_on_channel(wk->sdata->dev, (u32)wk, wk->chan,
		wk->chan_type, wk->remain.duration, GFP_KERNEL);
instead of:
cfg80211_ready_on_channel(wk->sdata->dev, (u64)wk, wk->chan,
		wk->chan_type, wk->remain.duration, GFP_KERNEL);

I wish you all a happy new year!

^ permalink raw reply	[flat|nested] 6+ messages in thread
* linux-next: wireless tree build warnings
@ 2009-12-30 23:57 Stephen Rothwell
  2009-12-31  0:56 ` René Bolldorf
  2009-12-31 13:19 ` Johannes Berg
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2009-12-30 23:57 UTC (permalink / raw)
  To: John W. Linville; +Cc: linux-next, linux-kernel, Johannes Berg

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Hi John,

Today's linux-next build (i386 defconfig) produced thes warnings:

net/mac80211/work.c: In function 'ieee80211_remain_on_channel_timeout':
net/mac80211/work.c:534: warning: cast from pointer to integer of different size
net/mac80211/work.c: In function 'ieee80211_remain_done':
net/mac80211/work.c:1030: warning: cast from pointer to integer of different size
net/mac80211/work.c: In function 'ieee80211_wk_remain_on_channel':
net/mac80211/work.c:1056: warning: cast from pointer to integer of different size
net/mac80211/work.c: In function 'ieee80211_wk_cancel_remain_on_channel':
net/mac80211/work.c:1072: warning: cast from pointer to integer of different size

Introduced by commits e4da8c37af626001ff704fb29ea14eb58f5f7208
("mac80211: make off-channel work generic") and
b8bc4b0aa9bfba755c64b11b8f60e6cfab25dc9d ("mac80211: support
remain-on-channel command").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-12-31 13:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-10  9:41 linux-next: wireless tree build warnings Stephen Rothwell
2009-08-10 17:29 ` Luciano Coelho
2009-12-30 23:57 Stephen Rothwell
2009-12-31  0:56 ` René Bolldorf
2009-12-31  2:00   ` Stephen Rothwell
2009-12-31 13:19 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).