* [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h
@ 2012-09-07 21:30 Timur Tabi
2012-09-07 21:32 ` David Miller
2012-09-07 23:42 ` Randy Dunlap
0 siblings, 2 replies; 3+ messages in thread
From: Timur Tabi @ 2012-09-07 21:30 UTC (permalink / raw)
To: linux-kernel, netdev, linux-next, sfr, rdunlap
mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
in linux/of_address.h. This fixes a compilation error:
drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
function 'of_address_to_resource'
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Timur Tabi <timur@freescale.com>
---
drivers/net/phy/mdio-mux-mmioreg.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
index 098239a..9061ba6 100644
--- a/drivers/net/phy/mdio-mux-mmioreg.c
+++ b/drivers/net/phy/mdio-mux-mmioreg.c
@@ -12,6 +12,7 @@
#include <linux/platform_device.h>
#include <linux/device.h>
+#include <linux/of_address.h>
#include <linux/of_mdio.h>
#include <linux/module.h>
#include <linux/init.h>
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h
2012-09-07 21:30 [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h Timur Tabi
@ 2012-09-07 21:32 ` David Miller
2012-09-07 23:42 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-09-07 21:32 UTC (permalink / raw)
To: timur; +Cc: linux-kernel, netdev, linux-next, sfr, rdunlap
From: Timur Tabi <timur@freescale.com>
Date: Fri, 7 Sep 2012 16:30:57 -0500
> mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
> in linux/of_address.h. This fixes a compilation error:
>
> drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
> drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
> function 'of_address_to_resource'
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h
2012-09-07 21:30 [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h Timur Tabi
2012-09-07 21:32 ` David Miller
@ 2012-09-07 23:42 ` Randy Dunlap
1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2012-09-07 23:42 UTC (permalink / raw)
To: Timur Tabi; +Cc: linux-kernel, netdev, linux-next, sfr
On 09/07/2012 02:30 PM, Timur Tabi wrote:
> mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
> in linux/of_address.h. This fixes a compilation error:
>
> drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
> drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
> function 'of_address_to_resource'
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Timur Tabi <timur@freescale.com>
>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/net/phy/mdio-mux-mmioreg.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
> index 098239a..9061ba6 100644
> --- a/drivers/net/phy/mdio-mux-mmioreg.c
> +++ b/drivers/net/phy/mdio-mux-mmioreg.c
> @@ -12,6 +12,7 @@
>
> #include <linux/platform_device.h>
> #include <linux/device.h>
> +#include <linux/of_address.h>
> #include <linux/of_mdio.h>
> #include <linux/module.h>
> #include <linux/init.h>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-07 23:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-07 21:30 [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h Timur Tabi
2012-09-07 21:32 ` David Miller
2012-09-07 23:42 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).