* linux-next: build failure after merge of the squashfs tree
@ 2013-11-01 0:57 Stephen Rothwell
2013-11-01 3:06 ` Phillip Lougher
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2013-11-01 0:57 UTC (permalink / raw)
To: Phillip Lougher; +Cc: linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Hi Phillip,
After merging the squashfs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
fs/squashfs/decompressor_single.c:40:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
free(comp_opts);
^
fs/squashfs/decompressor_single.c:40:2: warning: incompatible implicit declaration of built-in function 'free' [enabled by default]
Caused by commit 99d59ddb8a06 ("Squashfs: Refactor decompressor interface
and code").
I have used the squashfs tree from next-20131031 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build failure after merge of the squashfs tree
2013-11-01 0:57 linux-next: build failure after merge of the squashfs tree Stephen Rothwell
@ 2013-11-01 3:06 ` Phillip Lougher
2013-11-01 4:09 ` Phillip Lougher
0 siblings, 1 reply; 3+ messages in thread
From: Phillip Lougher @ 2013-11-01 3:06 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel
On 01/11/13 00:57, Stephen Rothwell wrote:
> Hi Phillip,
>
> After merging the squashfs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
> fs/squashfs/decompressor_single.c:40:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
> free(comp_opts);
> ^
Yup, applied and pushed the wrong patch.
I noticed shortly afterwards, and pushed the correct patch, but you
obviously had already done your pull.
Squashfs: Refactor decompressor interface and code
committer Phillip Lougher <phillip@squashfs.org.uk> 2013-10-31 23:06:37 (GMT)
These things happen when you rush to get the patches ready for the linux-next
tree.
Squashfs is spare-time work for me, which means I often have no choice to
work on it during the night. Previously when pushing such work for the
linux-next tree I notice it never gets picked up until the next day, because
a push at 4 AM is simply too late to get it into the linux-next tree for that
day because you're in Australia.
So I work out you pull around 11 PM GMT my time, and rush to get the patches
ready for then. Screw up and this time around the process is even more
thankless and humiliating than normal.
Why don't you holier than thou guys get off your pedestals sometime and
see what it's like for the hobbyists who don't get paid to do the work.
Yeah maybe I'm getting to the point where I considering stopping doing
this, because it has become utterly thankless.
Cheers
Phillip
> fs/squashfs/decompressor_single.c:40:2: warning: incompatible implicit declaration of built-in function 'free' [enabled by default]
>
> Caused by commit 99d59ddb8a06 ("Squashfs: Refactor decompressor interface
> and code").
>
> I have used the squashfs tree from next-20131031 for today.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: build failure after merge of the squashfs tree
2013-11-01 3:06 ` Phillip Lougher
@ 2013-11-01 4:09 ` Phillip Lougher
0 siblings, 0 replies; 3+ messages in thread
From: Phillip Lougher @ 2013-11-01 4:09 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Phillip Lougher, linux-next, linux-kernel
On 01/11/13 03:06, Phillip Lougher wrote:
> On 01/11/13 00:57, Stephen Rothwell wrote:
>> Hi Phillip,
>>
>> After merging the squashfs tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> fs/squashfs/decompressor_single.c: In function 'squashfs_decompressor_create':
>> fs/squashfs/decompressor_single.c:40:2: error: implicit declaration of function 'free' [-Werror=implicit-function-declaration]
>> free(comp_opts);
>> ^
>
> Yup, applied and pushed the wrong patch.
>
> I noticed shortly afterwards, and pushed the correct patch, but you
> obviously had already done your pull.
>
> Squashfs: Refactor decompressor interface and code
> committer Phillip Lougher <phillip@squashfs.org.uk> 2013-10-31 23:06:37 (GMT)
>
> These things happen when you rush to get the patches ready for the linux-next
> tree.
>
> Squashfs is spare-time work for me, which means I often have no choice to
> work on it during the night. Previously when pushing such work for the
> linux-next tree I notice it never gets picked up until the next day, because
> a push at 4 AM is simply too late to get it into the linux-next tree for that
> day because you're in Australia.
>
> So I work out you pull around 11 PM GMT my time, and rush to get the patches
> ready for then. Screw up and this time around the process is even more
> thankless and humiliating than normal.
>
> Why don't you holier than thou guys get off your pedestals sometime and
> see what it's like for the hobbyists who don't get paid to do the work.
>
> Yeah maybe I'm getting to the point where I considering stopping doing
> this, because it has become utterly thankless.
Apologies. I was annoyed at myself and let my frustration show.
Phillip
>
> Cheers
>
> Phillip
>
>
>> fs/squashfs/decompressor_single.c:40:2: warning: incompatible implicit declaration of built-in function 'free' [enabled by default]
>>
>> Caused by commit 99d59ddb8a06 ("Squashfs: Refactor decompressor interface
>> and code").
>>
>> I have used the squashfs tree from next-20131031 for today.
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-01 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-01 0:57 linux-next: build failure after merge of the squashfs tree Stephen Rothwell
2013-11-01 3:06 ` Phillip Lougher
2013-11-01 4:09 ` Phillip Lougher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).