From: Karsten Keil <kkeil@linux-pingi.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Vincent Stehlé" <vincent.stehle@laposte.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, "Karsten Keil" <isdn@linux-pingi.de>
Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm
Date: Fri, 22 Nov 2013 08:45:04 +0100 [thread overview]
Message-ID: <528F0B80.9020900@linux-pingi.de> (raw)
In-Reply-To: <s5hzjowhp2l.wl%tiwai@suse.de>
Am 22.11.2013 08:29, schrieb Takashi Iwai:
> At Fri, 22 Nov 2013 00:49:54 +0100,
> Vincent Stehlé wrote:
>>
>> Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in
>> Kconfig.
>>
>> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
>> Cc: Karsten Keil <isdn@linux-pingi.de>
>> ---
>>
>> Hi,
>>
>> This can be seen on e.g. linux next-20131121 with arm allyesconfig.
>>
>> Best regards,
>>
>> V.
>>
>> drivers/isdn/hisax/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig
>> index d9edcc9..53dbb75 100644
>> --- a/drivers/isdn/hisax/Kconfig
>> +++ b/drivers/isdn/hisax/Kconfig
>> @@ -109,7 +109,7 @@ config HISAX_16_3
>>
>> config HISAX_TELESPCI
>> bool "Teles PCI"
>> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
>> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))
>
> Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?
>
> depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))
>
> Or maybe just
>
> depends on PCI && (X86 || BROKEN)
>
> (Alpha? Can anyone test? :)
I never got this card so it was never in my tests, if I remember
correctely somebody had it running with Alpha before 2000.
And yes I'm fine if we simplify this mess to only X86.
Karsten
next prev parent reply other threads:[~2013-11-22 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 23:49 [PATCH linux-next] hisax: disable build for big-endian arm Vincent Stehlé
2013-11-22 7:29 ` Takashi Iwai
2013-11-22 7:45 ` Karsten Keil [this message]
2013-11-22 9:19 ` Geert Uytterhoeven
2013-11-22 9:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F0B80.9020900@linux-pingi.de \
--to=kkeil@linux-pingi.de \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).