From: Takashi Iwai <tiwai@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Vincent Stehlé" <vincent.stehle@laposte.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Next <linux-next@vger.kernel.org>,
"Karsten Keil" <isdn@linux-pingi.de>
Subject: Re: [PATCH linux-next] hisax: disable build for big-endian arm
Date: Fri, 22 Nov 2013 10:25:03 +0100 [thread overview]
Message-ID: <s5hli0ghjps.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAMuHMdXXO2Rnkaac8_-a91Pob53V=Zs7huirCMpA1ha+oWaHBw@mail.gmail.com>
At Fri, 22 Nov 2013 10:19:07 +0100,
Geert Uytterhoeven wrote:
>
> On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> config HISAX_TELESPCI
> >> bool "Teles PCI"
> >> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN)))
> >> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN)))
> >
> > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally?
> >
> > depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM))
>
> CPU_LITTLE_ENDIAN is not defined on all little endian platforms,
> only on those that can support both big and little endian.
Ah, a good point.
> But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to
> a common Kconfig file.
Yeah, this make life easier.
thanks,
Takashi
prev parent reply other threads:[~2013-11-22 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 23:49 [PATCH linux-next] hisax: disable build for big-endian arm Vincent Stehlé
2013-11-22 7:29 ` Takashi Iwai
2013-11-22 7:45 ` Karsten Keil
2013-11-22 9:19 ` Geert Uytterhoeven
2013-11-22 9:25 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hli0ghjps.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=geert@linux-m68k.org \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincent.stehle@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).