linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: manual merge of the bluetooth tree with the net/net-next trees
@ 2014-01-07  1:54 Stephen Rothwell
  2014-01-07 14:37 ` Daniel Borkmann
  2014-01-27 22:54 ` Stephen Rothwell
  0 siblings, 2 replies; 4+ messages in thread
From: Stephen Rothwell @ 2014-01-07  1:54 UTC (permalink / raw)
  To: Gustavo Padovan, David Miller, netdev
  Cc: linux-next, linux-kernel, Daniel Borkmann, Jukka Rissanen

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hi Gustavo,

Today's linux-next merge of the bluetooth tree got a conflict in
net/ieee802154/6lowpan.c between commit 965801e1eb62 ("net: 6lowpan: fix
lowpan_header_create non-compression memcpy call") from the  tree and
commit 8df8c56a5abc ("6lowpan: Moving generic compression code into
6lowpan_iphc.c") from the bluetooth tree.

I fixed it up (I applied the following patch to move the fix into
6lowpan_iphc.c) and can carry the fix as necessary (no action is
required).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 7 Jan 2014 12:52:43 +1100
Subject: [PATCH] net: 6lowpan: fixup for code movement

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ieee802154/6lowpan_iphc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
index 11840f9e46da..e14fe8b2c054 100644
--- a/net/ieee802154/6lowpan_iphc.c
+++ b/net/ieee802154/6lowpan_iphc.c
@@ -677,7 +677,7 @@ int lowpan_header_compress(struct sk_buff *skb, struct net_device *dev,
 			hc06_ptr += 3;
 		} else {
 			/* compress nothing */
-			memcpy(hc06_ptr, &hdr, 4);
+			memcpy(hc06_ptr, hdr, 4);
 			/* replace the top byte with new ECN | DSCP format */
 			*hc06_ptr = tmp;
 			hc06_ptr += 4;
-- 
1.8.5.2

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the bluetooth tree with the net/net-next trees
  2014-01-07  1:54 linux-next: manual merge of the bluetooth tree with the net/net-next trees Stephen Rothwell
@ 2014-01-07 14:37 ` Daniel Borkmann
  2014-01-27 22:54 ` Stephen Rothwell
  1 sibling, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2014-01-07 14:37 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Gustavo Padovan, David Miller, netdev, linux-next, linux-kernel,
	Jukka Rissanen

On 01/07/2014 02:54 AM, Stephen Rothwell wrote:
> Hi Gustavo,
>
> Today's linux-next merge of the bluetooth tree got a conflict in
> net/ieee802154/6lowpan.c between commit 965801e1eb62 ("net: 6lowpan: fix
> lowpan_header_create non-compression memcpy call") from the  tree and
> commit 8df8c56a5abc ("6lowpan: Moving generic compression code into
> 6lowpan_iphc.c") from the bluetooth tree.
>
> I fixed it up (I applied the following patch to move the fix into
> 6lowpan_iphc.c) and can carry the fix as necessary (no action is
> required).
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 7 Jan 2014 12:52:43 +1100
> Subject: [PATCH] net: 6lowpan: fixup for code movement
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Looks good to me, thanks!

> ---
>   net/ieee802154/6lowpan_iphc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
> index 11840f9e46da..e14fe8b2c054 100644
> --- a/net/ieee802154/6lowpan_iphc.c
> +++ b/net/ieee802154/6lowpan_iphc.c
> @@ -677,7 +677,7 @@ int lowpan_header_compress(struct sk_buff *skb, struct net_device *dev,
>   			hc06_ptr += 3;
>   		} else {
>   			/* compress nothing */
> -			memcpy(hc06_ptr, &hdr, 4);
> +			memcpy(hc06_ptr, hdr, 4);
>   			/* replace the top byte with new ECN | DSCP format */
>   			*hc06_ptr = tmp;
>   			hc06_ptr += 4;
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the bluetooth tree with the net/net-next trees
  2014-01-07  1:54 linux-next: manual merge of the bluetooth tree with the net/net-next trees Stephen Rothwell
  2014-01-07 14:37 ` Daniel Borkmann
@ 2014-01-27 22:54 ` Stephen Rothwell
  2014-01-28  0:43   ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2014-01-27 22:54 UTC (permalink / raw)
  To: Gustavo Padovan, David Miller, netdev
  Cc: linux-next, linux-kernel, Daniel Borkmann, Jukka Rissanen

[-- Attachment #1: Type: text/plain, Size: 1638 bytes --]

Hi all,

On Tue, 7 Jan 2014 12:54:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next merge of the bluetooth tree got a conflict in
> net/ieee802154/6lowpan.c between commit 965801e1eb62 ("net: 6lowpan: fix
> lowpan_header_create non-compression memcpy call") from the  tree and
> commit 8df8c56a5abc ("6lowpan: Moving generic compression code into
> 6lowpan_iphc.c") from the bluetooth tree.
> 
> I fixed it up (I applied the following patch to move the fix into
> 6lowpan_iphc.c) and can carry the fix as necessary (no action is
> required).
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 7 Jan 2014 12:52:43 +1100
> Subject: [PATCH] net: 6lowpan: fixup for code movement
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  net/ieee802154/6lowpan_iphc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c
> index 11840f9e46da..e14fe8b2c054 100644
> --- a/net/ieee802154/6lowpan_iphc.c
> +++ b/net/ieee802154/6lowpan_iphc.c
> @@ -677,7 +677,7 @@ int lowpan_header_compress(struct sk_buff *skb, struct net_device *dev,
>  			hc06_ptr += 3;
>  		} else {
>  			/* compress nothing */
> -			memcpy(hc06_ptr, &hdr, 4);
> +			memcpy(hc06_ptr, hdr, 4);
>  			/* replace the top byte with new ECN | DSCP format */
>  			*hc06_ptr = tmp;
>  			hc06_ptr += 4;
> -- 
> 1.8.5.2

I think this fix patch got missed when bluetooth was merged ... so it
should probably go into the net tree.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: manual merge of the bluetooth tree with the net/net-next trees
  2014-01-27 22:54 ` Stephen Rothwell
@ 2014-01-28  0:43   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-01-28  0:43 UTC (permalink / raw)
  To: sfr; +Cc: gustavo, netdev, linux-next, linux-kernel, dborkman, jukka.rissanen

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 Jan 2014 09:54:15 +1100

> On Tue, 7 Jan 2014 12:54:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
 ...
>> From: Stephen Rothwell <sfr@canb.auug.org.au>
>> Date: Tue, 7 Jan 2014 12:52:43 +1100
>> Subject: [PATCH] net: 6lowpan: fixup for code movement
>> 
>> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
 ...
> I think this fix patch got missed when bluetooth was merged ... so it
> should probably go into the net tree.

Good catch, applied, thanks Stephen!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-28  0:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-07  1:54 linux-next: manual merge of the bluetooth tree with the net/net-next trees Stephen Rothwell
2014-01-07 14:37 ` Daniel Borkmann
2014-01-27 22:54 ` Stephen Rothwell
2014-01-28  0:43   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).