* linux-next: build warning after merge of the input-current tree
@ 2019-07-23 23:54 Stephen Rothwell
2019-07-24 4:48 ` Kai-Heng Feng
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2019-07-23 23:54 UTC (permalink / raw)
To: Dmitry Torokhov, Kees Cook
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Kai-Heng Feng, Gustavo A. R. Silva
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
Hi all,
After merging the input-current tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify':
drivers/input/mouse/elantech.c:1843:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dmi_get_bios_year() >= 2018)
^
drivers/input/mouse/elantech.c:1845:2: note: here
default:
^~~~~~~
Introduced by commit
883a2a80f79c ("Input: elantech - enable SMBus on new (2018+) systems")
I get these warnings because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early. The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: linux-next: build warning after merge of the input-current tree
2019-07-23 23:54 linux-next: build warning after merge of the input-current tree Stephen Rothwell
@ 2019-07-24 4:48 ` Kai-Heng Feng
0 siblings, 0 replies; 2+ messages in thread
From: Kai-Heng Feng @ 2019-07-24 4:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Dmitry Torokhov, Kees Cook, Linux Next Mailing List,
Linux Kernel Mailing List, Gustavo A. R. Silva
Hi Stephen,
at 07:54, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the input-current tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/input/mouse/elantech.c: In function 'elantech_use_host_notify':
> drivers/input/mouse/elantech.c:1843:6: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> if (dmi_get_bios_year() >= 2018)
> ^
> drivers/input/mouse/elantech.c:1845:2: note: here
> default:
> ^~~~~~~
>
> Introduced by commit
>
> 883a2a80f79c ("Input: elantech - enable SMBus on new (2018+) systems")
>
> I get these warnings because I am building with -Wimplicit-fallthrough
> in attempt to catch new additions early. The gcc warning can be turned
> off by adding a /* fall through */ comment at the point the fall through
> happens (assuming that the fall through is intentional).
Yes the fall through is intentional.
Kai-Heng
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-24 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 23:54 linux-next: build warning after merge of the input-current tree Stephen Rothwell
2019-07-24 4:48 ` Kai-Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).