From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
moderated for non-subscribers <alsa-devel@alsa-project.org>
Subject: Re: linux-next: Tree for Oct 14 (sound/soc/sof/)
Date: Mon, 14 Oct 2019 08:05:16 -0700 [thread overview]
Message-ID: <6e2a049a-c5ac-3294-0dd4-7a10b972586a@infradead.org> (raw)
In-Reply-To: <20191014174707.469f596f@canb.auug.org.au>
On 10/13/19 11:47 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20191011:
>
on i386:
ld: sound/soc/sof/control.o: in function `snd_sof_switch_put':
control.c:(.text+0x49a): undefined reference to `ledtrig_audio_set'
ld: control.c:(.text+0x4d1): undefined reference to `ledtrig_audio_set'
when
CONFIG_LEDS_TRIGGER_AUDIO=m
CONFIG_SND_SOC_SOF=y
This code in <linux/leds.h> does not handle the config combo above:
#if IS_ENABLED(CONFIG_LEDS_TRIGGER_AUDIO)
enum led_brightness ledtrig_audio_get(enum led_audio type);
void ledtrig_audio_set(enum led_audio type, enum led_brightness state);
#else
static inline enum led_brightness ledtrig_audio_get(enum led_audio type)
{
return LED_OFF;
}
static inline void ledtrig_audio_set(enum led_audio type,
enum led_brightness state)
{
}
#endif
--
~Randy
next prev parent reply other threads:[~2019-10-14 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 6:47 linux-next: Tree for Oct 14 Stephen Rothwell
2019-10-14 15:05 ` Randy Dunlap [this message]
2019-10-14 15:30 ` linux-next: Tree for Oct 14 (insn_decoder_test) Randy Dunlap
2019-10-23 5:49 ` Masami Hiramatsu
2019-11-28 0:04 ` Randy Dunlap
2020-01-21 15:43 ` Randy Dunlap
2020-01-22 3:11 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e2a049a-c5ac-3294-0dd4-7a10b972586a@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).