linux-next: Fixes tag needs some work in the rcu tree

linux-next: Fixes tag needs some work in the rcu tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

Hi all,

In commit

  acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")

Fixes tag

  Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Maybe you meant:

Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the rcu tree

[Paul E. McKenney]

On Thu, Apr 06, 2023 at 08:36:19AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
> 
> Fixes tag
> 
>   Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory after old grace period")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Maybe you meant:
> 
> Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of kfree_rcu() work")

Hello, Stephen,

There is currently some debate as to exactly which commit(s) introduced
the bug, which will hopefully come to a conclusion before tomorrow's
-next.  If they do not, I will use your correction as a placeholder.

Just for completeness, the current other two candidates (which appear
quite plausible to me) are these:

Fixes: 34c881745549 ("rcu: Support kfree_bulk() interface in kfree_rcu()")
Fixes: 5f3c8d620447 ("rcu/tree: Maintain separate array for vmalloc ptrs")

Ziwei Dai, what are your thoughts on this?  This is from a mainline
perspective, my guess being that your investigation involved some other
Linux-kernel tree.

							Thanx, Paul

答复: linux-next: Fixes tag needs some work in the rcu tree

[代子为 (Ziwei Dai)]

> -----邮件原件-----
> 发件人: Paul E. McKenney <paulmck@kernel.org>
> 发送时间: 2023年4月6日 6:59
> 收件人: Stephen Rothwell <sfr@canb.auug.org.au>
> 抄送: 代子为 (Ziwei Dai) <Ziwei.Dai@unisoc.com>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Linux Next Mailing List
> <linux-next@vger.kernel.org>
> 主题: Re: linux-next: Fixes tag needs some work in the rcu tree
> 
> 
> 注意: 这封邮件来自于外部。除非你确定邮件内容安全，否则不要点击任何链接和附件。
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the
> sender and know the content is safe.
> 
> 
> 
> On Thu, Apr 06, 2023 at 08:36:19AM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   acdc79917d65 ("rcu/kvfree: Avoid freeing new kfree_rcu() memory
> > after old grace period")
> >
> > Fixes tag
> >
> >   Fixes: 0392bebebf26 ("rcu/kvfree: Avoid freeing new kfree_rcu()
> > memory after old grace period")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> >       git log -1 --format='Fixes: %h ("%s")'
> >
> > Maybe you meant:
> >
> > Fixes: 0392bebebf26 ("rcu: Add multiple in-flight batches of
> > kfree_rcu() work")
> 
> Hello, Stephen,
> 
> There is currently some debate as to exactly which commit(s) introduced the bug, which will hopefully come to a conclusion before
> tomorrow's -next.  If they do not, I will use your correction as a placeholder.
> 
> Just for completeness, the current other two candidates (which appear quite plausible to me) are these:
> 
> Fixes: 34c881745549 ("rcu: Support kfree_bulk() interface in kfree_rcu()")
> Fixes: 5f3c8d620447 ("rcu/tree: Maintain separate array for vmalloc ptrs")
> 
> Ziwei Dai, what are your thoughts on this?  This is from a mainline perspective, my guess being that your investigation involved some
> other Linux-kernel tree.
> 
>                                                         Thanx, Paul

Hi Paul, right, please help correct it.