linux-next: build warning after merge of the ext3 tree

linux-next: build warning after merge of the ext3 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

Hi all,

After merging the ext3 tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.

Introduced by commit

  c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the ext3 tree

[Gabriel Krisman Bertazi]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> After merging the ext3 tree, today's linux-next build (htmldocs) produced
> this warning:
>
> Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.
>
> Introduced by commit
>
>   c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")

Hi Stephen, Jan,

I'd suggest the patch below.

Thank you,

-- >8 --
From: Gabriel Krisman Bertazi <krisman@collabora.com>
Date: Thu, 28 Oct 2021 17:17:47 -0300
Subject: [PATCH] docs: Fix formatting of literal sections in fanotify docs

Stephen Rothwell reported the following warning was introduced by commit
c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event").

Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING:
 Definition list ends without a blank line; unexpected unindent.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
 .../admin-guide/filesystem-monitoring.rst     | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/Documentation/admin-guide/filesystem-monitoring.rst b/Documentation/admin-guide/filesystem-monitoring.rst
index 5a3c84e60095..ab8dba76283c 100644
--- a/Documentation/admin-guide/filesystem-monitoring.rst
+++ b/Documentation/admin-guide/filesystem-monitoring.rst
@@ -35,9 +35,11 @@ notifications is Ext4.
 
 A FAN_FS_ERROR Notification has the following format::
 
-  [ Notification Metadata (Mandatory) ]
-  [ Generic Error Record  (Mandatory) ]
-  [ FID record            (Mandatory) ]
+  ::
+
+     [ Notification Metadata (Mandatory) ]
+     [ Generic Error Record  (Mandatory) ]
+     [ FID record            (Mandatory) ]
 
 The order of records is not guaranteed, and new records might be added
 in the future.  Therefore, applications must not rely on the order and
@@ -53,11 +55,13 @@ providing any additional details about the problem.  This record is
 identified by ``struct fanotify_event_info_header.info_type`` being set
 to FAN_EVENT_INFO_TYPE_ERROR.
 
-  struct fanotify_event_info_error {
-	struct fanotify_event_info_header hdr;
-	__s32 error;
-	__u32 error_count;
-  };
+  ::
+
+     struct fanotify_event_info_error {
+          struct fanotify_event_info_header hdr;
+         __s32 error;
+         __u32 error_count;
+     };
 
 The `error` field identifies the type of error using errno values.
 `error_count` tracks the number of errors that occurred and were
-- 
2.33.0

Re: linux-next: build warning after merge of the ext3 tree

[Jan Kara]

On Thu 28-10-21 18:05:49, Gabriel Krisman Bertazi wrote:
> Stephen Rothwell <sfr@canb.auug.org.au> writes:
> 
> > Hi all,
> >
> > After merging the ext3 tree, today's linux-next build (htmldocs) produced
> > this warning:
> >
> > Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING: Definition list ends without a blank line; unexpected unindent.
> >
> > Introduced by commit
> >
> >   c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event")
> 
> Hi Stephen, Jan,
> 
> I'd suggest the patch below.

Thanks. I've added the patch to my tree.

										Honza

> 
> Thank you,
> 
> -- >8 --
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
> Date: Thu, 28 Oct 2021 17:17:47 -0300
> Subject: [PATCH] docs: Fix formatting of literal sections in fanotify docs
> 
> Stephen Rothwell reported the following warning was introduced by commit
> c0baf9ac0b05 ("docs: Document the FAN_FS_ERROR event").
> 
> Documentation/admin-guide/filesystem-monitoring.rst:60: WARNING:
>  Definition list ends without a blank line; unexpected unindent.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
>  .../admin-guide/filesystem-monitoring.rst     | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/admin-guide/filesystem-monitoring.rst b/Documentation/admin-guide/filesystem-monitoring.rst
> index 5a3c84e60095..ab8dba76283c 100644
> --- a/Documentation/admin-guide/filesystem-monitoring.rst
> +++ b/Documentation/admin-guide/filesystem-monitoring.rst
> @@ -35,9 +35,11 @@ notifications is Ext4.
>  
>  A FAN_FS_ERROR Notification has the following format::
>  
> -  [ Notification Metadata (Mandatory) ]
> -  [ Generic Error Record  (Mandatory) ]
> -  [ FID record            (Mandatory) ]
> +  ::
> +
> +     [ Notification Metadata (Mandatory) ]
> +     [ Generic Error Record  (Mandatory) ]
> +     [ FID record            (Mandatory) ]
>  
>  The order of records is not guaranteed, and new records might be added
>  in the future.  Therefore, applications must not rely on the order and
> @@ -53,11 +55,13 @@ providing any additional details about the problem.  This record is
>  identified by ``struct fanotify_event_info_header.info_type`` being set
>  to FAN_EVENT_INFO_TYPE_ERROR.
>  
> -  struct fanotify_event_info_error {
> -	struct fanotify_event_info_header hdr;
> -	__s32 error;
> -	__u32 error_count;
> -  };
> +  ::
> +
> +     struct fanotify_event_info_error {
> +          struct fanotify_event_info_header hdr;
> +         __s32 error;
> +         __u32 error_count;
> +     };
>  
>  The `error` field identifies the type of error using errno values.
>  `error_count` tracks the number of errors that occurred and were
> -- 
> 2.33.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: linux-next: build warning after merge of the ext3 tree

[Jan Kara]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On Thu 28-10-21 21:10:53, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the ext3 tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> samples/fanotify/fs-monitor.c: In function 'handle_notifications':
> samples/fanotify/fs-monitor.c:68:36: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
>    68 |    printf("unexpected FAN MARK: %llx\n", event->mask);
>       |                                 ~~~^     ~~~~~~~~~~~
>       |                                    |          |
>       |                                    |          __u64 {aka long unsigned int}
>       |                                    long long unsigned int
>       |                                 %lx
> 
> Introduced by commit
> 
>   5451093081db ("samples: Add fs error monitoring example")

Thanks for report Stephen. I've added attached patch to my tree to fix it
up.

									Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[-- Attachment #2: 0001-samples-Fix-warning-in-fsnotify-sample.patch --]
[-- Type: text/x-patch, Size: 1695 bytes --]

From b7eccf75c28e5469bb4685a03310dbb66ee323f9 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Mon, 1 Nov 2021 12:47:32 +0100
Subject: [PATCH] samples: Fix warning in fsnotify sample

The fsnotify sample code generates the following warning on powerpc:

samples/fanotify/fs-monitor.c: In function 'handle_notifications':
samples/fanotify/fs-monitor.c:68:36: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
   68 |    printf("unexpected FAN MARK: %llx\n", event->mask);
      |                                 ~~~^     ~~~~~~~~~~~
      |                                    |          |
      |                                    |          __u64 {aka long unsigned int}
      |                                    long long unsigned int
      |                                 %lx

Fix the problem by explicitely typing the argument to proper type.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Jan Kara <jack@suse.cz>
---
 samples/fanotify/fs-monitor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/samples/fanotify/fs-monitor.c b/samples/fanotify/fs-monitor.c
index a0e44cd31e6f..2e08a1807db7 100644
--- a/samples/fanotify/fs-monitor.c
+++ b/samples/fanotify/fs-monitor.c
@@ -65,7 +65,8 @@ static void handle_notifications(char *buffer, int len)
 	for (; FAN_EVENT_OK(event, len); event = FAN_EVENT_NEXT(event, len)) {
 
 		if (event->mask != FAN_FS_ERROR) {
-			printf("unexpected FAN MARK: %llx\n", event->mask);
+			printf("unexpected FAN MARK: %llx\n",
+							(unsigned long long)event->mask);
 			goto next_event;
 		}
 
-- 
2.26.2

linux-next: build warning after merge of the ext3 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 866 bytes --]

Hi all,

After merging the ext3 tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

samples/fanotify/fs-monitor.c: In function 'handle_notifications':
samples/fanotify/fs-monitor.c:68:36: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type '__u64' {aka 'long unsigned int'} [-Wformat=]
   68 |    printf("unexpected FAN MARK: %llx\n", event->mask);
      |                                 ~~~^     ~~~~~~~~~~~
      |                                    |          |
      |                                    |          __u64 {aka long unsigned int}
      |                                    long long unsigned int
      |                                 %lx

Introduced by commit

  5451093081db ("samples: Add fs error monitoring example")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the ext3 tree

[Jan Kara]

On Wed 24-02-10 11:58:11, Jan Kara wrote:
>   Hi Stephen,
> 
> On Wed 24-02-10 19:05:20, Stephen Rothwell wrote:
> > After merging the ext3 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type
> > 
> > Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota:
> > move code from sync_quota_sb into vfs_quota_sync").  From the commit
> > message, I expect that this has been thought about.
>   Thanks for the notification. It seems Christoph missed to convert
> gfs2_quota_sync(). I've now fixed it in a minimalistic way (just added
> the wait parameter to the function).
>   Steven (Whitehouse), if GFS2 wants to do something more clever, please
> let me know (or fix up in your tree).
  And I had to fixup a few internal callers in GFS2 as well. So Steven, you
might want to have a look at the patch (commit
ef9eb614d974943af3c8eab8ea78a30d5132428c in my linux-fs-2.6 tree).

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: linux-next: build warning after merge of the ext3 tree

[Jan Kara]

  Hi Stephen,

On Wed 24-02-10 19:05:20, Stephen Rothwell wrote:
> After merging the ext3 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type
> 
> Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota:
> move code from sync_quota_sb into vfs_quota_sync").  From the commit
> message, I expect that this has been thought about.
  Thanks for the notification. It seems Christoph missed to convert
gfs2_quota_sync(). I've now fixed it in a minimalistic way (just added
the wait parameter to the function).
  Steven (Whitehouse), if GFS2 wants to do something more clever, please
let me know (or fix up in your tree).

								Thanks
									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

linux-next: build warning after merge of the ext3 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

Hi Jan,

After merging the ext3 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/gfs2/quota.c:1581: warning: initialization from incompatible pointer type

Introduced by commit ec304a27d7750ba666ad2d446434ddd47fa93c40 ("quota:
move code from sync_quota_sb into vfs_quota_sync").  From the commit
message, I expect that this has been thought about.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]