From: Randy Dunlap <rdunlap@infradead.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
broonie@kernel.org,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: alsa-devel@alsa-project.org,
Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Tree for Dec 13 (SND_AMD_ACP_CONFIG)
Date: Tue, 14 Dec 2021 08:26:52 -0800 [thread overview]
Message-ID: <8ab0ed95-ce79-cd61-0440-20e0242b8930@infradead.org> (raw)
In-Reply-To: <15c3b6fe-b159-6cee-be67-11f2f2dd0d04@linux.intel.com>
Hi--
On 12/14/21 05:51, Pierre-Louis Bossart wrote:
>
>
>> on i386 or x86_64:
>>
>> when # CONFIG_ACPI is not set,
>> so SND_SOC_ACPI is not set:
>>
>> WARNING: unmet direct dependencies detected for SND_AMD_ACP_CONFIG
>> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_ACPI [=n]
>> Selected by [y]:
>> - SND_SOC_AMD_ACP_COMMON [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && X86 [=y] && PCI [=y]
>>
>>
>> Full randconfig file is attached
>
> It's probably triggered by my recent change to fix another problem.
>
> d9b994cd7641 ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI
>
> I didn't realize SND_AMD_ACP_CONFIG was selected by other configs.
> Moving to a select seems to fix the issue reported by Randy, not sure if
> it's the right thing to do though.
>
That works. You can add my Ack if you want to push this patch.
Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index bcfeb3fc2592..7a9e45094f37 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -98,7 +98,7 @@ config SND_SOC_AMD_YC_MACH
>
> config SND_AMD_ACP_CONFIG
> tristate "AMD ACP configuration selection"
> - depends on SND_SOC_ACPI
> + select SND_SOC_ACPI if ACPI
> help
> This option adds an auto detection to determine which ACP
> driver modules to use
>
>
--
~Randy
next prev parent reply other threads:[~2021-12-14 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 3:02 linux-next: Tree for Dec 13 broonie
2021-12-14 6:20 ` linux-next: Tree for Dec 13 (SND_AMD_ACP_CONFIG) Randy Dunlap
2021-12-14 13:51 ` Pierre-Louis Bossart
2021-12-14 16:26 ` Randy Dunlap [this message]
2021-12-14 17:21 ` Daniel Baluta
2021-12-14 17:25 ` Pierre-Louis Bossart
2021-12-14 17:40 ` Daniel Baluta
2021-12-14 11:44 ` linux-next: Tree for Dec 13 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ab0ed95-ce79-cd61-0440-20e0242b8930@infradead.org \
--to=rdunlap@infradead.org \
--cc=AjitKumar.Pandey@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).