* Re: [PATCH V3 16/19] virtio-pci: introduce modern device module [not found] ` <20210104065503.199631-17-jasowang@redhat.com> @ 2021-02-09 10:15 ` Naresh Kamboju 2021-02-10 4:38 ` Jason Wang 0 siblings, 1 reply; 2+ messages in thread From: Naresh Kamboju @ 2021-02-09 10:15 UTC (permalink / raw) To: Jason Wang Cc: Michael S. Tsirkin, virtualization, open list, shahafs, lulu, sgarzare, Randy Dunlap, lkft-triage, Linux-Next Mailing List, linux-arm-msm, Linux ARM, Arnd Bergmann, Catalin Marinas, Will Deacon, Stephen Rothwell Hi Jason, On Mon, 4 Jan 2021 at 12:28, Jason Wang <jasowang@redhat.com> wrote: > > Signed-off-by: Jason Wang <jasowang@redhat.com> > --- > drivers/virtio/Kconfig | 10 +- > drivers/virtio/Makefile | 1 + > drivers/virtio/virtio_pci_common.h | 27 +- > drivers/virtio/virtio_pci_modern.c | 617 ------------------------- > drivers/virtio/virtio_pci_modern_dev.c | 599 ++++++++++++++++++++++++ > include/linux/virtio_pci_modern.h | 111 +++++ > 6 files changed, 721 insertions(+), 644 deletions(-) > create mode 100644 drivers/virtio/virtio_pci_modern_dev.c > create mode 100644 include/linux/virtio_pci_modern.h > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index 7b41130d3f35..6b9b81f4b8c2 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -12,6 +12,14 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS > This option is selected if the architecture may need to enforce > VIRTIO_F_ACCESS_PLATFORM > > +config VIRTIO_PCI_MODERN > + tristate "Modern Virtio PCI Device" > + depends on PCI > + help > + Modern PCI device implementation. This module implements the > + basic probe and control for devices which are based on modern > + PCI device with possible vendor specific extensions. > + > menuconfig VIRTIO_MENU > bool "Virtio drivers" > default y > @@ -20,7 +28,7 @@ if VIRTIO_MENU > > config VIRTIO_PCI > tristate "PCI driver for virtio devices" > - depends on PCI > + depends on VIRTIO_PCI_MODERN While booting Linux next tag 20210208 kernel on qemu_arm64 and qemu_arm mount rootfs failed. The root cause seems to be due to missing configs CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_PCI_LEGACY=y Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> Then I have to force to enable this MODERN config CONFIG_VIRTIO_PCI_MODERN=y and which enabled CONFIG_VIRTIO_PCI=y CONFIG_VIRTIO_PCI_LEGACY=y and the qemu_arm64 and qemu_arm boot pass. New build link, https://builds.tuxbuild.com/1oEse4EFsoQr1FkKBfiLmhMCe7j/ -- Linaro LKFT https://lkft.linaro.org ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH V3 16/19] virtio-pci: introduce modern device module 2021-02-09 10:15 ` [PATCH V3 16/19] virtio-pci: introduce modern device module Naresh Kamboju @ 2021-02-10 4:38 ` Jason Wang 0 siblings, 0 replies; 2+ messages in thread From: Jason Wang @ 2021-02-10 4:38 UTC (permalink / raw) To: Naresh Kamboju Cc: Michael S. Tsirkin, virtualization, open list, shahafs, lulu, sgarzare, Randy Dunlap, lkft-triage, Linux-Next Mailing List, linux-arm-msm, Linux ARM, Arnd Bergmann, Catalin Marinas, Will Deacon, Stephen Rothwell On 2021/2/9 下午6:15, Naresh Kamboju wrote: > Hi Jason, > > On Mon, 4 Jan 2021 at 12:28, Jason Wang <jasowang@redhat.com> wrote: >> Signed-off-by: Jason Wang <jasowang@redhat.com> >> --- >> drivers/virtio/Kconfig | 10 +- >> drivers/virtio/Makefile | 1 + >> drivers/virtio/virtio_pci_common.h | 27 +- >> drivers/virtio/virtio_pci_modern.c | 617 ------------------------- >> drivers/virtio/virtio_pci_modern_dev.c | 599 ++++++++++++++++++++++++ >> include/linux/virtio_pci_modern.h | 111 +++++ >> 6 files changed, 721 insertions(+), 644 deletions(-) >> create mode 100644 drivers/virtio/virtio_pci_modern_dev.c >> create mode 100644 include/linux/virtio_pci_modern.h >> >> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig >> index 7b41130d3f35..6b9b81f4b8c2 100644 >> --- a/drivers/virtio/Kconfig >> +++ b/drivers/virtio/Kconfig >> @@ -12,6 +12,14 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS >> This option is selected if the architecture may need to enforce >> VIRTIO_F_ACCESS_PLATFORM >> >> +config VIRTIO_PCI_MODERN >> + tristate "Modern Virtio PCI Device" >> + depends on PCI >> + help >> + Modern PCI device implementation. This module implements the >> + basic probe and control for devices which are based on modern >> + PCI device with possible vendor specific extensions. >> + >> menuconfig VIRTIO_MENU >> bool "Virtio drivers" >> default y >> @@ -20,7 +28,7 @@ if VIRTIO_MENU >> >> config VIRTIO_PCI >> tristate "PCI driver for virtio devices" >> - depends on PCI >> + depends on VIRTIO_PCI_MODERN > While booting Linux next tag 20210208 kernel on qemu_arm64 and qemu_arm > mount rootfs failed. The root cause seems to be due to missing configs > CONFIG_VIRTIO_PCI=y > CONFIG_VIRTIO_PCI_LEGACY=y > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > Then I have to force to enable this MODERN config > CONFIG_VIRTIO_PCI_MODERN=y > and which enabled > CONFIG_VIRTIO_PCI=y > CONFIG_VIRTIO_PCI_LEGACY=y > > and the qemu_arm64 and qemu_arm boot pass. > > > New build link, > https://builds.tuxbuild.com/1oEse4EFsoQr1FkKBfiLmhMCe7j/ Thanks for the reporting. I will post a patch to fix the def config to enable VIRTIO_PCI_MODERN. Thanks > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-10 4:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210104065503.199631-1-jasowang@redhat.com>
[not found] ` <20210104065503.199631-17-jasowang@redhat.com>
2021-02-09 10:15 ` [PATCH V3 16/19] virtio-pci: introduce modern device module Naresh Kamboju
2021-02-10 4:38 ` Jason Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).