[next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[Naresh Kamboju]

Large number of Linux next tag 20210408 builds failed due to these errors.

make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=arm
CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'

ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Regressions found on parisc:
  - build/gcc-9-defconfig
  - build/gcc-8-defconfig
  - build/gcc-10-defconfig

Regressions found on sh:
  - build/gcc-9-dreamcast_defconfig
  - build/gcc-10-dreamcast_defconfig
  - build/gcc-8-dreamcast_defconfig

Regressions found on arm:
  - build/clang-12-s3c2410_defconfig
  - build/gcc-8-s3c2410_defconfig
  - build/clang-10-nhk8815_defconfig
  - build/gcc-9-s3c2410_defconfig
  - build/gcc-10-nhk8815_defconfig
  - build/gcc-8-nhk8815_defconfig
  - build/gcc-10-s3c2410_defconfig
  - build/clang-12-nhk8815_defconfig
  - build/clang-11-s3c2410_defconfig
  - build/gcc-9-nhk8815_defconfig
  - build/clang-11-nhk8815_defconfig
  - build/clang-10-s3c2410_defconfig

--
Linaro LKFT
https://lkft.linaro.org

RE: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[Shyam Prasad]

Hi Naresh,

AFAIK, this has been fixed in an updated patch last evening. Can you please check if you're still seeing it?

Thanks and regards,
Shyam

-----Original Message-----
From: Naresh Kamboju <naresh.kamboju@linaro.org> 
Sent: Friday, April 9, 2021 10:36 AM
To: Linux-Next Mailing List <linux-next@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>; samba-technical@lists.samba.org; lkft-triage@lists.linaro.org
Cc: Maciek Borzecki <maciek.borzecki@gmail.com>; Shyam Prasad <Shyam.Prasad@microsoft.com>; Wan Jiabing <wanjiabing@vivo.com>; Steven French <Steven.French@microsoft.com>; pc <pc@cjr.nz>; Pavel Shilovskiy <pshilov@microsoft.com>; Steve French <sfrench@samba.org>
Subject: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

Large number of Linux next tag 20210408 builds failed due to these errors.

make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=arm
CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'

ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Regressions found on parisc:
  - build/gcc-9-defconfig
  - build/gcc-8-defconfig
  - build/gcc-10-defconfig

Regressions found on sh:
  - build/gcc-9-dreamcast_defconfig
  - build/gcc-10-dreamcast_defconfig
  - build/gcc-8-dreamcast_defconfig

Regressions found on arm:
  - build/clang-12-s3c2410_defconfig
  - build/gcc-8-s3c2410_defconfig
  - build/clang-10-nhk8815_defconfig
  - build/gcc-9-s3c2410_defconfig
  - build/gcc-10-nhk8815_defconfig
  - build/gcc-8-nhk8815_defconfig
  - build/gcc-10-s3c2410_defconfig
  - build/clang-12-nhk8815_defconfig
  - build/clang-11-s3c2410_defconfig
  - build/gcc-9-nhk8815_defconfig
  - build/clang-11-nhk8815_defconfig
  - build/clang-10-s3c2410_defconfig

--
Linaro LKFT
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkft.linaro.org%2F&amp;data=04%7C01%7CShyam.Prasad%40microsoft.com%7C416f80ec723a4fcbbc8108d8fb153984%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637535416728141562%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=tq6fEaGRA7hNP34bGp9jIZHfzn3lVt3tS2mNldC9w9w%3D&amp;reserved=0

Re: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[Naresh Kamboju]

On Fri, 9 Apr 2021 at 21:49, Shyam Prasad <Shyam.Prasad@microsoft.com> wrote:
>
> Hi Naresh,
>
> AFAIK, this has been fixed in an updated patch last evening. Can you please check if you're still seeing it?

Please share the fix commit and subject here.

FYI,
This build error is still on today's Linux next tag 20210409.


- Naresh

Re: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[Naresh Kamboju]

On Fri, 9 Apr 2021 at 23:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Fri, 9 Apr 2021 at 21:49, Shyam Prasad <Shyam.Prasad@microsoft.com> wrote:
> >
> > Hi Naresh,
> >
> > AFAIK, this has been fixed in an updated patch last evening. Can you please check if you're still seeing it?
>
> Please share the fix commit and subject here.
>
> FYI,

ignore the below statement.
our build system did not trigger today tag yet.

> This build error is still on today's Linux next tag 20210409.

- Naresh

RE: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

[Shyam Prasad]

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

Attached the latest version of the patch.

Regards,
Shyam

-----Original Message-----
From: Naresh Kamboju <naresh.kamboju@linaro.org> 
Sent: Friday, April 9, 2021 11:24 PM
To: Shyam Prasad <Shyam.Prasad@microsoft.com>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>; samba-technical@lists.samba.org; lkft-triage@lists.linaro.org; Maciek Borzecki <maciek.borzecki@gmail.com>; Wan Jiabing <wanjiabing@vivo.com>; Steven French <Steven.French@microsoft.com>; pc <pc@cjr.nz>; Pavel Shilovskiy <pshilov@microsoft.com>; Steve French <sfrench@samba.org>
Subject: Re: [EXTERNAL] [next] ERROR: modpost: "dns_query" [fs/cifs/cifs.ko] undefined

On Fri, 9 Apr 2021 at 23:17, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> On Fri, 9 Apr 2021 at 21:49, Shyam Prasad <Shyam.Prasad@microsoft.com> wrote:
> >
> > Hi Naresh,
> >
> > AFAIK, this has been fixed in an updated patch last evening. Can you please check if you're still seeing it?
>
> Please share the fix commit and subject here.
>
> FYI,

ignore the below statement.
our build system did not trigger today tag yet.

> This build error is still on today's Linux next tag 20210409.

- Naresh

[-- Attachment #2: 4e456b30f78c429b183db420e23b26cde7e03a78.patch --]
[-- Type: application/octet-stream, Size: 4033 bytes --]

commit 4e456b30f78c429b183db420e23b26cde7e03a78
Author: Shyam Prasad N <sprasad@microsoft.com>
Date:   Wed Mar 31 14:35:24 2021 +0000

    cifs: On cifs_reconnect, resolve the hostname again.
    
    On cifs_reconnect, make sure that DNS resolution happens again.
    It could be the cause of connection to go dead in the first place.
    
    This also contains the fix for a build issue identified by Intel bot.
    Reported-by: kernel test robot <lkp@intel.com>
    
    Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
    Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
    Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
    CC: <stable@vger.kernel.org> # 5.11+
    Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index fe03cbdae959..bf52e9326ebe 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -18,6 +18,7 @@ config CIFS
 	select CRYPTO_AES
 	select CRYPTO_LIB_DES
 	select KEYS
+	select DNS_RESOLVER
 	help
 	  This is the client VFS module for the SMB3 family of NAS protocols,
 	  (including support for the most recent, most secure dialect SMB3.1.1)
@@ -112,7 +113,6 @@ config CIFS_WEAK_PW_HASH
 config CIFS_UPCALL
 	bool "Kerberos/SPNEGO advanced session setup"
 	depends on CIFS
-	select DNS_RESOLVER
 	help
 	  Enables an upcall mechanism for CIFS which accesses userspace helper
 	  utilities to provide SPNEGO packaged (RFC 4178) Kerberos tickets
@@ -179,7 +179,6 @@ config CIFS_DEBUG_DUMP_KEYS
 config CIFS_DFS_UPCALL
 	bool "DFS feature support"
 	depends on CIFS
-	select DNS_RESOLVER
 	help
 	  Distributed File System (DFS) support is used to access shares
 	  transparently in an enterprise name space, even if the share
diff --git a/fs/cifs/Makefile b/fs/cifs/Makefile
index 5213b20843b5..3ee3b7de4ded 100644
--- a/fs/cifs/Makefile
+++ b/fs/cifs/Makefile
@@ -10,13 +10,14 @@ cifs-y := trace.o cifsfs.o cifssmb.o cifs_debug.o connect.o dir.o file.o \
 	  cifs_unicode.o nterr.o cifsencrypt.o \
 	  readdir.o ioctl.o sess.o export.o smb1ops.o unc.o winucase.o \
 	  smb2ops.o smb2maperror.o smb2transport.o \
-	  smb2misc.o smb2pdu.o smb2inode.o smb2file.o cifsacl.o fs_context.o
+	  smb2misc.o smb2pdu.o smb2inode.o smb2file.o cifsacl.o fs_context.o \
+	  dns_resolve.o
 
 cifs-$(CONFIG_CIFS_XATTR) += xattr.o
 
 cifs-$(CONFIG_CIFS_UPCALL) += cifs_spnego.o
 
-cifs-$(CONFIG_CIFS_DFS_UPCALL) += dns_resolve.o cifs_dfs_ref.o dfs_cache.o
+cifs-$(CONFIG_CIFS_DFS_UPCALL) += cifs_dfs_ref.o dfs_cache.o
 
 cifs-$(CONFIG_CIFS_SWN_UPCALL) += netlink.o cifs_swn.o
 
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index eec8a2052da2..24668eb006c6 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -87,7 +87,6 @@ static void cifs_prune_tlinks(struct work_struct *work);
  *
  * This should be called with server->srv_mutex held.
  */
-#ifdef CONFIG_CIFS_DFS_UPCALL
 static int reconn_set_ipaddr_from_hostname(struct TCP_Server_Info *server)
 {
 	int rc;
@@ -124,6 +123,7 @@ static int reconn_set_ipaddr_from_hostname(struct TCP_Server_Info *server)
 	return !rc ? -1 : 0;
 }
 
+#ifdef CONFIG_CIFS_DFS_UPCALL
 /* These functions must be called with server->srv_mutex held */
 static void reconn_set_next_dfs_target(struct TCP_Server_Info *server,
 				       struct cifs_sb_info *cifs_sb,
@@ -321,14 +321,29 @@ cifs_reconnect(struct TCP_Server_Info *server)
 #endif
 
 #ifdef CONFIG_CIFS_DFS_UPCALL
+		if (cifs_sb && cifs_sb->origin_fullpath)
 			/*
 			 * Set up next DFS target server (if any) for reconnect. If DFS
 			 * feature is disabled, then we will retry last server we
 			 * connected to before.
 			 */
 			reconn_set_next_dfs_target(server, cifs_sb, &tgt_list, &tgt_it);
+		else {
+#endif
+			/*
+			 * Resolve the hostname again to make sure that IP address is up-to-date.
+			 */
+			rc = reconn_set_ipaddr_from_hostname(server);
+			if (rc) {
+				cifs_dbg(FYI, "%s: failed to resolve hostname: %d\n",
+						__func__, rc);
+			}
+
+#ifdef CONFIG_CIFS_DFS_UPCALL
+		}
 #endif
 
+
 #ifdef CONFIG_CIFS_SWN_UPCALL
 		}
 #endif